From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30049.outbound.protection.outlook.com [40.107.3.49]) by dpdk.org (Postfix) with ESMTP id 0035AF11 for ; Wed, 5 Sep 2018 08:34:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2NEGNNKu/nXNs0gVWipJ6db/BokZUYc56us2HmbvUxw=; b=pOQ9VEGsnWbCaybQpau/SzRkbF2z2NqIl6GZNInyfKRdY5XP6NH2809sWgHynAdeYkaGLZazXhkiFpp2QPo6tiJbcjEe5YczGYb3yKlDgsKOZ0VicU9T2vrEyTwbW7Eh7UL8KePmA0qGWi4fyWS2lZfK9XBjd7VjQaEjT5fvYX8= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB4041.eurprd05.prod.outlook.com (52.134.72.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1101.18; Wed, 5 Sep 2018 06:34:41 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::d45:8e84:6d63:c57c]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::d45:8e84:6d63:c57c%2]) with mapi id 15.20.1101.016; Wed, 5 Sep 2018 06:34:41 +0000 From: Yongseok Koh To: Chas Williams <3chas3@gmail.com> CC: dpdk stable , "mark.rutland@arm.com" , Chas Williams Thread-Topic: [dpdk-stable] [PATCH][v4.9.y] Fixes: 3c226c637b69 ("mm: numa: avoid waiting on freed migrated pages") Thread-Index: AQHURLKbG6fMzKoHpUKO25mj6i1VcKThO6WA Date: Wed, 5 Sep 2018 06:34:40 +0000 Message-ID: <2310432A-D93A-4D6A-B3F3-8C885F95D819@mellanox.com> References: <20180905005129.6242-1-3chas3@gmail.com> In-Reply-To: <20180905005129.6242-1-3chas3@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [73.222.116.174] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB3PR0502MB4041; 6:P4CVhEDW2rXa4sMr7mjww0Zz3BFGJ9h0uyxlOsbH4QFjATSd//llLkczMWvGAqWDIsmmaIl2aEQyA1Wx7g0gFGx1jYO8bmLi5gFrE/nu410qKzYTZ4vQdTpYkHtuk916fxktS1zIvhAOdbrOvQu0ZlknHg5eo1uupn7kFOXCKsbKKYerOJVas4iv8Mv4rVFSHs8HRZL0wSPBkjvOkEyMOJnhIviEYiMVeuwIYrUTCDbH494TgqMtUAXErJzCYkDQNfuCY35duTrpjiZ40uXy5a8NMt7AZfsEcZXTmato/iCpZdGR/ZA+YcTVOxJYm+CrfIEPupolO9ws6aK93O7SCqkl8eNeewfdq7bpSdPhb+tBTunf4lbOI90Y0Jb7RJ19bv7W7K1xRxLS3G6N7f1PEhJ3X5+bF701wmdYJUn4UNHWLHYtsMEbL+67enGvF1MZNzKOgV9riSco/tAbyCt5RA==; 5:dw/ZurScPB/k8UJZ+4Lgk3A+EVt4IBv3KkEQlxpFWnJcMULaZD5MvF/Qmbs7vd7WKnnfgkm++2wrBN5BltUHXOBJHde7vp6phhfggQ8PIl+JmpwpU/gz6yFURKiesEKPj+5b+vFIJDShFAhdCEx0rVGRyrPV331XHoxCNQqBVaM=; 7:B+RC834BWiqCkajF/shv3av6FJ9HjtWcR0YE/C05DFh59AGkTkiBcabCc0SsJFGRb7XURTg1obVbAQBZcCBTjkTwKQuZ224vpC/eq/Dnis/pjBYX5mB2qOdAsw6X71hOhA48XGXH1Fk8AxcLS6x8oT2JHlcxME2JfiSE3tBXgAcgqPKp4+WAf2IGXhwKuy+da++xayttm5sn51+y4VLYoH+yaR6QaQS5JEhu6HMDLYBBmjmtJsHcWAP71T1u7FgY x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 8e9b7b89-74b8-43ae-afbd-08d612f9a8f4 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB3PR0502MB4041; x-ms-traffictypediagnostic: DB3PR0502MB4041: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(85827821059158)(97927398514766); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3231311)(944501410)(52105095)(3002001)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123560045)(20161123564045)(20161123562045)(201708071742011)(7699016); SRVR:DB3PR0502MB4041; BCL:0; PCL:0; RULEID:; SRVR:DB3PR0502MB4041; x-forefront-prvs: 078693968A x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(136003)(396003)(366004)(376002)(346002)(189003)(199004)(476003)(2900100001)(86362001)(478600001)(446003)(11346002)(25786009)(2616005)(14444005)(36756003)(256004)(6916009)(486006)(6512007)(6486002)(229853002)(6436002)(186003)(5660300001)(6116002)(3846002)(39060400002)(4326008)(53936002)(6246003)(1411001)(105586002)(106356001)(8936002)(81166006)(81156014)(76176011)(97736004)(102836004)(7736002)(33656002)(305945005)(2906002)(66066001)(82746002)(5250100002)(83716003)(53546011)(6506007)(14454004)(99286004)(54906003)(26005)(68736007)(316002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4041; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: bS6YQHNGU5stSCCDg03sKEW1bCOMZKdr8SGHJKPYLCQmYbPnRjt26PQSpHPheV8QLbL2Lkp4Xz+9crOxGBK0i6r2UKVpsn+IcYEI2GY9bH8YWYa9Ot23b7J857n/eK4Zj6+GZS13lJs55L3ZbRJ2K4QbwnRQKFhiafSTxRE+O3kDlFYp58hvF886oisu2Bh/h+DLC9yFmSD61v45raN6mU4jt3OHS603aGKRaZTHlxqkCBvKlLRc4KXp41o5mgQNP32Cz5S5FQe7IkbCuPTcx+nvKptB6cLCEYpqGFO6mFbm+X58fLJkvVfLZDqq4dVIYK4Ws8HZyxhoTK/RXZXF4DBfvS7WtRf9NN+sZ9/v9uc= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <7D08DD38F92170408AC9E36C57ED56BD@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8e9b7b89-74b8-43ae-afbd-08d612f9a8f4 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Sep 2018 06:34:40.8377 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4041 Subject: Re: [dpdk-stable] [PATCH][v4.9.y] Fixes: 3c226c637b69 ("mm: numa: avoid waiting on freed migrated pages") X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Sep 2018 06:34:43 -0000 > On Sep 4, 2018, at 5:51 PM, Chas Williams <3chas3@gmail.com> wrote: >=20 > From: Chas Williams >=20 > Commit 3c226c637b69 ("mm: numa: avoid waiting on freed migrated pages") > was an incomplete backport of the upstream commit. It is necessary to > always reset page_nid before attempting any early exit. > --- > mm/huge_memory.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 9efe88ef9702..e4c6c3edaf6a 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c Looks like a kernel patch has been sent to DPDK community. ;-) Thanks, Yongseok > @@ -1259,12 +1259,12 @@ int do_huge_pmd_numa_page(struct fault_env *fe, p= md_t pmd) >=20 > /* Migration could have started since the pmd_trans_migrating check */ > if (!page_locked) { > + page_nid =3D -1; > if (!get_page_unless_zero(page)) > goto out_unlock; > spin_unlock(fe->ptl); > wait_on_page_locked(page); > put_page(page); > - page_nid =3D -1; > goto out; > } >=20 > --=20 > 2.14.4 >=20