* [dpdk-stable] [PATCH][v4.9.y] Fixes: 3c226c637b69 ("mm: numa: avoid waiting on freed migrated pages")
@ 2018-09-05 0:51 Chas Williams
2018-09-05 6:34 ` Yongseok Koh
0 siblings, 1 reply; 3+ messages in thread
From: Chas Williams @ 2018-09-05 0:51 UTC (permalink / raw)
To: stable; +Cc: mark.rutland, Chas Williams
From: Chas Williams <chas3@att.com>
Commit 3c226c637b69 ("mm: numa: avoid waiting on freed migrated pages")
was an incomplete backport of the upstream commit. It is necessary to
always reset page_nid before attempting any early exit.
---
mm/huge_memory.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index 9efe88ef9702..e4c6c3edaf6a 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -1259,12 +1259,12 @@ int do_huge_pmd_numa_page(struct fault_env *fe, pmd_t pmd)
/* Migration could have started since the pmd_trans_migrating check */
if (!page_locked) {
+ page_nid = -1;
if (!get_page_unless_zero(page))
goto out_unlock;
spin_unlock(fe->ptl);
wait_on_page_locked(page);
put_page(page);
- page_nid = -1;
goto out;
}
--
2.14.4
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-stable] [PATCH][v4.9.y] Fixes: 3c226c637b69 ("mm: numa: avoid waiting on freed migrated pages")
2018-09-05 0:51 [dpdk-stable] [PATCH][v4.9.y] Fixes: 3c226c637b69 ("mm: numa: avoid waiting on freed migrated pages") Chas Williams
@ 2018-09-05 6:34 ` Yongseok Koh
2018-09-05 9:00 ` Chas Williams
0 siblings, 1 reply; 3+ messages in thread
From: Yongseok Koh @ 2018-09-05 6:34 UTC (permalink / raw)
To: Chas Williams; +Cc: dpdk stable, mark.rutland, Chas Williams
> On Sep 4, 2018, at 5:51 PM, Chas Williams <3chas3@gmail.com> wrote:
>
> From: Chas Williams <chas3@att.com>
>
> Commit 3c226c637b69 ("mm: numa: avoid waiting on freed migrated pages")
> was an incomplete backport of the upstream commit. It is necessary to
> always reset page_nid before attempting any early exit.
> ---
> mm/huge_memory.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> index 9efe88ef9702..e4c6c3edaf6a 100644
> --- a/mm/huge_memory.c
> +++ b/mm/huge_memory.c
Looks like a kernel patch has been sent to DPDK community. ;-)
Thanks,
Yongseok
> @@ -1259,12 +1259,12 @@ int do_huge_pmd_numa_page(struct fault_env *fe, pmd_t pmd)
>
> /* Migration could have started since the pmd_trans_migrating check */
> if (!page_locked) {
> + page_nid = -1;
> if (!get_page_unless_zero(page))
> goto out_unlock;
> spin_unlock(fe->ptl);
> wait_on_page_locked(page);
> put_page(page);
> - page_nid = -1;
> goto out;
> }
>
> --
> 2.14.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-stable] [PATCH][v4.9.y] Fixes: 3c226c637b69 ("mm: numa: avoid waiting on freed migrated pages")
2018-09-05 6:34 ` Yongseok Koh
@ 2018-09-05 9:00 ` Chas Williams
0 siblings, 0 replies; 3+ messages in thread
From: Chas Williams @ 2018-09-05 9:00 UTC (permalink / raw)
To: yskoh; +Cc: stable, mark.rutland, Chas Williams
On Wed, Sep 5, 2018 at 2:34 AM Yongseok Koh <yskoh@mellanox.com> wrote:
>
> > On Sep 4, 2018, at 5:51 PM, Chas Williams <3chas3@gmail.com> wrote:
> >
> > From: Chas Williams <chas3@att.com>
> >
> > Commit 3c226c637b69 ("mm: numa: avoid waiting on freed migrated pages")
> > was an incomplete backport of the upstream commit. It is necessary to
> > always reset page_nid before attempting any early exit.
> > ---
> > mm/huge_memory.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> > index 9efe88ef9702..e4c6c3edaf6a 100644
> > --- a/mm/huge_memory.c
> > +++ b/mm/huge_memory.c
>
> Looks like a kernel patch has been sent to DPDK community. ;-)
>
Well they both start stable... :) Thanks for the heads up!
>
> Thanks,
> Yongseok
>
> > @@ -1259,12 +1259,12 @@ int do_huge_pmd_numa_page(struct fault_env *fe,
> pmd_t pmd)
> >
> > /* Migration could have started since the pmd_trans_migrating
> check */
> > if (!page_locked) {
> > + page_nid = -1;
> > if (!get_page_unless_zero(page))
> > goto out_unlock;
> > spin_unlock(fe->ptl);
> > wait_on_page_locked(page);
> > put_page(page);
> > - page_nid = -1;
> > goto out;
> > }
> >
> > --
> > 2.14.4
> >
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-05 9:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-05 0:51 [dpdk-stable] [PATCH][v4.9.y] Fixes: 3c226c637b69 ("mm: numa: avoid waiting on freed migrated pages") Chas Williams
2018-09-05 6:34 ` Yongseok Koh
2018-09-05 9:00 ` Chas Williams
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).