From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91650A0A0C for ; Fri, 30 Jul 2021 13:32:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8A7EA40DDC; Fri, 30 Jul 2021 13:32:26 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id A7B1E4003F; Fri, 30 Jul 2021 13:32:23 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E65955C00B8; Fri, 30 Jul 2021 07:32:22 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 30 Jul 2021 07:32:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= FVQSya1lqnTgNTc4sMU33OjXQCBWyXvS2NnUn9gEiXI=; b=a+580TbPbJThp39N 0k8ku2HZAQjHy95hNMMmXESnCKCLF9wGMV6Y9btvvOLeewN4jOHQHtjqMn3/JMMS jn6tCGcNi7ZFvQZZU3WMR6fvj8kMd4FvRXrYoOI2kAx032c39Woz5jgYAFo3UO9k NkX7/Y7qf6UjedGQuVqSLSp/IUrmDg7XDCsDaPKfzt2LNf0Sk0j/OQf4Hj2Z8qVk nfuBn8oYsPd3h+5LdpisZ2Vd0DvUX2UnJyhgLiKtWx+snDY+lWGZp3LjGg0ECRoU 7O59BeYfp08QDqQQTsZMz9Pkz8wM9U+lY6FCd4wlm/cruuG+8aZp556AQc1LFctF MK7SOw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=FVQSya1lqnTgNTc4sMU33OjXQCBWyXvS2NnUn9gEi XI=; b=WzIU2auJKFe/bK7GKLxrAc5eEytYBmzksFcunfvq23qxEH3C6K8qzRe2k IWlgVN2k5cLWEmyR4Jz+xODPbvCyBbh7WrAQAYw3ncX/LYQLAEWkbz8unNFLgoFu ZRRKFKU2kXv7iI5MnB6wwSbRC54oLb/HGaD0/fc4x5xxLOR8/IUNtA5/5zzRw+9+ VQzkLQuPLAFR2T6AiuO6p3FoNX4/KDyf2Isx6JVquTzIq9cWmxoPyi4MVYyKMhTK quDErLKWhED7emswgVZ6fEQMHBp+91D8nIwQdKn9frXNUd3VRYkHDxGjR6M/Kbve 2TmycybbowBqp/cab427QQFspgAtw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrheehgdefjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 30 Jul 2021 07:32:21 -0400 (EDT) From: Thomas Monjalon To: "Yu, DapengX" Cc: "Dumitrescu, Cristian" , dev@dpdk.org, "stable@dpdk.org" , "Singh, Jasvinder" Date: Fri, 30 Jul 2021 13:33:08 +0200 Message-ID: <2310711.Hr5GLslOta@thomas> In-Reply-To: References: <20210727081459.1145664-1-dapengx.yu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/softnic: fix null pointer dereference X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > > From: Dapeng Yu > > > > When there is no "firmware" in arguments, the "firmware" pointer is null, > > and will be dereferenced by rte_strscpy(). > > > > This patch moves the code block which copies character string from > > "firmware" to "p->firmware" into the "if" statements where "firmware" > > argument exists and it is duplicated successfully. > > > > Coverity issue: 372136 > > Fixes: d8f852f5f369 ("net/softnic: fix memory leak in arguments parsing") > > Cc: stable@dpdk.org > > > > Signed-off-by: Dapeng Yu > > Acked-by: Jasvinder Singh Applied, thanks.