From: Thomas Monjalon <thomas@monjalon.net>
To: Feifei Wang <feifei.wang2@arm.com>
Cc: Jerin Jacob <jerinj@marvell.com>,
Ruifeng Wang <ruifeng.wang@arm.com>, Jeff Guo <jia.guo@intel.com>,
Haiyue Wang <haiyue.wang@intel.com>,
dev@dpdk.org, nd@arm.com, stable@dpdk.org,
Paolo Valerio <pvalerio@redhat.com>,
david.marchand@redhat.com, qi.z.zhang@intel.com,
ferruh.yigit@intel.com
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v1] net/ixgbe: fix UDP zero checksum error for Arm NEON path
Date: Wed, 10 Feb 2021 21:46:24 +0100 [thread overview]
Message-ID: <2321995.G3BrELjmaN@thomas> (raw)
In-Reply-To: <20210208090704.1856110-1-feifei.wang2@arm.com>
08/02/2021 10:07, Feifei Wang:
> There is an 82599 errata that UDP frames with a zero checksum are
> incorrectly marked as checksum invalid by the hardware. This was
> leading to misleading PKT_RX_L4_CKSUM_BAD flag.
>
> To fix it for the NEON path in Arm platform, change the bad UDP checksum to
> unknown, and then let software application to recompute the checksum.
>
> This patch depends on:
> http://patches.dpdk.org/patch/87750/
>
> NICs: 82599(igb)
> Driver: ixgbe(vector)
> Architecture: arm64
> $:./app/dpdk-testpmd -c 0x3 -w 0002:f9:00.0 -- -i
> --port-topology=chained --enable-rx-cksum
> test-pmd> set fwd rxonly
> test-pmd> set verbose 1
> test-pmd> start
>
> 1. UDP Test:
> Package: (Ether()/IP()/UDP(checksum=0)
> ol_flags: PKT_RX_L4_CKSUM_UNKNOWN PKT_RX_IP_CKSUM_GOOD
>
> 2. TCP Test:
> Package: (Ether()/IP()/TCP(checksum=0)
> ol_flags: PKT_RX_L4_CKSUM_BAD PKT_RX_IP_CKSUM_GOOD
>
> Bugzilla ID: 629
> Fixes: af75078fece3 ("first public release")
> Cc: stable@dpdk.org
>
> Reported-by: Paolo Valerio <pvalerio@redhat.com>
> Signed-off-by: Feifei Wang <feifei.wang2@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
I wonder why the patch for SSE Rx is applied in next-net-intel
while this one for NEON Rx is ignored.
Either I merge both or none.
I'll go with both.
Applied, thanks.
prev parent reply other threads:[~2021-02-10 20:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 9:07 [dpdk-stable] " Feifei Wang
2021-02-10 20:46 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2321995.G3BrELjmaN@thomas \
--to=thomas@monjalon.net \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=feifei.wang2@arm.com \
--cc=ferruh.yigit@intel.com \
--cc=haiyue.wang@intel.com \
--cc=jerinj@marvell.com \
--cc=jia.guo@intel.com \
--cc=nd@arm.com \
--cc=pvalerio@redhat.com \
--cc=qi.z.zhang@intel.com \
--cc=ruifeng.wang@arm.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).