From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 564CC431FC for ; Wed, 25 Oct 2023 18:46:38 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4C37742DD2; Wed, 25 Oct 2023 18:46:38 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id F3FD740042; Wed, 25 Oct 2023 18:46:35 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id F016B3200914; Wed, 25 Oct 2023 12:46:33 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 25 Oct 2023 12:46:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1698252393; x=1698338793; bh=esRKAnw1et6+NjeubpyApd0mze5HCVBUtMh 1fQDoMfk=; b=qNCk+V4cKhnB6X4pWmdfOWtbDtBJHAV8Qm/nTmlwh6rzdI0aa8j aC8ME1tYZAXwTF6v3022/5kJNFDsOsfGnorJ/h0A80r8qj3vLpdftqQRmXGDLtLo cTMNJJU2mjXA/gw193VBjTb+teNXbmlHTcymzgsiiiZPXf5VTqLYF32+1nplBSFY +/UjM+/NIa4KmyJJhHKIf5WTONmFzKkpiPJSdhzk+ICxmr6zsLyXKYsNLYgyyc00 snwnt+lDbfIuC77gigYQNZ8lVECdclY86lbKjXZavdIBSbe3317CyNJol6h2k6Ws UFDy3idUxIXkB+UIxm7r1yHyjN91Xx4vJIg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1698252393; x=1698338793; bh=esRKAnw1et6+NjeubpyApd0mze5HCVBUtMh 1fQDoMfk=; b=poK8qnBHLU5wdb+GbMQms01eV9MI5EA98rshka8VPvFS2eAyLRK DjwkDi02s+FGYB6/xAWcEAHag0t+mctZN1itB4F+dLD6LkKqPSzIgTDaRLQfGwni z7/QSYIBPxFwYeG/kH9JLQmO/asyz6+C1l8Yf487uD33A297h4eAc4ukYpoFodup Ma6KN9WnLGgvFKoiOf8nABxmifHddkvyYyjLe04kU+v6bvEDoa02pXGITuIosQ4V g2zcTnMiJvigiuszuxdkiq7jBzEPhd6oMDkjKWdd3f63QTe/9JPY7R6GHIJhc+P2 vaTC9GbgJpKJ1y6Lm42TYzH+HVNYBeQdO4g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrledtgddutdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 25 Oct 2023 12:46:31 -0400 (EDT) From: Thomas Monjalon To: Stephen Hemminger Cc: dev@dpdk.org, David Marchand , stable@dpdk.org, Morten =?ISO-8859-1?Q?Br=F8rup?= , Anatoly Burakov , Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , Tyler Retzlaff , Andrew Rybchenko , Konstantin Ananyev Subject: Re: [PATCH v2] eal/unix: allow creating thread with real-time priority Date: Wed, 25 Oct 2023 18:46:29 +0200 Message-ID: <23265462.6Emhk5qWAg@thomas> In-Reply-To: <20231025083700.4e3e274c@hermes.local> References: <20231024125416.798897-1-thomas@monjalon.net> <20231025151352.995318-1-thomas@monjalon.net> <20231025083700.4e3e274c@hermes.local> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org 25/10/2023 17:37, Stephen Hemminger: > On Wed, 25 Oct 2023 17:13:14 +0200 > Thomas Monjalon wrote: > > > case RTE_THREAD_PRIORITY_REALTIME_CRITICAL: > > + /* > > + * WARNING: Real-time busy loop takes priority on kernel threads, > > + * making the system unstable. > > + * There is also a known issue when using rte_ring. > > + */ > > I was thinking something like: > > static bool warned; > if (!warned) { > RTE_LOG(NOTICE, EAL, "Real time priority is unstable when thread is polling without sleep\n"); > warned = true; > } I'm not sure about bothering users. They can fear something is wrong even if the developer took care of it. I think doc warnings for developers are more appropriate. I've added notes in the API.