From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BADA8A0598 for ; Wed, 8 Apr 2020 19:51:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A84E41C1BE; Wed, 8 Apr 2020 19:51:46 +0200 (CEST) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by dpdk.org (Postfix) with ESMTP id 59A521C0CF; Wed, 8 Apr 2020 19:51:43 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id C598E5800CB; Wed, 8 Apr 2020 13:51:42 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Wed, 08 Apr 2020 13:51:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=xMhEWmvQnF1Bi/ifJZPYAQWLvkv0/+/2NqNAlWNCkgg=; b=QtNjhV5htJtU GKQ+sbvLs7tTZxOW8YhUy35M7g1s9uNPpKoS0Ns49EaGFvB0/SttFjQgWbPN/QRb 8cdH3uzUXy8l0s8kuNimhtrZMNF4aRSyvJatkts0fgK4msFM2c/zMYLlJESerUwy m7J+3O4LZXkol2U9ewiGPDWR/yu6TO8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=xMhEWmvQnF1Bi/ifJZPYAQWLvkv0/+/2NqNAlWNCk gg=; b=UkjkmN1sdNeJkveBUOOy/Gnz+7SKrx34NbQZpNjvLE+lRG4u0cyAVkv/s 19zs6XWek/F4eC47zm6Md5K17mx5C+n8IP3O8Mv+oKRAAtZmnfPWuNbUeTt9truA z9RD+thqbXz+dZXJM9q3Qbq/eH52SRNiUEiVfAteNC5F9X7FzNm6DMPBef+iIDJL tWL8uckVdPSRQrdTobKhenMThNyS/vZRnACy54C+SLALvQP8ASa5Qj6bMouum7df fUq+P0Qw+SHRCDjB9dpJc3+lgf2IQWObWIxQ3V1fsfxnzC1luSdNQCsAq0Us8DAt 6TxBUHaOVefLncr25mx2BuUXCo0rw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudejgdduudeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghrufhiiigvpedunecurfgr rhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id DC4B6328006A; Wed, 8 Apr 2020 13:51:37 -0400 (EDT) From: Thomas Monjalon To: Lukasz Wojciechowski Cc: Anoob Joseph , Akhil Goyal , Declan Doherty , Aviad Yehezkel , Boris Pismenny , Radu Nicolau , Anoob Joseph , "dev@dpdk.org" , "stable@dpdk.org" , bruce.richardson@intel.com Date: Wed, 08 Apr 2020 19:51:35 +0200 Message-ID: <2333397.jE0xQCEvom@thomas> In-Reply-To: <827f9660-dd8e-8440-c8b0-d34064ffdffe@partner.samsung.com> References: <20200312151654.7218-1-l.wojciechow@partner.samsung.com> <827f9660-dd8e-8440-c8b0-d34064ffdffe@partner.samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-stable] [EXT] Re: [dpdk-dev] [PATCH v2 01/13] security: fix verification of parameters X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" 08/04/2020 17:49, Lukasz Wojciechowski: > Hi guys, > > I don't know what is the current status of "legacy" build using > gnumakes, so I added the new DEBUG flag to config just as it was done in > other libs like eventdev. > Many guides still point config files as the one that should be changed > in order to enable some features, so I thought I should add it there. > > If I understand well the official build system now is the one based on > using meson and ninja, however it hasn't got anything similar to the > gnamakefiles system, e.g. > in the meson.build file for libraries all the libraries have build > variable set to true and there are few ifs that check it, but as it's > set to true all libraries build always. > And each library considered there defines RTE_LIBRTE_[LIBRARY_NAME]. > It's kind of weird. > > foreach l:libraries > * build = true** > * reason = '' # set if build == false to explain why > ... > * if not build* > dpdk_libs_disabled += name > set_variable(name.underscorify() + '_disable_reason', reason) > else > enabled_libs += name > *dpdk_conf.set('RTE_LIBRTE_' + name.to_upper(), 1)* > ... > > Have you think about reusing config files in meson configuration and > have a single point of configuration? Of course all meson flags can > overwrite the default config. This is on purpose. We are removing most of compile-time options with meson. I think we can use a global option for debug-specific code. Bruce, what do you recommend?