* Re: [dpdk-stable] [dpdk-dev] [PATCH v4] mbuf: fix mbuf free performance with non atomic refcnt [not found] ` <20171208154651.16546-1-olivier.matz@6wind.com> @ 2017-12-11 10:28 ` Olivier MATZ 2018-01-18 23:23 ` Thomas Monjalon 1 sibling, 0 replies; 2+ messages in thread From: Olivier MATZ @ 2017-12-11 10:28 UTC (permalink / raw) To: dev, hhaim, stable; +Cc: matvejchikov, konstantin.ananyev On Fri, Dec 08, 2017 at 04:46:51PM +0100, Olivier Matz wrote: > When RTE_MBUF_REFCNT_ATOMIC=n, the decrement of the mbuf reference > counter uses an atomic operation. This is not necessary and impacts > the performance (seen with TRex traffic generator). > > We cannot replace rte_atomic16_add_return() by rte_mbuf_refcnt_update() > because it would add an additional check. > > Solves this by introducing __rte_mbuf_refcnt_update(), which > updates the reference counter without doing anything else. > > Fixes: 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool") > Suggested-by: Hanoch Haim <hhaim@cisco.com> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com> Forgot to Cc stable@dpdk.org ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v4] mbuf: fix mbuf free performance with non atomic refcnt [not found] ` <20171208154651.16546-1-olivier.matz@6wind.com> 2017-12-11 10:28 ` [dpdk-stable] [dpdk-dev] [PATCH v4] mbuf: fix mbuf free performance with non atomic refcnt Olivier MATZ @ 2018-01-18 23:23 ` Thomas Monjalon 1 sibling, 0 replies; 2+ messages in thread From: Thomas Monjalon @ 2018-01-18 23:23 UTC (permalink / raw) To: Olivier Matz; +Cc: dev, hhaim, matvejchikov, konstantin.ananyev, stable 08/12/2017 16:46, Olivier Matz: > When RTE_MBUF_REFCNT_ATOMIC=n, the decrement of the mbuf reference > counter uses an atomic operation. This is not necessary and impacts > the performance (seen with TRex traffic generator). > > We cannot replace rte_atomic16_add_return() by rte_mbuf_refcnt_update() > because it would add an additional check. > > Solves this by introducing __rte_mbuf_refcnt_update(), which > updates the reference counter without doing anything else. > > Fixes: 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool") > Suggested-by: Hanoch Haim <hhaim@cisco.com> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com> Applied, thanks ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-18 23:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20171115091413.27119-1-hhaim@cisco.com>
[not found] ` <20171208154651.16546-1-olivier.matz@6wind.com>
2017-12-11 10:28 ` [dpdk-stable] [dpdk-dev] [PATCH v4] mbuf: fix mbuf free performance with non atomic refcnt Olivier MATZ
2018-01-18 23:23 ` Thomas Monjalon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).