From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 107669B6B; Wed, 11 Oct 2017 14:43:41 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 86020214D6; Wed, 11 Oct 2017 08:43:40 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Wed, 11 Oct 2017 08:43:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=SRi6vLBdnQQSUy8rKfRzyiiTf2 6MyL+pAafznJDH/3I=; b=A2UT5V81uy39ikp7L+Mx6085Q7HkE5P7kA3xNOffjo wdqCGaE1m95kvxyxGYDS6Vs5z8SuHWGtGzUkcK3aTP2vbEmoqt3z+QuPwHxClfSB 2+DkycNGLx92wF6J/S7Iv/k+u3yyO4saq0w/ozY0SWM20H0yZVcD9l6CMlfw5EJd 0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=SRi6vL BdnQQSUy8rKfRzyiiTf26MyL+pAafznJDH/3I=; b=lDhFeQ02buMPU7+jo0SV0T o4c6MNASwL9yRifupGzRjic+gdUdKLZOyufscjanAGVl4PoN1ttK9hI6Qas6vIqY b7s+aIOL39LmizwgXe70eeUkJeGfchzupeviot2B/T6Zledygr4ljYT0XG+ZzbyJ eGuLcT6cGKh9+/9W0yLzjjmYxPbjrkgEh9NUQyVXLkHQg952SnlH/nqZXjGdsDuB xF6IAXlBzwNTmeiVluW67TpWE2BJLCgUiIqJFfWmBrMMOzNAwBJCFvC20pU4ywRP UdxmJQyXxTT0FqSzinz/61NmQf6SoXGj6Dskd6Vk01u/myGZapIB7zDHYoCRYcMQ == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 29BA97EAFA; Wed, 11 Oct 2017 08:43:40 -0400 (EDT) From: Thomas Monjalon To: Daniel Mrzyglod Cc: stable@dpdk.org, dev@dpdk.org Date: Wed, 11 Oct 2017 14:43:39 +0200 Message-ID: <2376015.Aqjpq7JAko@xps> In-Reply-To: <20171011115353.40043-1-danielx.t.mrzyglod@intel.com> References: <20170922144820.16590-1-danielx.t.mrzyglod@intel.com> <20171011115353.40043-1-danielx.t.mrzyglod@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-stable] [PATCH v3] eal: fix resource leak X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Oct 2017 12:43:41 -0000 11/10/2017 13:53, Daniel Mrzyglod: > Memory allocated in strdup is not free. > > Coverity issue: 143257 > Fixes: d8a2bc71dfc2 ("log: remove app path from syslog id") > Cc: thomas@monjalon.net > Cc: stable@dpdk.org > > Signed-off-by: Daniel Mrzyglod Given this recent commit: http://dpdk.org/commit/e3f141879ef I think we should consider this issue as a false positive. The arguments given to rte_eal_init may be freed. So it's better to strdup them, even if it is never freed.