From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 19E48A10DA for ; Fri, 2 Aug 2019 01:57:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B0AD71C1BA; Fri, 2 Aug 2019 01:57:33 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130073.outbound.protection.outlook.com [40.107.13.73]) by dpdk.org (Postfix) with ESMTP id 376D91C1BA for ; Fri, 2 Aug 2019 01:57:31 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LPTAmFDRtF4rooxNQus89G1q6N7iWjeqKVdHy9S+fBCOEXJdumMCD/6xqao+LGKSdygWvB+aYYc5PzJ277aFdrpBHKQdAiisvB7nzaXkwTz4NiggAPEMLbF4Fj596i0aPh1l+oFUWVYEDCZK+pI2cWEdp3n/gqhMSejqEb0Ej1sfa+XIn1A7uvvknbih5/YxnFkxgGpVyEIvBhIdB1BEXOGpiRxkRMQxuOKGRIjpgNCZYV9hX+8Mx6hZh2GVNWmeTqAwo+YYjlfDhOa38kJ5/ZpICGVcaqiOp0ZjQwcdIP4zs1N0EFuDs+k37b0eht+MznBH8c15qr6mHN5/1Q6HNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TyIHTnV5OOl5i5i72xOW2qWmy02LCM2uxNfVnd+/yEU=; b=PEK4sM2Sn4d9Zkkd5phOF4rUoBE5fSy6I2nGiL3Aao9HMxOpwLlKSkD5153hA/7P6uKlGjyjGhqNpbN9T03RKJuxxdTwvfAr59V8G9PBSqwP/Q50lXTAkBKtv+pKsqIB6aAk20jCJV+8LQKjdBVxgwKUr8QtVOxIbIuxw+zHj/Q2DkzdUD9pA0M/U/JgGnmzJCTZ/wPirR1Or5xUP6dPbdDIbgM9JUYOHaMiV7OiJ2O4kQ8BJwrt0/aiBhQ19Zu71tkEevaylW6yPik0GeVyGJVIHiDJWQ3PnDhPgvrkafSRxLgTeZW6+y6uX6si9mvluPBIGLLKEdPOpUnHd96b1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=mellanox.com;dmarc=pass action=none header.from=mellanox.com;dkim=pass header.d=mellanox.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TyIHTnV5OOl5i5i72xOW2qWmy02LCM2uxNfVnd+/yEU=; b=ARHNZzeuz+VZixMmGpQvuZfK4qkwJMS7EkIdKlPcKhha7s9IZGK2CRcqkR/LaFrYtaXkmA1p8v7JWVN+bty8H8vebxlNu+N2zUL+3jDNiQNdPwSXFUDxVo6Imz5/mHriqCivcyfrLHRAcdnyCTnZ2JBvr3M6Y+WQJsMIR882JnM= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB3979.eurprd05.prod.outlook.com (52.134.67.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2136.16; Thu, 1 Aug 2019 23:57:29 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::589a:a9d4:5426:d194]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::589a:a9d4:5426:d194%6]) with mapi id 15.20.2136.010; Thu, 1 Aug 2019 23:57:29 +0000 From: Yongseok Koh To: David Christensen CC: "stable@dpdk.org" Thread-Topic: [dpdk-stable] [PATCH 17.11] examples/vm_power_manager: add conditional compilation for PMD specific code Thread-Index: AQHVQk1BD60+a/gV4UueqKATNSZnGabnBSWA Date: Thu, 1 Aug 2019 23:57:29 +0000 Message-ID: <237C4C7B-6E88-455B-A54A-ED961CB2F26E@mellanox.com> References: <1563992744-39034-1-git-send-email-drc@linux.vnet.ibm.com> In-Reply-To: <1563992744-39034-1-git-send-email-drc@linux.vnet.ibm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2ad80787-60a0-43fb-dcc0-08d716dc0346 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:DB3PR0502MB3979; x-ms-traffictypediagnostic: DB3PR0502MB3979: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-forefront-prvs: 01165471DB x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(396003)(366004)(39860400002)(346002)(376002)(199004)(189003)(36756003)(14444005)(316002)(6436002)(7736002)(478600001)(305945005)(6486002)(86362001)(81166006)(229853002)(446003)(76176011)(81156014)(6512007)(14454004)(8936002)(2616005)(66066001)(53936002)(186003)(71200400001)(26005)(71190400001)(11346002)(6506007)(256004)(102836004)(2906002)(53546011)(476003)(33656002)(486006)(66946007)(25786009)(66476007)(64756008)(66556008)(6116002)(3846002)(66446008)(6916009)(76116006)(4326008)(5660300002)(99286004)(91956017)(6246003)(68736007); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB3979; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: C5V6RTzNfxuymEPbnSLbXpzbSAJvWsaRlxiuyHzYQ6JtYvpSx2CtYiEJ0ImALgQzWWr2p47aWY2PU8fiC1PjsGKdhYe6Sd/dRnKF9FrswBialfb+kVPhbTcpRh1xbTpq7Nt2+uxy3ubuT5NZf28ODLPOXqJOU5smw7oS+WMyjghEf8oaE976VxdxqLcJdk8NcD3ejg3ojdfpRKJCnoYkSOI/c491uifW+nrz6S8HNH6adXYKjE2GUsHWu8jdsDnqwF17/H8xvP2jVOhJ+npaXqHS7otsaUe0S3PJnaAXQgUyAt/FWf7hl5C1dnCXaLmDvzdEQemrBcbl+kI2Hs37CZbosZ85NoojxbAlosL22vJK99wTuZ+p5VntU4sUWvXBgz6pCcPCAJmwkN7zeb8/m/CZrnQk0YWcYBznYpV79lI= Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2ad80787-60a0-43fb-dcc0-08d716dc0346 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Aug 2019 23:57:29.8027 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yskoh@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB3979 Subject: Re: [dpdk-stable] [PATCH 17.11] examples/vm_power_manager: add conditional compilation for PMD specific code X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > On Jul 24, 2019, at 11:25 AM, David Christensen = wrote: >=20 > Running the devtools/test-build.sh script on IBM Power systems fails > because the IXGBE_PMD is explicity disabled for Power as an untested > driver, but the examples/vm_power_manager application has a hard > dependency on a function call in the IXGBE_PMD. >=20 > Modify the example application so that all dependencies on PMD code > are conditionally compiled. >=20 > Bugzilla ID: 237 > Fixes: Running test-build.sh fails on ppc_64 due to hard-coded > requirement for IXGBE_PMD in examples/vm_power_manager >=20 > Signed-off-by: David Christensen > --- Acked-by: Yongseok Koh applied to stable/17.11 > examples/vm_power_manager/main.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) >=20 > diff --git a/examples/vm_power_manager/main.c b/examples/vm_power_manager= /main.c > index 399fbdd..2ad6ff6 100644 > --- a/examples/vm_power_manager/main.c > +++ b/examples/vm_power_manager/main.c > @@ -58,9 +58,16 @@ > #include "channel_monitor.h" > #include "power_manager.h" > #include "vm_power_cli.h" > + > +#ifdef RTE_LIBRTE_IXGBE_PMD > #include > +#endif > +#ifdef RTE_LIBRTE_I40E_PMD > #include > +#endif > +#ifdef RTE_LIBRTE_BNXT_PMD > #include > +#endif >=20 > #define RX_RING_SIZE 512 > #define TX_RING_SIZE 512 > @@ -324,15 +331,21 @@ > for (w =3D 0; w < MAX_VFS; w++) { > eth.addr_bytes[5] =3D w + 0xf0; >=20 > +#ifdef RTE_LIBRTE_IXGBE_PMD > if (ret =3D=3D -ENOTSUP) > ret =3D rte_pmd_ixgbe_set_vf_mac_addr(portid, > w, ð); > +#endif > +#ifdef RTE_LIBRTE_I40E_PMD > if (ret =3D=3D -ENOTSUP) > ret =3D rte_pmd_i40e_set_vf_mac_addr(portid, > w, ð); > +#endif > +#ifdef RTE_LIBRTE_BNXT_PMD > if (ret =3D=3D -ENOTSUP) > ret =3D rte_pmd_bnxt_set_vf_mac_addr(portid, > w, ð); > +#endif >=20 > switch (ret) { > case 0: > --=20 > 1.8.3.1 >=20