From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 123FC42B3C for ; Thu, 18 May 2023 19:50:09 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0ECA142D29; Thu, 18 May 2023 19:50:09 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2069.outbound.protection.outlook.com [40.107.96.69]) by mails.dpdk.org (Postfix) with ESMTP id B971640A8A; Thu, 18 May 2023 19:50:06 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ASM8NNxqSLrcJsk9hQ4R5+arSPFIza3BqYlC3CQTFAWUSYm/TJ8F2DtbYf2tbpHwt65X8ZzxAnEDTE8eF9G3ADRxA6+78Pi9QtzKA6JZCELZC/QMMm7Z/3sOXhNWctmqW3r0Zd2wrpujFJ/E/o6mdaO7BEz6D6WWymnGrRliYXeRl/cAtLB5wniO/gqYTx/Qw5nVzpvItwf9IqxosDAIe80Jnhl+/JisUgwBkD1uvfKD254BTUfHh9JHbhn0TNsQPwSwEeTs9ay9nSf+SzrkhlbCczuPmv9jhPe5KrGIh7r8XzJxn1r73y9AQcxWFgjH2zjHpk8aRDDnyQLKy0yrtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7FZz3b8SAfl+UeS3JpMckaj3n5CcTYL+RzByiZoyW/g=; b=XI2RltCsPM6A7uxk0zBmhVzR+kiDYQPohzPYFv7B1nUeCD46+bjeXC9JY535nCoaz6eXVgCnsJQVjGiVGVeraUNbbFMrC2KCQkrZYfFMj/WDs8rDLo/dWbfd3aTLQX+R0H3otIiDsIYp1vYoEXVz1bdOrsuXMpd2vlExw+dR/XcsvfFdvltlCm9mKcK8UoPos2WqlkgFbtbg/0+n8k8skmAf+RkMs7yhvKC65xS4nrah16K7X6G+BSaM6AFBPfnaTofDB4HVofV2QDwCpVxgqrQJ8Yaz4wpYqqzJ3c6xmrIfIW35owMu26emJveoZmiNI63nsrJSAC5RNcuxXvX8lw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7FZz3b8SAfl+UeS3JpMckaj3n5CcTYL+RzByiZoyW/g=; b=Yfcnx8N9dHTicAVFKH/XOoMM9w2ZtDG3R2tfF7KH5uWwkhb+PIV9uorg70bBWW5+8SMXNtZJ6vxR2XVwpTJ7uZ4N3gQz1GXJo6728kfSUNBwYvrGJX8N/wjZNHdGr/yy8K1wt4nJ1ePzPiWurK9LkeR2p7czXrezehQhdbggA14= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SN7PR12MB6887.namprd12.prod.outlook.com (2603:10b6:806:261::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.19; Thu, 18 May 2023 17:50:04 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a%4]) with mapi id 15.20.6411.019; Thu, 18 May 2023 17:50:04 +0000 Message-ID: <24d99809-aec2-8192-8c7e-985af35f8b34@amd.com> Date: Thu, 18 May 2023 18:49:59 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [dpdk-dev] [PATCH 1/1] net/txgbe: fix use-after-free on remove Content-Language: en-US To: Jiawen Wu , 'Yunjian Wang' , dev@dpdk.org Cc: jianwang@trustnetic.com, luyicai@huawei.com, stable@dpdk.org References: <06a89892aa1b37996e5e629b3488c59d565393bd.1684393730.git.wangyunjian@huawei.com> <01e501d9895c$e242de90$a6c89bb0$@trustnetic.com> From: Ferruh Yigit In-Reply-To: <01e501d9895c$e242de90$a6c89bb0$@trustnetic.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0167.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:312::12) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SN7PR12MB6887:EE_ X-MS-Office365-Filtering-Correlation-Id: 65e646e4-cc11-46ea-dfd8-08db57c84fb1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BKUzbUYHJAaH0XSPD5m2zmQGRD0mVzFlIKpmFWhFRnFBc4h16BcNe7PDwj9cJimEzQ/wX+qFSq2ZzpU5qagtizbdlnpOPibSNGXfVyt9718YWls4aVNEgRCrOguqp9a9z60sHnjp0VTp+ZFaaxH76+yxs6TT4se+AXdehbkHgzhT4NX2+h+7habawHCQ3M0HCax+x7vEGP3sLyHk8a8Pl0WwBIIbhHxTmqIGfhstIinpj88Ch6v3wzf3D7tEXZtTdG6dhR6I6jQO6fg3EXzIHmd6ueoTGgdEyrFqmQUok0L3YC6HCUsOYTHCdmyDf6cBDhwgavwh0bdqi1aa5lIXX6G69OWhj8ucVeECtAnDXvH6W1KWVbe82i/u+W9X6M6n4khyOuZu2I9v7dGrUFoMkg0JUwb0/+JHPwJaWTBgDeZ7eN+uP6MVElzD+m5RItDF6Fw0J47kX9TM7EaG2k7z1xvEgjCqYojQ+agQP1at23EnHD00Z7Q8s3YWsqQPCaKM8kkoKnvATj45bWBIoPmCcLRCjVXRvRsGXrrRA5XTV2scVAkuL10sLBd7omRek18HEqeWEB4nTZ5HoKhUX5BtSJVTzigfPbHArH8T+nOZrclFNoqRBTDNAYmf5A16imVu4Bx3vIrYXMVD7eSPthN9fQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(346002)(396003)(376002)(366004)(39860400002)(136003)(451199021)(26005)(6512007)(6506007)(53546011)(83380400001)(2616005)(36756003)(31696002)(86362001)(186003)(38100700002)(110136005)(6486002)(44832011)(478600001)(316002)(2906002)(31686004)(4326008)(8676002)(8936002)(41300700001)(5660300002)(66476007)(66946007)(66556008)(6666004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T2R3bWhvTnlRQkxnR1ZwSG1TUVRYZnI5dDJPdFFJY0VjTnU3b1ZKVlFLVFor?= =?utf-8?B?QmU0bmVlTXNERGpEZTArOFl0VkJyZXFRWk9HQTN3RWRzd0t6Z1YwWG5TSy81?= =?utf-8?B?MlFTd25vdmVIZjF0S3pTdGt4SFVQZXJzVHp0S2tudWVQM2ZScmFSNjRBMUJZ?= =?utf-8?B?VHpDTW4vUVlDMDdtSEVubGVNSFRqM0FVaGZpSWJrVFFKZFB3MzRLMWIycnIw?= =?utf-8?B?UmFMK091dlF3VzlqWXlOVzlrWU44bDNWMDlld2dvN1ZWUi9qVlFXdnh5aWNR?= =?utf-8?B?UitaSjhueFdtcUo2Y0tZNklRK1Q1UWZNMUEyL0Z2Y0M5N2FKNFhWaXVncVVr?= =?utf-8?B?dUwxNkMxVVNxUzByZmtuMHhpY1gvZnZOMXFPNDdaeS8zdkEzWXl6SGJndW5W?= =?utf-8?B?bC9lL25seW9DOG0xRjZKbEdHNmtqVUE4dUVZK05rSGVXdHpNMHJNaE9LNFZX?= =?utf-8?B?UWJTZkMxWVBEamtVaER6RTJhc0xOTUZlSVZ3bGZUd3l2TUpWUDc5TmhzN0hs?= =?utf-8?B?eTR5VGN3cjdGTXpVWW1tTUxwMm1CQlpxbGZaak04MElSdmJyRFdFU2xoZUM4?= =?utf-8?B?dW1tNHZuNlQxeElsTGYvMVgwNFRqbHpST2MzWmcvVXJ0by9UOUJIVGlJWHFX?= =?utf-8?B?L01YTzd3Q2Y4VERmdlpmNzBpekJwVS9yV0g0L2k0U214QTF0ZVpEYkFqUFgv?= =?utf-8?B?eWRLclkwUU9iWURuR0xjTzJTTER2YWVoRzVUQ0NtS0gycCtKamg4VGZQNHRa?= =?utf-8?B?NVBsWllLenFSOFJRa1RUK0hGTzVsMWlMSVpUKzJ2bDhEQnZVaVhtWEhKTzgw?= =?utf-8?B?Vi9jRUYrSlpXR2h4TGtzcUVMc1lDa0VqR0V3ZnJJay9ZdHQrbUZ2dkhuM1BY?= =?utf-8?B?UGo3R0ZueEJnbXJFbVhwTGlka1owRGxLM0ZQbkpvTkVkNnpGT3dGZmlYd3cr?= =?utf-8?B?SUZGcWc0ZW00d25xZ3J4VkRnWTRTZXNCMFU2UDBoT0Z1ZDNramR2YmU2bmZ2?= =?utf-8?B?NUlRREg2cWRXenRKcjFqYXY0Tk1yZ0ZhSW5nTjdEZXhnZmEwT09BTW9EaVFI?= =?utf-8?B?MzhqWjAzSGVEeG84YlNNcm9mMFAwdnN4Um92TzZiaDZYK0pmclBlWHdzNjhx?= =?utf-8?B?TlpXUmFYTnN1cXBqL2RhczREZ2ZtOFM2UEtXdVVEUnBUSndTekhrd3ZuSkhs?= =?utf-8?B?dDg1aVlWTmhsL0FzcWlzMTJWTEJhTkI4UHJSaVBiNGJDTE9lNkY3SEhCWi9k?= =?utf-8?B?Sk5mUjBvbEM2RkMwbkhPTEZ2NnlRcWNUSVZxcCtKczNaWTBmVmhFVmY5dy82?= =?utf-8?B?SnREQ0tkM2pYOTIydUdIa0RuaVVCSE1SRUptOGoxTjAzMGthNFRxaHlHaXpP?= =?utf-8?B?S3NYNDl0NHhWU1BCYXRrUmxNN3djQ2xkRTFDTFlXV3hqbkovajg4eEJtZ2Iv?= =?utf-8?B?QkZNNktZSUNDOUk4S2VMTXN5MFFjSUU2QSttT1gzblF2VXZSa1U4Uk12OC96?= =?utf-8?B?ZEJuSGMrM0UxQmhIa2dqc1dxZU4zSWplM2VIdGVxcTVkTWE0S3VvQTYrM2gr?= =?utf-8?B?a3kyOExJdUQ2WXh0S3dXN2tsS2FCODc2L2o4a1dCc3U1eTI3bG9ZbkEyYzV0?= =?utf-8?B?ZkZtbk1zZDI1T2hKbWtHR0I4Q3lzeTBVbisyYWVyc1BvMVpveXVLQWY3MDVE?= =?utf-8?B?bWQwSittRXlkVGhyckcxMnhkYzF6azNodTNzVGJjRFhNSGtIMFo2OEF2M3Ix?= =?utf-8?B?RGoycVlhYUJNU3VZNjBxdFdyUDVKMWw5QW9KQ1JudmRoM3pUYnFwU0N1azJ6?= =?utf-8?B?VXZRZFB0ZTRJTUE2RFc2SnNlRXdlMXh2TW9YTkdKU1VueHk2YW0yQUQ2N3Yy?= =?utf-8?B?dU9UcmJNN2RsMlpyT1RId1ZRV3N2MWVpajBWVDBEL1l2TFFrczBpTUhIMHJ4?= =?utf-8?B?aU9STzZ4aWdQQXZjWDRrT0xIT2F5WXlLeDFPZWtJTDNnaFY2aHduUUN5N3Ay?= =?utf-8?B?bUtBMGpkTTFTZVMrcVEwampJQ05SN1NhNG1Fckp5RzZaK1pjaTM3YmZKQTZw?= =?utf-8?B?bXd3VFNudjhkd0tGY3V6SUl0SHhJdnlnMnFIZUVGQ1FIdE5vZHVXVmR5aCtO?= =?utf-8?Q?qSZKf/bn/k6hkUD6sn5gieq8e?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 65e646e4-cc11-46ea-dfd8-08db57c84fb1 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2023 17:50:04.7063 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ffNcG3NiqOiUat/zP/a0XtofL/SCsoV+kDvCmmJU6aD8PQNEHZHmU6KO36WW3mJc X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6887 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 5/18/2023 8:46 AM, Jiawen Wu wrote: >> When cleaning up NIC's interrupts, it is possible to add some alarms >> at the same time. However, if these alarms are not canceled, it may >> cause use-after-free problems. Therefore, after cleaning up NIC's >> interrupts, these alarms should also be canceled. >> >> Fixes: d3bb4a04eac1 ("net/txgbe: add SFP hotplug identification") >> Fixes: e0d876ef6bbc ("net/txgbe: support device stop and close") >> Cc: stable@dpdk.org >> >> Reported-by: Pengfei Sun >> Signed-off-by: Yunjian Wang >> --- >> drivers/net/txgbe/txgbe_ethdev.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c >> index a502618bc5..a3d7461951 100644 >> --- a/drivers/net/txgbe/txgbe_ethdev.c >> +++ b/drivers/net/txgbe/txgbe_ethdev.c >> @@ -2032,8 +2032,10 @@ txgbe_dev_close(struct rte_eth_dev *dev) >> rte_delay_ms(100); >> } while (retries++ < (10 + TXGBE_LINK_UP_TIME)); >> >> - /* cancel the delay handler before remove dev */ >> + /* cancel all alarm handler before remove dev */ >> rte_eal_alarm_cancel(txgbe_dev_interrupt_delayed_handler, dev); >> + rte_eal_alarm_cancel(txgbe_dev_detect_sfp, dev); >> + rte_eal_alarm_cancel(txgbe_dev_setup_link_alarm_handler, dev); >> >> /* uninitialize PF if max_vfs not zero */ >> txgbe_pf_host_uninit(dev); >> -- >> 2.33.0 >> >> > > Reviewed-by: Jiawen Wu > > Applied to dpdk-next-net/main, thanks.