patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [dpdk-dev] [PATCH] mk: disable OcteonTx for buggy compilers only on arm64
@ 2018-09-03  9:31 Jerin Jacob
  2018-09-03 13:32 ` Ferruh Yigit
  0 siblings, 1 reply; 3+ messages in thread
From: Jerin Jacob @ 2018-09-03  9:31 UTC (permalink / raw)
  To: dev
  Cc: ferruh.yigit, thomas, xuemingx.zhang, pbhagavatula, Jerin Jacob, stable

Disable octeontx for gcc 4.8.5 as the compiler is emitting "internal
compiler error" for aarch64. The GCC "internal compiler error" was
observed only for arm64 architecture so disable the PMD only
for arm64.

Cc: stable@dpdk.org
Fixes: 4f760550a093 ("mk: disable OcteonTx for buggy compilers")

Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
 mk/toolchain/gcc/rte.toolchain-compat.mk | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/mk/toolchain/gcc/rte.toolchain-compat.mk b/mk/toolchain/gcc/rte.toolchain-compat.mk
index 1e4434fa9..44904295c 100644
--- a/mk/toolchain/gcc/rte.toolchain-compat.mk
+++ b/mk/toolchain/gcc/rte.toolchain-compat.mk
@@ -79,11 +79,13 @@ else
 		CONFIG_RTE_LIBRTE_PMD_OPDL_EVENTDEV=d
 	endif
 
-	# Disable octeontx event PMD for gcc < 4.8.6
+	# Disable octeontx event PMD for gcc < 4.8.6 & ARCH=arm64
+	ifeq ($(CONFIG_RTE_ARCH), arm64)
 	ifeq ($(shell test $(GCC_VERSION)$(GCC_PATCHLEVEL) -lt 486 && echo 1), 1)
 		CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF=d
 		CONFIG_RTE_LIBRTE_OCTEONTX_MEMPOOL=d
 		CONFIG_RTE_LIBRTE_OCTEONTX_PMD=d
 	endif
+	endif
 
 endif
-- 
2.18.0

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] mk: disable OcteonTx for buggy compilers only on arm64
  2018-09-03  9:31 [dpdk-stable] [dpdk-dev] [PATCH] mk: disable OcteonTx for buggy compilers only on arm64 Jerin Jacob
@ 2018-09-03 13:32 ` Ferruh Yigit
  2018-09-16  8:04   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2018-09-03 13:32 UTC (permalink / raw)
  To: Jerin Jacob, dev; +Cc: thomas, xuemingx.zhang, pbhagavatula, stable

On 9/3/2018 10:31 AM, Jerin Jacob wrote:
> Disable octeontx for gcc 4.8.5 as the compiler is emitting "internal
> compiler error" for aarch64. The GCC "internal compiler error" was
> observed only for arm64 architecture so disable the PMD only
> for arm64.
> 
> Cc: stable@dpdk.org
> Fixes: 4f760550a093 ("mk: disable OcteonTx for buggy compilers")
> 
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] mk: disable OcteonTx for buggy compilers only on arm64
  2018-09-03 13:32 ` Ferruh Yigit
@ 2018-09-16  8:04   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2018-09-16  8:04 UTC (permalink / raw)
  To: Jerin Jacob; +Cc: stable, Ferruh Yigit, dev, xuemingx.zhang, pbhagavatula

03/09/2018 15:32, Ferruh Yigit:
> On 9/3/2018 10:31 AM, Jerin Jacob wrote:
> > Disable octeontx for gcc 4.8.5 as the compiler is emitting "internal
> > compiler error" for aarch64. The GCC "internal compiler error" was
> > observed only for arm64 architecture so disable the PMD only
> > for arm64.
> > 
> > Cc: stable@dpdk.org
> > Fixes: 4f760550a093 ("mk: disable OcteonTx for buggy compilers")
> > 
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-09-16  8:04 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-03  9:31 [dpdk-stable] [dpdk-dev] [PATCH] mk: disable OcteonTx for buggy compilers only on arm64 Jerin Jacob
2018-09-03 13:32 ` Ferruh Yigit
2018-09-16  8:04   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).