From: Thomas Monjalon <thomas@monjalon.net>
To: Lee Daly <lee.daly@intel.com>
Cc: dev@dpdk.org, "Hunt, David" <david.hunt@intel.com>,
liang.j.ma@intel.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] lib/librte_power: set new frequecy on turbo_disable
Date: Tue, 23 Apr 2019 00:12:42 +0200 [thread overview]
Message-ID: <2544567.6fWz8dBWoG@xps> (raw)
In-Reply-To: <0e4ce484-1ae1-e759-9e81-e6328e0911bc@intel.com>
15/04/2019 11:21, Hunt, David:
> On 12/4/2019 4:57 PM, Lee Daly wrote:
> > This patch will ensure the correct max frequency of a core is set in
> > the lcore_power_info struct when disabling turbo, while using the
> > intel pstate driver.
> >
> > Fixes: e6c6dc0f96c8 ("power: add p-state driver compatibility")
> > Cc: liang.j.ma@intel.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Lee Daly <lee.daly@intel.com>
> > ---
> > -
> > + if ((pi->turbo_available) && (pi->curr_idx <= 1)) {
> > + /* Try to set freq to max by default coming out of turbo */
> > + if (power_pstate_cpufreq_freq_max(lcore_id) < 0) {
> > + RTE_LOG(ERR, POWER,
> > + "Failed to set frequency of lcore %u to max\n",
> > + lcore_id);
> > + return -1;
> > + }
> > + }
> > return 0;
> > }
>
> Acked-by: David Hunt <david.hunt@intel.com>
Applied without extra parentheses and with blank line restored.
next prev parent reply other threads:[~2019-04-22 22:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 15:57 [dpdk-stable] " Lee Daly
2019-04-15 9:21 ` Hunt, David
2019-04-22 22:12 ` Thomas Monjalon [this message]
2019-04-15 16:11 ` Liang, Ma
2019-04-15 16:36 ` [dpdk-stable] [dpdk-dev] " Stephen Hemminger
2019-04-16 9:25 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2544567.6fWz8dBWoG@xps \
--to=thomas@monjalon.net \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=lee.daly@intel.com \
--cc=liang.j.ma@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).