Re: [dpdk-stable] [dpdk-dev] [PATCH] eal: initialize alarms early

[Thomas Monjalon <thomas@monjalon.net>]

26/03/2019 19:43, Darek Stojaczyk:
> We currently initialize rte_alarms after starting
> to listen for IPC hotplug requests, which gives
> us a data race window. Upon receiving such hotplug
> request we always try to set an alarm and this
> obviously doesn't work if the alarms weren't
> initialized yet.
> 
> To fix it, we initialize alarms before starting
> to listen for IPC hotplug messages. Specifically,
> we move rte_eal_alarm_init() right after
> rte_eal_intr_init() as it makes some sense to
> keep those two close to each other.

I wonder which regression it will bring :)
The experience shows that we cannot touch this function
without introducing a regression. Please check twice.

> Fixes: 244d5130719c ("eal: enable hotplug on multi-process")
> Cc: Qi Zhang <qi.z.zhang@intel.com>
> Cc: Anatoly Burakov <anatoly.burakov@intel.com>
> Cc: stable@dpdk.org
> 
> Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
> ---
>  lib/librte_eal/linux/eal/eal.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

You probably need to update the FreeBSD version too.