From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 07893A04B1 for ; Wed, 4 Nov 2020 11:54:05 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C3038C8D2; Wed, 4 Nov 2020 11:54:03 +0100 (CET) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by dpdk.org (Postfix) with ESMTP id 7C160C8D2 for ; Wed, 4 Nov 2020 11:54:01 +0100 (CET) Received: by mail-wm1-f68.google.com with SMTP id c18so1902127wme.2 for ; Wed, 04 Nov 2020 02:54:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=0izSpVIDj0PAvMHEaPjyBFjg1Q9RPvURI7svcRDYg8Q=; b=tGKHrymrpgkV5sBI8HKfxajVdGhkTOaC6hokhDyfa3GLtZBbPI0owAdMmYojDArnFj qPgB8N/YJnqo30liOR3+IlGVxQHy4MkyQ7uNdkAZvHkGLATkiJzCAB9XNn4UnBGzQ5cl 5l189WYsIyGR6W/sV/O/XalC1U6NOLJWInEikD2UrvGm+oWOWf3gQFzHGrL26l4hvft8 vy5tT0JjspRwXi6CAqlzR3TBElUs5hbyVtVq1DldPBoFMzT4CHSXIfV5XbklyQOoFbmu da6vJQ+smN4O2WrMYljxKqFtSUdMYx/Z8AEHoJsIIzYJw/54nFj+oLJr/L2QxJ0lCdfZ uXuw== X-Gm-Message-State: AOAM5318HcQ3BISl54uMCqHHiqw3YmJNNYcpIXBFFzrNKmtD1FW/cwZi nk9PoV4lAbfTQBvrKkXmHQE= X-Google-Smtp-Source: ABdhPJzLS2LombB57UCTHHmxSediDiYv8Lf6hZH7A/K5eg+2tjDaqtEfB1iKMHCCWw9oqzJTPnnODQ== X-Received: by 2002:a05:600c:2110:: with SMTP id u16mr3939841wml.4.1604487240197; Wed, 04 Nov 2020 02:54:00 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id z15sm2047297wrq.24.2020.11.04.02.53.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 02:53:59 -0800 (PST) Message-ID: <2549bb01ffdeb2a03c8f87afab2f7ac69f0437c9.camel@debian.org> From: Luca Boccassi To: oulijun , stable@dpdk.org Cc: linuxarm@huawei.com Date: Wed, 04 Nov 2020 10:53:58 +0000 In-Reply-To: References: <1604394260-9644-1-git-send-email-oulijun@huawei.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH 19.11.6] ethdev: fix data type in TC queues X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Wed, 2020-11-04 at 18:35 +0800, oulijun wrote: >=20 > =E5=9C=A8 2020/11/3 17:21, Luca Boccassi =E5=86=99=E9=81=93: > > On Tue, 2020-11-03 at 17:04 +0800, Lijun Ou wrote: > > > From: Huisong Li > > >=20 > > > [ upstream commit 9f6dc8592d54aa2ec1800c53977a31bd7922147b ] > > >=20 > > > Currently, base and nb_queue in the tc_rxq and tc_txq information > > > of queue and TC mapping on both TX and RX paths are uint8_t. > > > However, these data will be truncated when queue number under a TC > > > is greater than 256. So it is necessary for base and nb_queue to > > > change from uint8_t to uint16_t. > > >=20 > > > Fixes: 89d6728c7837 ("ethdev: get DCB information") > > > Cc: stable@dpdk.org > > >=20 > > > Signed-off-by: Huisong Li > > > Signed-off-by: Min Hu (Connor) > > > Reviewed-by: Wei Hu (Xavier) > > > Reviewed-by: Dongdong Liu > > > Acked-by: Thomas Monjalon > > > Reviewed-by: Ferruh Yigit > > > --- > > > doc/guides/rel_notes/release_19_11.rst | 5 +++++ > > > lib/librte_ethdev/rte_ethdev.h | 8 ++++---- > > > 2 files changed, 9 insertions(+), 4 deletions(-) > > >=20 > > > diff --git a/doc/guides/rel_notes/release_19_11.rst b/doc/guides/rel_= notes/release_19_11.rst > > > index acd18a3..cba8ebd 100644 > > > --- a/doc/guides/rel_notes/release_19_11.rst > > > +++ b/doc/guides/rel_notes/release_19_11.rst > > > @@ -457,6 +457,11 @@ API Changes > > > * ethdev: changed ``rte_eth_dev_owner_delete`` return value from ``= void`` to > > > ``int`` to provide a way to report various error conditions. > > > =20 > > > +* ethdev: Modified field type of ``base`` and ``nb_queue`` in struct > > > + ``rte_eth_dcb_tc_queue_mapping`` from ``uint8_t`` to ``uint16_t``. > > > + As the data of ``uint8_t`` will be truncated when queue number und= er > > > + a TC is greater than 256. > > > + > > > * ethdev: The deprecated function ``rte_eth_dev_count`` was removed= . > > > The function ``rte_eth_dev_count_avail`` is a drop-in replacement= . > > > If the intent is to iterate over ports, ``RTE_ETH_FOREACH_*`` mac= ros > > > diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_e= thdev.h > > > index 51f9f25..5fedff0 100644 > > > --- a/lib/librte_ethdev/rte_ethdev.h > > > +++ b/lib/librte_ethdev/rte_ethdev.h > > > @@ -1360,13 +1360,13 @@ struct rte_eth_xstat_name { > > > struct rte_eth_dcb_tc_queue_mapping { > > > /** rx queues assigned to tc per Pool */ > > > struct { > > > - uint8_t base; > > > - uint8_t nb_queue; > > > + uint16_t base; > > > + uint16_t nb_queue; > > > } tc_rxq[ETH_MAX_VMDQ_POOL][ETH_DCB_NUM_TCS]; > > > /** rx queues assigned to tc per Pool */ > > > struct { > > > - uint8_t base; > > > - uint8_t nb_queue; > > > + uint16_t base; > > > + uint16_t nb_queue; > > > } tc_txq[ETH_MAX_VMDQ_POOL][ETH_DCB_NUM_TCS]; > > > }; > >=20 > > Hi, > >=20 > > Thanks for the patch, but isn't this an ABI breakage? This is a public > > header right? > >=20 > I understand that an ABI breakage has been announced. Sure, that's fine for mainline 20.11 - but we never break ABI in LTS releases. Hence I will skip this patch for 19.11.6. --=20 Kind regards, Luca Boccassi