* [dpdk-stable] [PATCH] devtools: fix directory filter in forbidden token check
@ 2020-11-10 15:40 David Marchand
2020-11-12 18:43 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: David Marchand @ 2020-11-10 15:40 UTC (permalink / raw)
To: dev; +Cc: thomas, stable
checkpatches.sh current complains on a patch [1] adding
ALLOW_EXPERIMENTAL_API in an example while this check is for app, lib
and drivers directories:
Warning in examples/ethtool/ethtool-app/Makefile:
Using experimental build flag for in-tree compilation
The regexp on entering files concerned by this filter is incorrect.
In the [1] case, the file full name is matched against "app" rather than
"+++ b/app".
1: https://patchwork.dpdk.org/patch/83902/
Fixes: 7413e7f2aeb3 ("devtools: alert on new calls to exit from libs")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
devtools/check-forbidden-tokens.awk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/devtools/check-forbidden-tokens.awk b/devtools/check-forbidden-tokens.awk
index f86cbe8dc1..61ba707c9b 100755
--- a/devtools/check-forbidden-tokens.awk
+++ b/devtools/check-forbidden-tokens.awk
@@ -54,7 +54,7 @@ BEGIN {
}
for (i in deny_folders) {
re = "^\\+\\+\\+ b/" deny_folders[i];
- if ($0 ~ deny_folders[i]) {
+ if ($0 ~ re) {
in_file = 1
last_file = $0
}
--
2.23.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [dpdk-stable] [PATCH] devtools: fix directory filter in forbidden token check
2020-11-10 15:40 [dpdk-stable] [PATCH] devtools: fix directory filter in forbidden token check David Marchand
@ 2020-11-12 18:43 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2020-11-12 18:43 UTC (permalink / raw)
To: David Marchand; +Cc: dev, stable
10/11/2020 16:40, David Marchand:
> checkpatches.sh current complains on a patch [1] adding
> ALLOW_EXPERIMENTAL_API in an example while this check is for app, lib
> and drivers directories:
>
> Warning in examples/ethtool/ethtool-app/Makefile:
> Using experimental build flag for in-tree compilation
>
> The regexp on entering files concerned by this filter is incorrect.
> In the [1] case, the file full name is matched against "app" rather than
> "+++ b/app".
>
> 1: https://patchwork.dpdk.org/patch/83902/
>
> Fixes: 7413e7f2aeb3 ("devtools: alert on new calls to exit from libs")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-12 18:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-10 15:40 [dpdk-stable] [PATCH] devtools: fix directory filter in forbidden token check David Marchand
2020-11-12 18:43 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).