* Re: [dpdk-stable] [PATCH v2] service: don't walk out of bounds when checking services [not found] ` <CAJFAV8xPOE+krsS-ONeyg61tc8J49Ln3N5CVP4qY3J_SB9jXQg@mail.gmail.com> @ 2019-12-04 8:34 ` David Marchand 2019-12-20 14:43 ` David Marchand 0 siblings, 1 reply; 5+ messages in thread From: David Marchand @ 2019-12-04 8:34 UTC (permalink / raw) To: Aaron Conole Cc: dev, Harry van Haaren, Bruce Richardson, Pavan Nikhilesh, Gage Eads, Thomas Monjalon, dpdk stable On Wed, Dec 4, 2019 at 9:33 AM David Marchand <david.marchand@redhat.com> wrote: > > On Tue, Dec 3, 2019 at 10:15 PM Aaron Conole <aconole@redhat.com> wrote: > > > > The service_valid call is used without properly bounds checking the > > input parameter. Almost all instances of the service_valid call are > > inside a for() loop that prevents excessive walks, but some of the > > public APIs don't bounds check and will pass invalid arguments. > > > > Prevent this by using SERVICE_GET_OR_ERR_RET where it makes sense, > > and adding a bounds check to one service_valid() use. > > > > Fixes: 8d39d3e237c2 ("service: fix race in service on app lcore function") > > Fixes: e9139a32f6e8 ("service: add function to run on app lcore") > > Fixes: e30dd31847d2 ("service: add mechanism for quiescing") Cc: stable@dpdk.org > > Signed-off-by: Aaron Conole <aconole@redhat.com> > > Reviewed-by: David Marchand <david.marchand@redhat.com> -- David Marchand ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-stable] [PATCH v2] service: don't walk out of bounds when checking services 2019-12-04 8:34 ` [dpdk-stable] [PATCH v2] service: don't walk out of bounds when checking services David Marchand @ 2019-12-20 14:43 ` David Marchand 2020-02-07 12:04 ` [dpdk-stable] [dpdk-dev] " Kevin Traynor 0 siblings, 1 reply; 5+ messages in thread From: David Marchand @ 2019-12-20 14:43 UTC (permalink / raw) To: Aaron Conole Cc: dev, Harry van Haaren, Bruce Richardson, Pavan Nikhilesh, Gage Eads, Thomas Monjalon, dpdk stable On Wed, Dec 4, 2019 at 9:34 AM David Marchand <david.marchand@redhat.com> wrote: > > On Wed, Dec 4, 2019 at 9:33 AM David Marchand <david.marchand@redhat.com> wrote: > > > > On Tue, Dec 3, 2019 at 10:15 PM Aaron Conole <aconole@redhat.com> wrote: > > > > > > The service_valid call is used without properly bounds checking the > > > input parameter. Almost all instances of the service_valid call are > > > inside a for() loop that prevents excessive walks, but some of the > > > public APIs don't bounds check and will pass invalid arguments. > > > > > > Prevent this by using SERVICE_GET_OR_ERR_RET where it makes sense, > > > and adding a bounds check to one service_valid() use. > > > > > > Fixes: 8d39d3e237c2 ("service: fix race in service on app lcore function") > > > Fixes: e9139a32f6e8 ("service: add function to run on app lcore") > > > Fixes: e30dd31847d2 ("service: add mechanism for quiescing") > Cc: stable@dpdk.org > > > > Signed-off-by: Aaron Conole <aconole@redhat.com> > > > > Reviewed-by: David Marchand <david.marchand@redhat.com> Applied, thanks. -- David Marchand ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v2] service: don't walk out of bounds when checking services 2019-12-20 14:43 ` David Marchand @ 2020-02-07 12:04 ` Kevin Traynor 2020-02-07 14:27 ` Aaron Conole 0 siblings, 1 reply; 5+ messages in thread From: Kevin Traynor @ 2020-02-07 12:04 UTC (permalink / raw) To: Aaron Conole, Harry van Haaren, nikhil.rao Cc: David Marchand, dev, Bruce Richardson, Pavan Nikhilesh, Gage Eads, Thomas Monjalon, dpdk stable On 20/12/2019 14:43, David Marchand wrote: > On Wed, Dec 4, 2019 at 9:34 AM David Marchand <david.marchand@redhat.com> wrote: >> >> On Wed, Dec 4, 2019 at 9:33 AM David Marchand <david.marchand@redhat.com> wrote: >>> >>> On Tue, Dec 3, 2019 at 10:15 PM Aaron Conole <aconole@redhat.com> wrote: >>>> >>>> The service_valid call is used without properly bounds checking the >>>> input parameter. Almost all instances of the service_valid call are >>>> inside a for() loop that prevents excessive walks, but some of the >>>> public APIs don't bounds check and will pass invalid arguments. >>>> >>>> Prevent this by using SERVICE_GET_OR_ERR_RET where it makes sense, >>>> and adding a bounds check to one service_valid() use. >>>> >>>> Fixes: 8d39d3e237c2 ("service: fix race in service on app lcore function") >>>> Fixes: e9139a32f6e8 ("service: add function to run on app lcore") >>>> Fixes: e30dd31847d2 ("service: add mechanism for quiescing") >> Cc: stable@dpdk.org >> With the commit below, this patch will apply cleanly on 18.11. Seems ok to me to add below commit, wdyt? commit e484ccddbe1b41886fef1e445ef2fdfa55086198 Author: Nikhil Rao <nikhil.rao@intel.com> Date: Mon Sep 16 15:31:02 2019 +0530 service: avoid false sharing on core state >>>> Signed-off-by: Aaron Conole <aconole@redhat.com> >>> >>> Reviewed-by: David Marchand <david.marchand@redhat.com> > > Applied, thanks. > > > -- > David Marchand > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v2] service: don't walk out of bounds when checking services 2020-02-07 12:04 ` [dpdk-stable] [dpdk-dev] " Kevin Traynor @ 2020-02-07 14:27 ` Aaron Conole 2020-02-14 16:38 ` Kevin Traynor 0 siblings, 1 reply; 5+ messages in thread From: Aaron Conole @ 2020-02-07 14:27 UTC (permalink / raw) To: Kevin Traynor Cc: Harry van Haaren, nikhil.rao, David Marchand, dev, Bruce Richardson, Pavan Nikhilesh, Gage Eads, Thomas Monjalon, dpdk stable Kevin Traynor <ktraynor@redhat.com> writes: > On 20/12/2019 14:43, David Marchand wrote: >> On Wed, Dec 4, 2019 at 9:34 AM David Marchand <david.marchand@redhat.com> wrote: >>> >>> On Wed, Dec 4, 2019 at 9:33 AM David Marchand <david.marchand@redhat.com> wrote: >>>> >>>> On Tue, Dec 3, 2019 at 10:15 PM Aaron Conole <aconole@redhat.com> wrote: >>>>> >>>>> The service_valid call is used without properly bounds checking the >>>>> input parameter. Almost all instances of the service_valid call are >>>>> inside a for() loop that prevents excessive walks, but some of the >>>>> public APIs don't bounds check and will pass invalid arguments. >>>>> >>>>> Prevent this by using SERVICE_GET_OR_ERR_RET where it makes sense, >>>>> and adding a bounds check to one service_valid() use. >>>>> >>>>> Fixes: 8d39d3e237c2 ("service: fix race in service on app lcore function") >>>>> Fixes: e9139a32f6e8 ("service: add function to run on app lcore") >>>>> Fixes: e30dd31847d2 ("service: add mechanism for quiescing") >>> Cc: stable@dpdk.org >>> > > With the commit below, this patch will apply cleanly on 18.11. > > Seems ok to me to add below commit, wdyt? If I'm reading it correctly, the move is for an internal data structure in librte_eal, so I think it shouldn't be an ABI breakage. Looks safe to me as well. > commit e484ccddbe1b41886fef1e445ef2fdfa55086198 > Author: Nikhil Rao <nikhil.rao@intel.com> > Date: Mon Sep 16 15:31:02 2019 +0530 > > service: avoid false sharing on core state > > >>>>> Signed-off-by: Aaron Conole <aconole@redhat.com> >>>> >>>> Reviewed-by: David Marchand <david.marchand@redhat.com> >> >> Applied, thanks. >> >> >> -- >> David Marchand >> ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v2] service: don't walk out of bounds when checking services 2020-02-07 14:27 ` Aaron Conole @ 2020-02-14 16:38 ` Kevin Traynor 0 siblings, 0 replies; 5+ messages in thread From: Kevin Traynor @ 2020-02-14 16:38 UTC (permalink / raw) To: Aaron Conole Cc: Harry van Haaren, nikhil.rao, David Marchand, dev, Bruce Richardson, Pavan Nikhilesh, Gage Eads, Thomas Monjalon, dpdk stable On 07/02/2020 14:27, Aaron Conole wrote: > Kevin Traynor <ktraynor@redhat.com> writes: > >> On 20/12/2019 14:43, David Marchand wrote: >>> On Wed, Dec 4, 2019 at 9:34 AM David Marchand <david.marchand@redhat.com> wrote: >>>> >>>> On Wed, Dec 4, 2019 at 9:33 AM David Marchand <david.marchand@redhat.com> wrote: >>>>> >>>>> On Tue, Dec 3, 2019 at 10:15 PM Aaron Conole <aconole@redhat.com> wrote: >>>>>> >>>>>> The service_valid call is used without properly bounds checking the >>>>>> input parameter. Almost all instances of the service_valid call are >>>>>> inside a for() loop that prevents excessive walks, but some of the >>>>>> public APIs don't bounds check and will pass invalid arguments. >>>>>> >>>>>> Prevent this by using SERVICE_GET_OR_ERR_RET where it makes sense, >>>>>> and adding a bounds check to one service_valid() use. >>>>>> >>>>>> Fixes: 8d39d3e237c2 ("service: fix race in service on app lcore function") >>>>>> Fixes: e9139a32f6e8 ("service: add function to run on app lcore") >>>>>> Fixes: e30dd31847d2 ("service: add mechanism for quiescing") >>>> Cc: stable@dpdk.org >>>> >> >> With the commit below, this patch will apply cleanly on 18.11. >> >> Seems ok to me to add below commit, wdyt? > > If I'm reading it correctly, the move is for an internal data structure > in librte_eal, so I think it shouldn't be an ABI breakage. > > Looks safe to me as well. > Thanks, both patches applied. >> commit e484ccddbe1b41886fef1e445ef2fdfa55086198 >> Author: Nikhil Rao <nikhil.rao@intel.com> >> Date: Mon Sep 16 15:31:02 2019 +0530 >> >> service: avoid false sharing on core state >> >> >>>>>> Signed-off-by: Aaron Conole <aconole@redhat.com> >>>>> >>>>> Reviewed-by: David Marchand <david.marchand@redhat.com> >>> >>> Applied, thanks. >>> >>> >>> -- >>> David Marchand >>> ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-02-14 16:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20191126145606.13626-1-aconole@redhat.com>
[not found] ` <20191203211544.20285-1-aconole@redhat.com>
[not found] ` <CAJFAV8xPOE+krsS-ONeyg61tc8J49Ln3N5CVP4qY3J_SB9jXQg@mail.gmail.com>
2019-12-04 8:34 ` [dpdk-stable] [PATCH v2] service: don't walk out of bounds when checking services David Marchand
2019-12-20 14:43 ` David Marchand
2020-02-07 12:04 ` [dpdk-stable] [dpdk-dev] " Kevin Traynor
2020-02-07 14:27 ` Aaron Conole
2020-02-14 16:38 ` Kevin Traynor
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).