From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 027ECA046B for ; Mon, 24 Jun 2019 13:35:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CDD8F1BF20; Mon, 24 Jun 2019 13:35:23 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id C27291BEFC; Mon, 24 Jun 2019 13:35:19 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jun 2019 04:35:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,412,1557212400"; d="scan'208";a="163298534" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by fmsmga007.fm.intel.com with ESMTP; 24 Jun 2019 04:35:17 -0700 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.143]) by IRSMSX107.ger.corp.intel.com ([169.254.10.205]) with mapi id 14.03.0439.000; Mon, 24 Jun 2019 12:35:17 +0100 From: "Ananyev, Konstantin" To: Ivan Malov , Olivier Matz CC: "dev@dpdk.org" , "Kulasek, TomaszX" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net: fix encapsulation markers for inner L3 offset Thread-Index: AQHVEkESl9WBalmQ4ECtuJty5d/0l6aq3Peg Date: Mon, 24 Jun 2019 11:35:16 +0000 Message-ID: <2601191342CEEE43887BDE71AB97725801689E3F0D@IRSMSX104.ger.corp.intel.com> References: <20190524145714.18903-1-ivan.malov@oktetlabs.ru> In-Reply-To: <20190524145714.18903-1-ivan.malov@oktetlabs.ru> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmY2ODFkODMtZDZiYS00NTJkLWE3ZDYtNDk0M2Q2NmMwYTk5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRWlBRGt3OGNjdGt0UVEwRTBOaTB4UnFrSHlcL040SGs3SW92SnRNZ2lkNEVZd3MyTHhJUE14Sk03NWI3SFpPa0kifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net: fix encapsulation markers for inner L3 offset X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ivan Malov > Sent: Friday, May 24, 2019 3:57 PM > To: Olivier Matz > Cc: dev@dpdk.org; Kulasek, TomaszX ; stable@dp= dk.org > Subject: [dpdk-dev] [PATCH] net: fix encapsulation markers for inner L3 o= ffset >=20 > The API to prepare checksum offloads employs outer > IP checksum flag to tell regular IPv4 packets from > tunnel packets with outer IPv4 encapsulation. This > flag cannot serve as a marker for the said purpose > because a packet can have outer IPv4 encapsulation > and may not have outer IP checksum offload request. >=20 > Fix the API by changing the said criterion to test > outer IPv4 flag rather than outer IP checksum flag. > Use simpler spelling of the conditional expression. >=20 > Fixes: 4fb7e803eb1a ("ethdev: add Tx preparation") > Cc: Tomasz Kulasek > Cc: stable@dpdk.org >=20 > Signed-off-by: Ivan Malov > Reviewed-by: Andrew Rybchenko > --- > lib/librte_net/rte_net.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/lib/librte_net/rte_net.h b/lib/librte_net/rte_net.h > index 1697071..c15b518 100644 > --- a/lib/librte_net/rte_net.h > +++ b/lib/librte_net/rte_net.h > @@ -128,8 +128,7 @@ uint32_t rte_net_get_ptype(const struct rte_mbuf *m, > return 0; > #endif >=20 > - if ((ol_flags & PKT_TX_OUTER_IP_CKSUM) || > - (ol_flags & PKT_TX_OUTER_IPV6)) > + if (ol_flags & (PKT_TX_OUTER_IPV4 | PKT_TX_OUTER_IPV6)) > inner_l3_offset +=3D m->outer_l2_len + m->outer_l3_len; >=20 > #ifdef RTE_LIBRTE_ETHDEV_DEBUG > -- Acked-by: Konstantin Ananyev > 1.8.3.1