* [dpdk-stable] [PATCH] acl: fix unchecked return value
@ 2017-09-20 10:01 Kuba Kozak
2017-10-02 14:13 ` [dpdk-stable] [dpdk-dev] " Jastrzebski, MichalX K
2017-10-02 14:21 ` [dpdk-stable] " Ananyev, Konstantin
0 siblings, 2 replies; 4+ messages in thread
From: Kuba Kozak @ 2017-09-20 10:01 UTC (permalink / raw)
To: konstantin.ananyev; +Cc: dev, Kuba Kozak, stable
Add return value check and error handling for fseek call.
Coverity issue: 143435
Fixes: 361b2e9559fc ("acl: new sample l3fwd-acl")
Cc: konstantin.ananyev@intel.com
Cc: stable@dpdk.org
Signed-off-by: Kuba Kozak <kubax.kozak@intel.com>
---
examples/l3fwd-acl/main.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/examples/l3fwd-acl/main.c b/examples/l3fwd-acl/main.c
index 8eff4de..708e9eb 100644
--- a/examples/l3fwd-acl/main.c
+++ b/examples/l3fwd-acl/main.c
@@ -1026,6 +1026,7 @@ add_rules(const char *rule_path,
char buff[LINE_MAX];
FILE *fh = fopen(rule_path, "rb");
unsigned int i = 0;
+ int val;
if (fh == NULL)
rte_exit(EXIT_FAILURE, "%s: Open %s failed\n", __func__,
@@ -1042,7 +1043,11 @@ add_rules(const char *rule_path,
rte_exit(EXIT_FAILURE, "Not find any route entries in %s!\n",
rule_path);
- fseek(fh, 0, SEEK_SET);
+ val = fseek(fh, 0, SEEK_SET);
+ if (val < 0) {
+ rte_exit(EXIT_FAILURE, "%s: File seek operation failed\n",
+ __func__);
+ }
acl_rules = calloc(acl_num, rule_size);
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-stable] [dpdk-dev] [PATCH] acl: fix unchecked return value
2017-09-20 10:01 [dpdk-stable] [PATCH] acl: fix unchecked return value Kuba Kozak
@ 2017-10-02 14:13 ` Jastrzebski, MichalX K
2017-10-02 14:21 ` [dpdk-stable] " Ananyev, Konstantin
1 sibling, 0 replies; 4+ messages in thread
From: Jastrzebski, MichalX K @ 2017-10-02 14:13 UTC (permalink / raw)
To: Kozak, KubaX, Ananyev, Konstantin
Cc: dev, Kozak, KubaX, stable, Jain, Deepak K
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Kuba Kozak
> Sent: Wednesday, September 20, 2017 12:02 PM
> To: Ananyev, Konstantin <konstantin.ananyev@intel.com>
> Cc: dev@dpdk.org; Kozak, KubaX <kubax.kozak@intel.com>;
> stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] acl: fix unchecked return value
>
> Add return value check and error handling for fseek call.
>
> Coverity issue: 143435
> Fixes: 361b2e9559fc ("acl: new sample l3fwd-acl")
> Cc: konstantin.ananyev@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Kuba Kozak <kubax.kozak@intel.com>
> ---
> examples/l3fwd-acl/main.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/examples/l3fwd-acl/main.c b/examples/l3fwd-acl/main.c
> index 8eff4de..708e9eb 100644
> --- a/examples/l3fwd-acl/main.c
> +++ b/examples/l3fwd-acl/main.c
> @@ -1026,6 +1026,7 @@ add_rules(const char *rule_path,
> char buff[LINE_MAX];
> FILE *fh = fopen(rule_path, "rb");
> unsigned int i = 0;
> + int val;
>
> if (fh == NULL)
> rte_exit(EXIT_FAILURE, "%s: Open %s failed\n", __func__,
> @@ -1042,7 +1043,11 @@ add_rules(const char *rule_path,
> rte_exit(EXIT_FAILURE, "Not find any route entries in %s!\n",
> rule_path);
>
> - fseek(fh, 0, SEEK_SET);
> + val = fseek(fh, 0, SEEK_SET);
> + if (val < 0) {
> + rte_exit(EXIT_FAILURE, "%s: File seek operation failed\n",
> + __func__);
> + }
>
> acl_rules = calloc(acl_num, rule_size);
>
> --
> 2.7.4
Hi Konstantin,
I would like to ask for a feedback regarding proposed fix.
If everything is ok with it, please send acked-by.
Best regards Michal.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-stable] [PATCH] acl: fix unchecked return value
2017-09-20 10:01 [dpdk-stable] [PATCH] acl: fix unchecked return value Kuba Kozak
2017-10-02 14:13 ` [dpdk-stable] [dpdk-dev] " Jastrzebski, MichalX K
@ 2017-10-02 14:21 ` Ananyev, Konstantin
2017-10-03 11:39 ` Kozak, KubaX
1 sibling, 1 reply; 4+ messages in thread
From: Ananyev, Konstantin @ 2017-10-02 14:21 UTC (permalink / raw)
To: Kozak, KubaX; +Cc: dev, stable
> -----Original Message-----
> From: Kozak, KubaX
> Sent: Wednesday, September 20, 2017 11:02 AM
> To: Ananyev, Konstantin <konstantin.ananyev@intel.com>
> Cc: dev@dpdk.org; Kozak, KubaX <kubax.kozak@intel.com>; stable@dpdk.org
> Subject: [PATCH] acl: fix unchecked return value
>
> Add return value check and error handling for fseek call.
>
> Coverity issue: 143435
> Fixes: 361b2e9559fc ("acl: new sample l3fwd-acl")
> Cc: konstantin.ananyev@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Kuba Kozak <kubax.kozak@intel.com>
> ---
> examples/l3fwd-acl/main.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/examples/l3fwd-acl/main.c b/examples/l3fwd-acl/main.c
> index 8eff4de..708e9eb 100644
> --- a/examples/l3fwd-acl/main.c
> +++ b/examples/l3fwd-acl/main.c
> @@ -1026,6 +1026,7 @@ add_rules(const char *rule_path,
> char buff[LINE_MAX];
> FILE *fh = fopen(rule_path, "rb");
> unsigned int i = 0;
> + int val;
>
> if (fh == NULL)
> rte_exit(EXIT_FAILURE, "%s: Open %s failed\n", __func__,
> @@ -1042,7 +1043,11 @@ add_rules(const char *rule_path,
> rte_exit(EXIT_FAILURE, "Not find any route entries in %s!\n",
> rule_path);
>
> - fseek(fh, 0, SEEK_SET);
> + val = fseek(fh, 0, SEEK_SET);
> + if (val < 0) {
> + rte_exit(EXIT_FAILURE, "%s: File seek operation failed\n",
> + __func__);
> + }
>
> acl_rules = calloc(acl_num, rule_size);
>
> --
> 2.7.4
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
BTW, I think it should be l3fwd-acl inside the subject line.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-stable] [PATCH] acl: fix unchecked return value
2017-10-02 14:21 ` [dpdk-stable] " Ananyev, Konstantin
@ 2017-10-03 11:39 ` Kozak, KubaX
0 siblings, 0 replies; 4+ messages in thread
From: Kozak, KubaX @ 2017-10-03 11:39 UTC (permalink / raw)
To: Ananyev, Konstantin; +Cc: dev, stable
Thanks Konstantin,
I'll fix subject name and resend patch to dpdk witch Your ACK.
>-----Original Message-----
>From: Ananyev, Konstantin
>Sent: Monday, October 2, 2017 16:22
>To: Kozak, KubaX <kubax.kozak@intel.com>
>Cc: dev@dpdk.org; stable@dpdk.org
>Subject: RE: [PATCH] acl: fix unchecked return value
>
>
>
>> -----Original Message-----
>> From: Kozak, KubaX
>> Sent: Wednesday, September 20, 2017 11:02 AM
>> To: Ananyev, Konstantin <konstantin.ananyev@intel.com>
>> Cc: dev@dpdk.org; Kozak, KubaX <kubax.kozak@intel.com>;
>> stable@dpdk.org
>> Subject: [PATCH] acl: fix unchecked return value
>>
>> Add return value check and error handling for fseek call.
>>
>> Coverity issue: 143435
>> Fixes: 361b2e9559fc ("acl: new sample l3fwd-acl")
>> Cc: konstantin.ananyev@intel.com
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Kuba Kozak <kubax.kozak@intel.com>
>> ---
>> examples/l3fwd-acl/main.c | 7 ++++++-
>> 1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/examples/l3fwd-acl/main.c b/examples/l3fwd-acl/main.c
>> index 8eff4de..708e9eb 100644
>> --- a/examples/l3fwd-acl/main.c
>> +++ b/examples/l3fwd-acl/main.c
>> @@ -1026,6 +1026,7 @@ add_rules(const char *rule_path,
>> char buff[LINE_MAX];
>> FILE *fh = fopen(rule_path, "rb");
>> unsigned int i = 0;
>> + int val;
>>
>> if (fh == NULL)
>> rte_exit(EXIT_FAILURE, "%s: Open %s failed\n", __func__, @@ -1042,7
>> +1043,11 @@ add_rules(const char *rule_path,
>> rte_exit(EXIT_FAILURE, "Not find any route entries in %s!\n",
>> rule_path);
>>
>> - fseek(fh, 0, SEEK_SET);
>> + val = fseek(fh, 0, SEEK_SET);
>> + if (val < 0) {
>> + rte_exit(EXIT_FAILURE, "%s: File seek operation failed\n",
>> + __func__);
>> + }
>>
>> acl_rules = calloc(acl_num, rule_size);
>>
>> --
>> 2.7.4
>
>Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
>
>BTW, I think it should be l3fwd-acl inside the subject line.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-10-03 11:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-20 10:01 [dpdk-stable] [PATCH] acl: fix unchecked return value Kuba Kozak
2017-10-02 14:13 ` [dpdk-stable] [dpdk-dev] " Jastrzebski, MichalX K
2017-10-02 14:21 ` [dpdk-stable] " Ananyev, Konstantin
2017-10-03 11:39 ` Kozak, KubaX
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).