[dpdk-stable] missing ring memory barrier in 17.11

[dpdk-stable] missing ring memory barrier in 17.11

[Thomas Monjalon]

Hi Luca, Gavin,

It seems the fix 85cffb2eccd9 ("ring: enforce reading tail before slots")
should be backported in 17.11.

This patch is missing because the root cause is wrongly identified.
It is referenced as
	Fixes: c9fb3c62896f ("ring: move code in a new header file")
in 18.02, but in reality it is from 17.05:
	Fixes: 0dfc98c507b1 ("ring: separate out head index manipulation")

Do you agree?

Re: [dpdk-stable] missing ring memory barrier in 17.11

[Luca Boccassi]

On Tue, 2019-10-01 at 09:41 +0200, Thomas Monjalon wrote:
> Hi Luca, Gavin,
> 
> It seems the fix 85cffb2eccd9 ("ring: enforce reading tail before
> slots")
> should be backported in 17.11.
> 
> This patch is missing because the root cause is wrongly identified.
> It is referenced as
> 	Fixes: c9fb3c62896f ("ring: move code in a new header file")
> in 18.02, but in reality it is from 17.05:
> 	Fixes: 0dfc98c507b1 ("ring: separate out head index
> manipulation")
> 
> Do you agree?

Hi,

Makes sense to me, and it applies cleanly (after accounting for the
source file name change). I'll queue it up for 17.11.8.

-- 
Kind regards,
Luca Boccassi

Re: [dpdk-stable] missing ring memory barrier in 17.11

[Honnappa Nagarahalli]

China team is on holiday. Yes, we should apply this patch to 17.11

> -----Original Message-----
> From: Luca Boccassi <bluca@debian.org>
> Sent: Tuesday, October 1, 2019 3:48 AM
> To: thomas@monjalon.net; Gavin Hu (Arm Technology China)
> <Gavin.Hu@arm.com>
> Cc: stable@dpdk.org; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; Nipun.gupta@nxp.com; Konstantin
> Ananyev <konstantin.ananyev@intel.com>
> Subject: Re: missing ring memory barrier in 17.11
> 
> On Tue, 2019-10-01 at 09:41 +0200, Thomas Monjalon wrote:
> > Hi Luca, Gavin,
> >
> > It seems the fix 85cffb2eccd9 ("ring: enforce reading tail before
> > slots")
> > should be backported in 17.11.
> >
> > This patch is missing because the root cause is wrongly identified.
> > It is referenced as
> > 	Fixes: c9fb3c62896f ("ring: move code in a new header file") in
> > 18.02, but in reality it is from 17.05:
> > 	Fixes: 0dfc98c507b1 ("ring: separate out head index
> > manipulation")
> >
> > Do you agree?
> 
> Hi,
> 
> Makes sense to me, and it applies cleanly (after accounting for the source file
> name change). I'll queue it up for 17.11.8.
> 
> --
> Kind regards,
> Luca Boccassi

Re: [dpdk-stable] missing ring memory barrier in 17.11

[Gavin Hu (Arm Technology China)]

Hi Thomas, Luca,

Thanks for reminding and sorry for late response(due to long holiday).

I have ported the patch and already sent to the stable mailing list, please help check and merge, thanks!

Best Regards,
Gavin

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Tuesday, October 1, 2019 3:42 PM
> To: bluca@debian.org; Gavin Hu (Arm Technology China)
> <Gavin.Hu@arm.com>
> Cc: stable@dpdk.org; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; Nipun.gupta@nxp.com; Konstantin
> Ananyev <konstantin.ananyev@intel.com>
> Subject: missing ring memory barrier in 17.11
>
> Hi Luca, Gavin,
>
> It seems the fix 85cffb2eccd9 ("ring: enforce reading tail before slots")
> should be backported in 17.11.
>
> This patch is missing because the root cause is wrongly identified.
> It is referenced as
>       Fixes: c9fb3c62896f ("ring: move code in a new header file")
> in 18.02, but in reality it is from 17.05:
>       Fixes: 0dfc98c507b1 ("ring: separate out head index manipulation")
>
> Do you agree?
>

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.