From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, stable@dpdk.org, ferruh.yigit@amd.com,
aman.deep.singh@intel.com, Yuying Zhang <yuying.zhang@intel.com>
Subject: Re: [PATCH v11 0/3] Fix cmdline_poll and testpmd signal handling
Date: Sat, 11 Mar 2023 11:17:05 +0100 [thread overview]
Message-ID: <2636586.KRxA6XjA2N@thomas> (raw)
In-Reply-To: <20230219095348.5f496a67@hermes.local>
19/02/2023 18:53, Stephen Hemminger:
> On Fri, 3 Feb 2023 11:14:06 -0800
> Stephen Hemminger <stephen@networkplumber.org> wrote:
>
> > This patchset keeps uncovering bad practices in the cmdline library
> > around end of file and signal handling.
> >
> > Stephen Hemminger (3):
> > cmdline: make rdline status not private
> > cmdline: handle EOF in cmdline_poll
> > testpmd: cleanup cleanly from signal
> >
> > app/test-pmd/cmdline.c | 29 +++++--------
> > app/test-pmd/testpmd.c | 77 ++++++++++++++++-------------------
> > app/test-pmd/testpmd.h | 1 +
> > lib/cmdline/cmdline.c | 11 +++--
> > lib/cmdline/cmdline.h | 6 +++
> > lib/cmdline/cmdline_private.h | 6 ---
> > 6 files changed, 62 insertions(+), 68 deletions(-)
> >
>
> Could this please be merged for 23.03?
> There are Ack's.
> The only CI failure is a bogus performance test failure.
There was no review from testpmd maintainers.
I've added Cc: stable@dpdk.org.
Applied, thanks.
next prev parent reply other threads:[~2023-03-11 10:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230130200914.22049-1-stephen@networkplumber.org>
2023-02-03 19:14 ` Stephen Hemminger
2023-02-03 19:14 ` [PATCH v11 1/3] cmdline: make rdline status not private Stephen Hemminger
2023-02-06 2:31 ` fengchengwen
2023-02-03 19:14 ` [PATCH v11 2/3] cmdline: handle EOF in cmdline_poll Stephen Hemminger
2023-02-03 19:14 ` [PATCH v11 3/3] testpmd: cleanup cleanly from signal Stephen Hemminger
2023-02-07 14:49 ` Ferruh Yigit
2023-02-07 14:48 ` [PATCH v11 0/3] Fix cmdline_poll and testpmd signal handling Ferruh Yigit
2023-02-19 17:53 ` Stephen Hemminger
2023-03-11 10:17 ` Thomas Monjalon [this message]
2023-03-12 17:18 ` Tal Shnaiderman
2023-03-13 10:34 ` Ling, WeiX
2023-03-13 15:53 ` Stephen Hemminger
2023-03-14 7:05 ` Ling, WeiX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2636586.KRxA6XjA2N@thomas \
--to=thomas@monjalon.net \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).