From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <stable-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 69ED5427F7 for <public@inbox.dpdk.org>; Tue, 21 Mar 2023 11:30:28 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 622FE410F3; Tue, 21 Mar 2023 11:30:28 +0100 (CET) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id 0A4A740A7A; Tue, 21 Mar 2023 11:30:26 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 3B06D3200C46; Tue, 21 Mar 2023 06:30:24 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 21 Mar 2023 06:30:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1679394623; x=1679481023; bh=5uoI1S7rI2YjWJV7tszOOzUjnuGFTCk/Jzo 7a28FODY=; b=wrhN/EdiSUs+drDsjiUPjoCfNTGmVOR7N17FUura5G4vCacGLZ1 +CfTiOOoBitLt8nabj3kwqpfLn/eYoRM0cVPtjYPa1zJfMc0KAYdnWB8dklEC2sN YgOkXcHMBDC5m22fqk1Mc7IcpDpXei1Xy4PN4OxdGNxL0zE9gLGTDNwGpPqXElgm A7PEbXmgj9RBjl/wsv+BUKEruF3Jv3hlIf0v+MCTgFcLB8uzOCCPZU9VjhpDbepa S1oEaMuD0V99SmStH7TGB/A0/GYeLYldUKddpDJy7eWRr15dri6vNn8j3edOYQKV Cn9jaLz5N3iTvk0D2LozvE4UrR/B9nejQng== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1679394623; x=1679481023; bh=5uoI1S7rI2YjWJV7tszOOzUjnuGFTCk/Jzo 7a28FODY=; b=YM9KkKCf+hbc/tTa6UFgbc07C7IcZuzzssMdckPWacPB1vzt9cj GgT2DbzMPHC8t0Ect2VVvUluarX57CydfllJfZyW71RiiHOLeTy+XlrRxWv8ZgZs G4yL5RsCO/asjKZx8K2eGlpm6KuPhZeGnamPwQqy3vpgO0CKvcjYlUZoREurHyzO ief59N2wsJiVCnmNVaDshz5kKgr/k3kT1BovQscnG2wsoqWH+CdPS9L6GlEEIELR VWUcMifrKr7+PsCuYH7D1SLQxTqujpofWI/Tp6EnyegGtugRSXRKtahsEX3msbHa BoqrAlgBO5HgbN1zWtqQ0IGjHmzPN9hkttg== X-ME-Sender: <xms:P4cZZAwA-ADO7paVbP3GizmBAJlQB-C6oBkIop2jNECQv3sFChUh0g> <xme:P4cZZETpqPQQpduxYEx7xSkH2seKR-RvG41V0rhPiqySTXFRNTwsqiJg6ovvLzNRa NxdJh1pWCjVwnZjlw> X-ME-Received: <xmr:P4cZZCXCjud9a__9C_sPKULdQM7RS_Iy9JYuNcN1IUh04s04Hsma1C2CLtRKQdJlrLFZsuAXbTJxVKwSNx4N1mD3Xw> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdegtddgudehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: <xmx:P4cZZOhTNS-28TcOWAF9caJGtWZOgXugau5rLh-xgptJh3PgtYFrhw> <xmx:P4cZZCDuOslEdz_VBAlquqBxmnwGCNKZAF9jzcMM3TSWmMsK2jIJ0g> <xmx:P4cZZPK_bmY1HLaulTBROd0g6MXPwYvfdd7Gw10bWymrzUfpFDa4kA> <xmx:P4cZZJ4AuXHlmgC3ZdGYxmJiGIJVgJNf7OKWcw8W_aisEC7HxtM3cw> Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 21 Mar 2023 06:30:22 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: "Huang, Wei" <wei.huang@intel.com> Cc: "dev@dpdk.org" <dev@dpdk.org>, "david.marchand@redhat.com" <david.marchand@redhat.com>, "stable@dpdk.org" <stable@dpdk.org>, "Xu, Rosen" <rosen.xu@intel.com>, "Zhang, Tianfei" <tianfei.zhang@intel.com>, "Zhang, Qi Z" <qi.z.zhang@intel.com> Subject: Re: [PATCH v1] raw/ifpga: remove virtual device unplug operation Date: Tue, 21 Mar 2023 11:30:19 +0100 Message-ID: <2637984.KRxA6XjA2N@thomas> In-Reply-To: <DM6PR11MB35302CEFBD9FD904202E18C1EF819@DM6PR11MB3530.namprd11.prod.outlook.com> References: <20230316204445.360330-1-wei.huang@intel.com> <18059490.sWSEgdgrri@thomas> <DM6PR11MB35302CEFBD9FD904202E18C1EF819@DM6PR11MB3530.namprd11.prod.outlook.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches <stable.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/stable>, <mailto:stable-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/stable/> List-Post: <mailto:stable@dpdk.org> List-Help: <mailto:stable-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/stable>, <mailto:stable-request@dpdk.org?subject=subscribe> Errors-To: stable-bounces@dpdk.org 21/03/2023 09:41, Huang, Wei: > From: Thomas Monjalon <thomas@monjalon.net> > > 21/03/2023 01:11, Huang, Wei: > > > From: Thomas Monjalon <thomas@monjalon.net> > > > > 16/03/2023 21:44, Wei Huang: > > > > > VDEV bus has implemented cleanup() function to perform cleanup for > > > > > devices on the bus during eal_cleanup(), so there is no need for > > > > > ifpga driver to record virtual devices and unplug them. > > > > > > > > Why no need? > > > > If the application wants to explicitly remove a device, what happens? > > > > > > > > > > > EAL will output an error information "Cannot find plugged device (%s)". > > > > It does not look what we expect. > > > Let me clear it. > With this patch, no error information will be outputted. > Without this patch, error information will be outputted. > Because bus cleanup action will unplug virtual device, > then ifpga PMD unplug the virtual device which is already be cleanup, Why ipfga unplug the device after the bus cleanup? I'm not following. > bus->find_device() returns NULL, > EAL output "Cannot find plugged device (%s)\n" at line 302 in eal_common_dev.c Anyway, the good answer is not to completely remove the "remove" operation.