From: Thomas Monjalon <thomas@monjalon.net>
To: Kumara Parameshwaran <kumaraparamesh92@gmail.com>
Cc: dev@dpdk.org, "stable@dpdk.org" <stable@dpdk.org>,
"Hu, Jiayu" <jiayu.hu@intel.com>
Subject: Re: [PATCH v5] gro: bug fix in identifying fragmented packets
Date: Tue, 05 Jul 2022 18:30:30 +0200 [thread overview]
Message-ID: <26413784.p16igRAIYV@thomas> (raw)
In-Reply-To: <962006acc1164a068d8cb727516c5816@intel.com>
> > From: Kumara Parameshwaran <kumaraparamesh92@gmail.com>
> >
> > A packet with RTE_PTYPE_L4_FRAG(0x300) contains both RTE_PTYPE_L4_TCP
> > (0x100) & RTE_PTYPE_L4_UDP (0x200). A fragmented packet as defined in
> > rte_mbuf_ptype.h cannot be recognized as other L4 types and hence the
> > GRO layer should not use IS_IPV4_TCP_PKT or IS_IPV4_UDP_PKT for
> > RTE_PTYPE_L4_FRAG. Hence, if the packet type is RTE_PTYPE_L4_FRAG the ip
> > header should be parsed to recognize the appropriate IP type and invoke the
> > respective gro handler.
> >
> > Fixes: 1ca5e6740852 ("gro: support UDP/IPv4")
> > Cc: stable@dpdk.org
> > Signed-off-by: Kumara Parameshwaran <kumaraparamesh92@gmail.com>
>
> Reviewed-by: Jiayu Hu <jiayu.hu@intel.com>
Applied, thanks.
prev parent reply other threads:[~2022-07-05 16:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-19 11:18 [PATCH v1] gro: fix gro for UDP " Kumara Parameshwaran
2022-03-20 10:12 ` [PATCH v2] " Kumara Parameshwaran
2022-06-08 9:46 ` [PATCH v3] gro: bug fix in identifying " Kumara Parameshwaran
2022-06-08 9:57 ` [PATCH v4] " Kumara Parameshwaran
2022-06-09 8:14 ` Thomas Monjalon
2022-06-09 14:19 ` Hu, Jiayu
2022-06-12 5:20 ` Hu, Jiayu
2022-06-17 11:33 ` kumaraparameshwaran rathinavel
2022-06-20 2:57 ` Hu, Jiayu
2022-06-20 5:23 ` kumaraparameshwaran rathinavel
2022-06-27 10:31 ` [PATCH v5] " Kumara Parameshwaran
2022-06-29 6:57 ` Hu, Jiayu
2022-07-05 16:30 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26413784.p16igRAIYV@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=jiayu.hu@intel.com \
--cc=kumaraparamesh92@gmail.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).