From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id B6EE1A0032
for <public@inbox.dpdk.org>; Wed, 29 Sep 2021 22:46:32 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id A80A3410EE;
Wed, 29 Sep 2021 22:46:32 +0200 (CEST)
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
[66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 6BAEA410EF;
Wed, 29 Sep 2021 22:46:31 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id 0A4795C014F;
Wed, 29 Sep 2021 16:46:29 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
by compute1.internal (MEProxy); Wed, 29 Sep 2021 16:46:29 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=fm2; bh=
V5vgmtOOdDg3cUVUnaqZBozIjZIV5DjuberCSMhllnk=; b=fur32FTq1b1KIczU
HPBbG8ZemGT2mj2i6HDZKkV+wzYGWvCrcVRlBt5FnxF+c2yBXAiNpCcwPuf9uHM0
v29okys5VMGeSaK+qESEkKjZSf3lE8iw5PJI9pUukxRB3mF1zkTp4BODyxJWqX5w
/grTjR2CidMMbceXPNzFbPmX/fOGFtpgml0ZT75K9z9+l/3JsRCsnnNSeknAnqDN
YcPYL1E7Zqw3TsTUbPDq7VMttEJ2Uo/SpmQT25qDEl/kBCZKh5cdyU/PgKmJMpto
8x39A+te4eUwFTktTefSbMURuJodP7JxK0oktQ9pks+OUvVrLenld14vF9jlmvty
R1xukQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm3; bh=V5vgmtOOdDg3cUVUnaqZBozIjZIV5DjuberCSMhll
nk=; b=oDEuqOCBML+B3bYZitRpixZI5aAMNsEdSxn4wQ7w00+mCvdQyBIO/TkiK
OegX4GGzwQnC0bHP6F8y2YPYsT3Pw01Ed/G4bzI/Ujk/HKW7UZ85u3fsFUWpE8IW
1vLSbj59lDlWnAC8iqBsrEfjAwdir1mOvnE7uwN4L6QQXDys5GSm2eAGaTuFwhSZ
lSB7sFB1MakdN/WB8/Ax5k3TcMfzTjeEX0OkCtqNtzFzsym7g8ir+5QOAuK0YO3s
5PBkmKoCcwDWwqRF0A01c/gh9IWtcVj/P5m8FYkweEGhRWkFSO2ZVUjw1jC4jHOL
N53qIINgFB0fTHk8vykbee6j2d9pQ==
X-ME-Sender: <xms:pNBUYcwA_R9YpXx9Nx59MiSbSCzN0PB642AP1Q4WIVTQhGm9csqKSQ>
<xme:pNBUYQS7dtkIGn5ZD4conuF0j00a6CXpIdrPGXXwxlth4jBTYL2HW-yy10W5CRrWV
YWliVYQiPWaQr4FbA>
X-ME-Received: <xmr:pNBUYeWQoxpOJSNVN1dnxAc3scFHxWAG7AMB6EARt873eMKH3rWkaTwGuXYW_cwKcbP_nqKhh93fwpNM-PPkc4-HAg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudekvddgudehtdcutefuodetggdotefrod
ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm
rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc
ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej
ueeiiedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh
hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght
X-ME-Proxy: <xmx:pNBUYajb0bku2lfh3SagzCj6frACYrqcRBNCol9ijAFJUjm199hAVg>
<xmx:pNBUYeA61xR2D5CJEM554ISQoqsrqL9PNRf4hHtiaG1GsvYja-W8ZQ>
<xmx:pNBUYbLt70VFTImIhtrgoCNN1mQsdfjVPW3qTxCaFxXXbN37JGz3ag>
<xmx:pdBUYR87I6FMPbYKGWRIIP0VuTEHlbuGSCHsOMXQvJZJ7IbdjmrjJA>
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed,
29 Sep 2021 16:46:27 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Bing Zhao <bingz@nvidia.com>
Cc: Slava Ovsiienko <viacheslavo@nvidia.com>, dev@dpdk.org,
Raslan Darawsheh <rasland@nvidia.com>, "stable@dpdk.org" <stable@dpdk.org>,
Matan Azrad <matan@nvidia.com>
Date: Wed, 29 Sep 2021 22:46:26 +0200
Message-ID: <2644582.ixtJruUp4O@thomas>
In-Reply-To: <DM4PR12MB5389F579747F61760C959CD3DFA99@DM4PR12MB5389.namprd12.prod.outlook.com>
References: <20210928040851.56636-1-bingz@nvidia.com>
<DM4PR12MB5389F579747F61760C959CD3DFA99@DM4PR12MB5389.namprd12.prod.outlook.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/mlx5: fix flow tables
double release
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>
29/09/2021 09:55, Matan Azrad:
> From: Bing Zhao
> > In the function mlx5_alloc_shared_dr(), there are various reasons to result in
> > a failure and error clean up process. While in the caller of mlx5_dev_spawn(),
> > once there is a error occurring after the mlx5_alloc_shared_dr(), the
> > mlx5_os_free_shared_dr() is called to release all the resources.
> >
> > To prevent a double release, the pointers of the resources should be
> > checked before the releasing and set to NULL after done.
> >
> > In the mlx5_free_table_hash_list(), after the releasing, the pointer was
> > missed to set to NULL and a double release may cause a crash.
> >
> > By setting the tables pointer to NULL as done for other resources, the double
> > release and crash could be solved.
> >
> > Fixes: 54534725d2f3 ("net/mlx5: fix flow table hash list conversion")
> > Cc: matan@mellanox.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Bing Zhao <bingz@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
Applied in next-net-mlx, thanks.