patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org, aconole@redhat.com
Subject: Re: [dpdk-stable] [PATCH] app/test: fix dependency on file in /sys
Date: Mon, 20 Jan 2020 16:29:35 +0100	[thread overview]
Message-ID: <2691914.dT8XKq9c71@xps> (raw)
In-Reply-To: <20200120122218.38703-1-bruce.richardson@intel.com>

20/01/2020 13:22, Bruce Richardson:
> Meson versions 0.52 and 0.53 are being overly smart and detecting the path
> "/sys/devices/system/cpu/present" in the call to cat in
> app/test/meson.build and then adding it as a dependency to the build
> configuration. This causes issues on systems where the timestamp of that
> file always returns the current time, since it means that the build.ninja
> file is always out of date, and therefore needs to be rebuilt.
> 
> We can fix this by just using a simple shell script to return the coremask
> appropriately for BSD and Linux, and removing that code logic from meson -
> thereby hiding the use of the /sys file.
> 
> Fixes: c70622ac6f72 ("test: detect number of cores with meson")
> Cc: aconole@redhat.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

Thanks a lot Bruce, meson stops reconfiguring, this is a life changer!

Applied (with new script added in MAINTAINERS), thanks



      reply	other threads:[~2020-01-20 15:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-20 12:22 Bruce Richardson
2020-01-20 15:29 ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2691914.dT8XKq9c71@xps \
    --to=thomas@monjalon.net \
    --cc=aconole@redhat.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).