patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH 1/2] eal/vfio: check if we already have the group fd open
@ 2018-09-17 13:46 Darek Stojaczyk
  2018-09-17 13:46 ` [dpdk-stable] [PATCH 2/2] eal/vfio: cleanup getting group fd Darek Stojaczyk
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Darek Stojaczyk @ 2018-09-17 13:46 UTC (permalink / raw)
  To: dev
  Cc: Alejandro Lucero, Anatoly Burakov, stable, Dariusz Stojaczyk,
	xiao.w.wang

From: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>

Always attempt to find already opened fd for an iommu
group as subsequent attempts to open it will fail.

There's no public API to check if a group was already
bound and has a container, so rte_vfio_container_group_bind()
shouldn't fail in such case.

Fixes: ea2dc1066870 ("vfio: add multi container support")
Cc: xiao.w.wang@intel.com

Signed-off-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
---
 lib/librte_eal/linuxapp/eal/eal_vfio.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/lib/librte_eal/linuxapp/eal/eal_vfio.c b/lib/librte_eal/linuxapp/eal/eal_vfio.c
index c68dc38e0..bcb869be1 100644
--- a/lib/librte_eal/linuxapp/eal/eal_vfio.c
+++ b/lib/librte_eal/linuxapp/eal/eal_vfio.c
@@ -1680,6 +1680,11 @@ rte_vfio_container_group_bind(int container_fd, int iommu_group_num)
 		return -1;
 	}
 
+	/* check if we already have the group descriptor open */
+	for (i = 0; i < VFIO_MAX_GROUPS; i++)
+		if (vfio_cfg->vfio_groups[i].group_num == iommu_group_num)
+			return vfio_cfg->vfio_groups[i].fd;
+
 	/* Check room for new group */
 	if (vfio_cfg->vfio_active_groups == VFIO_MAX_GROUPS) {
 		RTE_LOG(ERR, EAL, "Maximum number of VFIO groups reached!\n");
-- 
2.17.1

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-10-29  0:26 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-17 13:46 [dpdk-stable] [PATCH 1/2] eal/vfio: check if we already have the group fd open Darek Stojaczyk
2018-09-17 13:46 ` [dpdk-stable] [PATCH 2/2] eal/vfio: cleanup getting group fd Darek Stojaczyk
2018-09-26 12:34   ` Burakov, Anatoly
2018-09-25  7:56 ` [dpdk-stable] [PATCH 1/2] eal/vfio: check if we already have the group fd open Wang, Xiao W
2018-10-29  0:26   ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2018-09-26 12:35 ` [dpdk-stable] " Burakov, Anatoly

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).