From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0EA55A0C52 for ; Mon, 22 Nov 2021 09:58:25 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ED1CE4115C; Mon, 22 Nov 2021 09:58:24 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id B57BB4014E; Mon, 22 Nov 2021 09:58:22 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 040BF5C010E; Mon, 22 Nov 2021 03:58:22 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 22 Nov 2021 03:58:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= dJSEHfkYK3oO/3WOMyXYw7J1a5pu+ocks50vIWbXHOM=; b=fUKlMn3t79/iRCHK 39wrz7hZMT6AGU/SQIE1C4VkF7h5PgjyB1mcK+Wz2GZIV2LUUw3LLwMjp75SAVKR Zgrn+CnL723B/Yo7A29/3HSD2wDShpplfpUGEn+rJsuKeU3yoIZo9sJiYLlYfsKa zt+7ls3/ujO9PbssDXmCw7um3by9dwwUlZYDZblKagRHjTII34KYMZLWU6qglBnZ oosxak/E0VOQOGO0Ve+HNJlEuIyENPLtzsBP3KVJJ4Dq6n8DIaugsnzB313yY1T7 RjOFqDFIdhlxVrLZ1s03QEa1XQhY6XHgE6WqIEPiDvt4bGrF/BqF2sHHef/sWZcW wzUvRQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=dJSEHfkYK3oO/3WOMyXYw7J1a5pu+ocks50vIWbXH OM=; b=gEafDy8B0FvXhTyG+kP6VehtNNgfwg+Ph501egJyjP2rF5kZ8+BgMsLsz EFK5DFG9/8sV7zsgjoGoTqFIu/P6B1F2nuMp0Y3239UF45HCRYHbTyoXH49MWWAx sTpzCRQVTmzNWzZtTQekaEM1HmiloeMzpQRuLNV6xQjVk9P5nxAdDjwThYnSJH1t qbn+8HSwovjnvBRa9rSWQlkpR4R0raynykYHE4J9VGIdrj2yfjTBID/5T4jNu28d LxRnUP260eEIH8eCh9AwmJthtrS70HMCLprD2fMl0Gk8AQAYO3jNbAYOAgegUieJ u9R/JxAZCAkwR02Rou/Fkv+B+bixw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrgeefgdduvdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 22 Nov 2021 03:58:20 -0500 (EST) From: Thomas Monjalon To: Rakesh Kudurumalla Cc: "stable@dpdk.org" , "dev@dpdk.org" , "david.marchand@redhat.com" , "ferruh.yigit@intel.com" , "andrew.rybchenko@oktetlabs.ru" , "ajit.khaparde@broadcom.com" , Jerin Jacob Kollanukkaran Subject: Re: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if queues are full and Tx fails Date: Mon, 22 Nov 2021 09:58:18 +0100 Message-ID: <2704266.42xP9hQJsM@thomas> In-Reply-To: References: <20210720124713.603674-1-rkudurumalla@marvell.com> <2935187.TuyvbHr83s@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org 22/11/2021 08:59, Rakesh Kudurumalla: > From: Thomas Monjalon > > 20/07/2021 18:50, Rakesh Kudurumalla: > > > Current pmd_perf_autotest() in continuous mode tries to enqueue > > > MAX_TRAFFIC_BURST completely before starting the test. Some drivers > > > cannot accept complete MAX_TRAFFIC_BURST even though rx+tx desc > > count > > > can fit it. > > > > Which driver is failing to do so? > > Why it cannot enqueue 32 packets? > > Octeontx2 driver is failing to enqueue because hardware buffers are full before test. Why hardware buffers are full? > pmd_perf_autotest() in continuous mode tries to enqueue MAX_TRAFFIC_BURST (2048) > before starting the test. > > > > This patch changes behaviour to stop enqueuing after few retries. > > > > If there is a real limitation, there will be issues in more places than this test > > program. > > I feel it should be addressed either in the driver or at ethdev level. > > > > [...] > > > @@ -480,10 +483,19 @@ main_loop(__rte_unused void *args) > > > nb_tx = RTE_MIN(MAX_PKT_BURST, num); > > > nb_tx = rte_eth_tx_burst(portid, 0, > > > &tx_burst[idx], nb_tx); > > > + if (nb_tx == 0) > > > + retry_cnt++; > > > num -= nb_tx; > > > idx += nb_tx; > > > + if (retry_cnt == MAX_RETRY_COUNT) { > > > + retry_cnt = 0; > > > + break; > > > + }