From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id B02774548E
for <public@inbox.dpdk.org>; Wed, 19 Jun 2024 22:15:06 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id A2A544279A;
Wed, 19 Jun 2024 22:15:06 +0200 (CEST)
Received: from fhigh2-smtp.messagingengine.com
(fhigh2-smtp.messagingengine.com [103.168.172.153])
by mails.dpdk.org (Postfix) with ESMTP id 8A701402B8;
Wed, 19 Jun 2024 22:15:04 +0200 (CEST)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
by mailfhigh.nyi.internal (Postfix) with ESMTP id 2B34011401F5;
Wed, 19 Jun 2024 16:15:04 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
by compute2.internal (MEProxy); Wed, 19 Jun 2024 16:15:04 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:cc:content-transfer-encoding:content-type:content-type:date
:date:from:from:in-reply-to:in-reply-to:message-id:mime-version
:references:reply-to:subject:subject:to:to; s=fm2; t=1718828104;
x=1718914504; bh=OpIonoBvtkvbau34F5+AtQe5TBePsVXXEzgMrHQ/Fqw=; b=
GE2jTVR8nC5oFRBl3CVaqgeMAFPRQF7R6htDQYKbvNPSjqGOwI2LsoE4inuitjaN
X6yHgUIsjF7yyHjywq7abrU5gfJaINGQmSXviMvaW/j+qAIuMpE5po8A/0YMisYt
wm85ucaBUibs53k5LbvRez0/nvoGXEuJ+jHAoLR0KCykg9ttUUOR1bx5piS+28ls
1fzg3l5qDlyGsIc4En+DOeUh2+YEB0xwCUpYbBtzB1zl8wCI6vrPwbCCmn4s/1sJ
6/lN7FEQDJ1A3R1TlErQFPEk/+Yt9PzTdQ4U/45O2cutf5Sd9PtONEKjZzHpmFj9
jvtQ1t8uURPtuJj6L0peFw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:cc:content-transfer-encoding
:content-type:content-type:date:date:feedback-id:feedback-id
:from:from:in-reply-to:in-reply-to:message-id:mime-version
:references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy
:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1718828104; x=
1718914504; bh=OpIonoBvtkvbau34F5+AtQe5TBePsVXXEzgMrHQ/Fqw=; b=g
uU9FqBXLylUqsJPjdzSfNCQauF67zzXRJ/n2Byvov1dNVEVRmUDyH2CwueSVUutO
1gu5LN42q1+2eemRhu7d2nKB/XMVfFCIDFHlC0fJmm8AMyp5kdkoZaiZPChHEwoV
8fRgzTrjAKVVW5fXoIl5lCiOrQLMU+tmzIKSf2NX+RAVcLK58FBpxJxZiZiAE8Q1
iVXQttV2LIGguMsHyB30VZAuDijhbzIzIlmid+M2hpE/LIc21zQHyiWnuS22lWyJ
2+04jb+TD09FsewvcRzEyheHmrbj/GofDzCFgEGX2APBvJLnveYDw9efcNy+5mQ3
Mr2+b/RojMJx0HNNpfzgA==
X-ME-Sender: <xms:SDxzZsHXIQ-DZWP0GNrph-UXUJn7wQ3RziOJCN01MhVy6mSFUV8fVg>
<xme:SDxzZlVfImUM-5mKl_2DMV0q4Fuk66g6jmnOOCwGDL9HOC0rqcv5ef4FMRbBwK9Uq
skvQchwLVHd0BWw0g>
X-ME-Received: <xmr:SDxzZmJNBYGyNHb69it1PZWISPb9SbPR-2oVwp4gRDpN7A8GgngHasR65cchS3OHyEf_CLMKIFW8UbVcTgfs5sjhXw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfeeftddgudegiecutefuodetggdotefrod
ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvvefufffkjghfggfgtgesth
furedttddtjeenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgr
shesmhhonhhjrghlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpeejudevheeiveduud
dtveffgfdtgeekueevjeffjeegtdeggeekgfdvuefgfeekjeenucevlhhushhtvghrufhi
iigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghloh
hnrdhnvght
X-ME-Proxy: <xmx:SDxzZuFqA0r6jK6sXIPigG6iyhIfNsZYLlGuulrFDE1u2nDHmMay_w>
<xmx:SDxzZiVsKneIuB_OGDjIDYeiam-NHWjrwwydwnSmXPPofb-x2vwxZA>
<xmx:SDxzZhPmOyOQO489aTgzjqKnTRVuH-ON4U4cx6Y-eOfl917cAPIv6w>
<xmx:SDxzZp2ZV9deKioQzI2jQkaGNGp52SN0ewcPH0btKTtroyjf4q3gIg>
<xmx:SDxzZkKvKOqMw0edqycR0fK9eidH0DIS900DB6ISexXswirnqGeVT53n>
Feedback-ID: i47234305:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed,
19 Jun 2024 16:15:03 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Mingjin Ye <mingjinx.ye@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org, stephen@networkplumber.org,
bruce.richardson@intel.com, david.marchand@redhat.com
Subject: Re: [PATCH 2/3] bus/vdev: revert fix devargs after multi-process bus
scan
Date: Wed, 19 Jun 2024 22:15:00 +0200
Message-ID: <2735147.hTDNKPQEx9@thomas>
In-Reply-To: <20240314093630.1066948-3-mingjinx.ye@intel.com>
References: <20240314093630.1066948-1-mingjinx.ye@intel.com>
<20240314093630.1066948-3-mingjinx.ye@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
14/03/2024 10:36, Mingjin Ye:
> The asan tool detected a memory leak in the vdev driver alloc_devargs.
> The previous commit does not insert device arguments into devargs_list
What is the previous commit?
Where is devargs_list in this function?
> when attaching a device during a bus scan of a secondary process.
> This resulted in an existing memory leak when removing a vdev device,
> since rte_devargs_remove actually does nothing.
>
> Therefore the following commit was reverted accordingly.
>
> Fixes: f5b2eff0847d ("bus/vdev: fix devargs after multi-process bus scan")
>
> Restoring this commit will fix the memory leak. There was an issue with
> device parameters using free devargs when inserting a vdev device when
> devargs_list already existed, resulting in a core dump. A new patch
> will fix this issue.
>
> Fixes: f5b2eff0847d ("bus/vdev: fix devargs after multi-process bus scan")
> Cc: stable@dpdk.org
>
> Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
I'm not comfortable with reverting a so old commit.
Your previous attempt in this bus driver was not successful.
Please prove the memory leak cannot be simply fixed.