From: Thomas Monjalon <thomas@monjalon.net>
To: Pu Xu <583493798@qq.com>
Cc: "cuanduo@126.com" <cuanduo@126.com>,
dev@dpdk.org, "Burakov, Anatoly" <anatoly.burakov@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] ip_frag: fix fragmenting ipv4 packet with header option
Date: Sun, 24 May 2020 17:27:16 +0200 [thread overview]
Message-ID: <27420753.GspcrUYuLZ@thomas> (raw)
In-Reply-To: <BYAPR11MB3301E90D5EFED182E6BFD16A9AAB0@BYAPR11MB3301.namprd11.prod.outlook.com>
01/05/2020 22:43, Ananyev, Konstantin:
>
> >
> > When fragmenting ipv4 packet, the data offset should be calculated through
> > the ihl field in ip header rather than using sizeof(struct rte_ipv4_hdr).
> >
> > Fixes: 4c38e5532a07 ("ip_frag: refactor IPv4 fragmentation into a proper library")
> > Cc: anatoly.burakov@intel.com
> > Cc: stable@dpdk.org
> > ---
>
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
The patch cannot be merged because it is missing a Signed-off-by line.
In general, please follow the contributions guideline here:
http://core.dpdk.org/contribute/#send
Would be appreciated to number subsequent versions of the patches,
and use --in-reply-to to keep them threaded.
next prev parent reply other threads:[~2020-05-24 15:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 16:11 [dpdk-stable] " Pu Xu
2020-05-01 20:43 ` [dpdk-stable] [dpdk-dev] " Ananyev, Konstantin
2020-05-24 15:27 ` Thomas Monjalon [this message]
2021-03-24 21:30 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27420753.GspcrUYuLZ@thomas \
--to=thomas@monjalon.net \
--cc=583493798@qq.com \
--cc=anatoly.burakov@intel.com \
--cc=cuanduo@126.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).