* [dpdk-stable] [dpdk-dev] [PATCH] eal: fix bitmap documentation
@ 2018-07-17 17:14 Jerin Jacob
2018-08-01 15:55 ` Thomas Monjalon
0 siblings, 1 reply; 4+ messages in thread
From: Jerin Jacob @ 2018-07-17 17:14 UTC (permalink / raw)
To: dev; +Cc: cristian.dumitrescu, Jerin Jacob, stable
n_bits comes as first argument, align doxygen comment.
n_bit need to not be multiple of 512 as n_bits
are rounding to RTE_BITMAP_CL_BIT_SIZE.
Fixes: 14456f59e9f7 ("doc: fix doxygen warnings in QoS API")
Fixes: de3cfa2c9823 ("sched: initial import")
Cc: stable@dpdk.org
Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
lib/librte_eal/common/include/rte_bitmap.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/librte_eal/common/include/rte_bitmap.h b/lib/librte_eal/common/include/rte_bitmap.h
index 7d4935fcc..d9facc642 100644
--- a/lib/librte_eal/common/include/rte_bitmap.h
+++ b/lib/librte_eal/common/include/rte_bitmap.h
@@ -198,12 +198,12 @@ rte_bitmap_get_memory_footprint(uint32_t n_bits) {
/**
* Bitmap initialization
*
- * @param mem_size
- * Minimum expected size of bitmap.
+ * @param n_bits
+ * Number of pre-allocated bits in array2.
* @param mem
* Base address of array1 and array2.
- * @param n_bits
- * Number of pre-allocated bits in array2. Must be non-zero and multiple of 512.
+ * @param mem_size
+ * Minimum expected size of bitmap.
* @return
* Handle to bitmap instance.
*/
--
2.18.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH] eal: fix bitmap documentation
2018-07-17 17:14 [dpdk-stable] [dpdk-dev] [PATCH] eal: fix bitmap documentation Jerin Jacob
@ 2018-08-01 15:55 ` Thomas Monjalon
2018-08-02 14:34 ` Dumitrescu, Cristian
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Monjalon @ 2018-08-01 15:55 UTC (permalink / raw)
To: cristian.dumitrescu; +Cc: stable, Jerin Jacob, dev
Cristian, review please?
17/07/2018 19:14, Jerin Jacob:
> n_bits comes as first argument, align doxygen comment.
>
> n_bit need to not be multiple of 512 as n_bits
> are rounding to RTE_BITMAP_CL_BIT_SIZE.
>
> Fixes: 14456f59e9f7 ("doc: fix doxygen warnings in QoS API")
> Fixes: de3cfa2c9823 ("sched: initial import")
>
> Cc: stable@dpdk.org
>
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
> lib/librte_eal/common/include/rte_bitmap.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/lib/librte_eal/common/include/rte_bitmap.h b/lib/librte_eal/common/include/rte_bitmap.h
> index 7d4935fcc..d9facc642 100644
> --- a/lib/librte_eal/common/include/rte_bitmap.h
> +++ b/lib/librte_eal/common/include/rte_bitmap.h
> @@ -198,12 +198,12 @@ rte_bitmap_get_memory_footprint(uint32_t n_bits) {
> /**
> * Bitmap initialization
> *
> - * @param mem_size
> - * Minimum expected size of bitmap.
> + * @param n_bits
> + * Number of pre-allocated bits in array2.
> * @param mem
> * Base address of array1 and array2.
> - * @param n_bits
> - * Number of pre-allocated bits in array2. Must be non-zero and multiple of 512.
> + * @param mem_size
> + * Minimum expected size of bitmap.
> * @return
> * Handle to bitmap instance.
> */
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH] eal: fix bitmap documentation
2018-08-01 15:55 ` Thomas Monjalon
@ 2018-08-02 14:34 ` Dumitrescu, Cristian
2018-08-05 18:12 ` Thomas Monjalon
0 siblings, 1 reply; 4+ messages in thread
From: Dumitrescu, Cristian @ 2018-08-02 14:34 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: stable, Jerin Jacob, dev
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Wednesday, August 1, 2018 4:56 PM
> To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Cc: stable@dpdk.org; Jerin Jacob <jerin.jacob@caviumnetworks.com>;
> dev@dpdk.org
> Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] eal: fix bitmap documentation
>
> Cristian, review please?
>
> 17/07/2018 19:14, Jerin Jacob:
> > n_bits comes as first argument, align doxygen comment.
> >
> > n_bit need to not be multiple of 512 as n_bits
> > are rounding to RTE_BITMAP_CL_BIT_SIZE.
> >
> > Fixes: 14456f59e9f7 ("doc: fix doxygen warnings in QoS API")
> > Fixes: de3cfa2c9823 ("sched: initial import")
> >
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > ---
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH] eal: fix bitmap documentation
2018-08-02 14:34 ` Dumitrescu, Cristian
@ 2018-08-05 18:12 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2018-08-05 18:12 UTC (permalink / raw)
To: Jerin Jacob; +Cc: dev, Dumitrescu, Cristian, stable
02/08/2018 16:34, Dumitrescu, Cristian:
> > 17/07/2018 19:14, Jerin Jacob:
> > > n_bits comes as first argument, align doxygen comment.
> > >
> > > n_bit need to not be multiple of 512 as n_bits
> > > are rounding to RTE_BITMAP_CL_BIT_SIZE.
> > >
> > > Fixes: 14456f59e9f7 ("doc: fix doxygen warnings in QoS API")
> > > Fixes: de3cfa2c9823 ("sched: initial import")
> > >
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > > ---
>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-08-05 18:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-17 17:14 [dpdk-stable] [dpdk-dev] [PATCH] eal: fix bitmap documentation Jerin Jacob
2018-08-01 15:55 ` Thomas Monjalon
2018-08-02 14:34 ` Dumitrescu, Cristian
2018-08-05 18:12 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).