From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 81D82A0562
for <public@inbox.dpdk.org>; Mon, 12 Apr 2021 22:38:10 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 7233F141245;
Mon, 12 Apr 2021 22:38:10 +0200 (CEST)
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
[66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id D16E9141163;
Mon, 12 Apr 2021 22:38:07 +0200 (CEST)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
by mailout.nyi.internal (Postfix) with ESMTP id 378405C00E8;
Mon, 12 Apr 2021 16:38:07 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
by compute2.internal (MEProxy); Mon, 12 Apr 2021 16:38:07 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=fm3; bh=
RvBCTxPKqwjGYgVVNKUGOKLtrVKd1SNx9T/W8F3T0gg=; b=jF30p0LQ7FEnrNoo
vnxIM1Qrh2RfQBejA5w5SQ8+9IElhfa/vryjOv1hbWUF4/fWYJZcu9lwAkJT7kME
Oim8DoSg9caLip77VUKOk6BOEhCJZuQ4yMXt66beDzorYRNKPc39EKc9VAScaSRN
MZHSgW3bkfWFL3oXzh5YTYho0y2zoGbefGT5drYVde/f8a8HxSRNJSJPlHePqB+Y
idbRvy7GzAq4uTR79trNiguNzv3SlEwH1X3dys1ShsRJAJGDnlA1dAhnFSsbLJo1
md08nijGvQ9ahsodcJarNlYVG8pm0Fs+O1391s8ITO6T10n/m1UxBJa+YipYSTvi
awMm0g==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm2; bh=RvBCTxPKqwjGYgVVNKUGOKLtrVKd1SNx9T/W8F3T0
gg=; b=JLdW5dL62oIrwPFm2OSybxK4fZO2t5orpFDSpXazsRPOR1uFg9nBP8PZe
+g8TGHx6SHpV7MtqSyCR3SK+7HAPdUvpWRT1YvWYq5brbxrB5gBueVepjxxbcWhE
gr3Vq8ZTyMwNdXSi5gY8ghRDcY0EYDvPqPCfcPuuxXqSTg/WXTFlCbI1H/qlEEJs
+fg+DvI+E3PxJttERtxz6xYRJyV2Qkkxn5JMVPIEJOoYAYMIVIUVzI6l8d6cboGq
tfaoyWkv5eVCSpCZdpVgmSvAvxDpl368/tARbEBGytCRFKx6BWbngvRnTMtYplOJ
AZmTsOGEWZDbTSFqUliNe3Q7mhTeA==
X-ME-Sender: <xms:rq90YP_uQ10JQFj1hsNSNrNFxualJVkTkh2cX_RrSlunIopznneI1w>
<xme:rq90YLv4r3vBoqBty8WdnN1WRUuWfWCxBJEHMbTlQkksrzHbhJwBJGMlkOkJvK0yb
JNnJPNMjYhSDdgD8w>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudekjedgudehfecutefuodetggdotefrod
ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm
rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc
ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej
ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh
fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr
lhhonhdrnhgvth
X-ME-Proxy: <xmx:rq90YNBBKTFYKSaSrtHgA-rd679NtpswkjTDv-5k-oNL3Y3JsP-XXQ>
<xmx:rq90YLdRVVC4Ya300ub98NdXnkvsndaYi_Y6uYOdqmcIccV6nGcorQ>
<xmx:rq90YEP5tR6QNuBvZcPj_7XCtEwuKhaNLtZnSOjGLf5Gav3_NgOEIw>
<xmx:r690YAASF80Ji-HyuqO_SH_z0xrtP62mZQvosHOfkXf3UKkVJfXeow>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id AC3EA1080064;
Mon, 12 Apr 2021 16:38:05 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Tal Shnaiderman <talshn@nvidia.com>
Cc: dev@dpdk.org, stable@dpdk.org, pallavi.kadam@intel.com,
dmitry.kozliuk@gmail.com, navasile@linux.microsoft.com, dmitrym@microsoft.com,
david.marchand@redhat.com, lucp.at.work@gmail.com
Date: Mon, 12 Apr 2021 22:38:03 +0200
Message-ID: <27902224.8yUSzluuBG@thomas>
In-Reply-To: <20210412103744.13496-1-talshn@nvidia.com>
References: <20210410195433.13416-1-talshn@nvidia.com>
<20210412103744.13496-1-talshn@nvidia.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-stable] [PATCH v2] eal/windows: fix pthreads macros
return values
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>
12/04/2021 12:37, Tal Shnaiderman:
> The macro definitions of the following pthread functions
> return incorrect values from the inner function return code.
>
> while pthread_barrier_init, pthread_barrier_destroy and
> pthread_cancel return 0 in a case of success and non zero (errno) value
> otherwise the shimming functions InitializeSynchronizationBarrier,
> DeleteSynchronizationBarrier and TerminateThread return FALSE (0)
> in a case of failure and TRUE(1) in a case of success.
>
> This issue was undetected as none of the functions return codes was
> checked until such check was added in commit 34cc55cce6b1 ("eal: fix
> race in control thread creation") exposing the issue by failing
> pthread_barrier_init and rte_eal_init on Windows as a result.
>
> The fix aligned the return value of the 3 function with the expected
> pthread API return values.
>
> Fixes: e8428a9d89f1 ("eal/windows: add some basic functions and macros")
> Cc: stable@dpdk.org
>
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> ---
> v2:
> -fix unused value warning in MinGW-64 [DmitryK]
> -remove unneeded "fixes" comment [DavidM]
Applied, thanks