patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] net/vhost: do not zero ol_flags in eth_vhost_rx()
@ 2018-05-10  7:04 Tiwei Bie
  2018-05-16 10:55 ` Maxime Coquelin
  0 siblings, 1 reply; 3+ messages in thread
From: Tiwei Bie @ 2018-05-10  7:04 UTC (permalink / raw)
  To: maxime.coquelin; +Cc: lei.a.yao, mtetsuyah, 3chas3, dev, Jan Blunck, stable

The ol_flags of mbufs returned by rte_vhost_dequeue_burst()
contain necessary offload information. It can't be zeroed.

Fixes: f63d356ee993 ("net/vhost: insert/strip VLAN header in software")
Cc: Jan Blunck <jblunck@infradead.org>
Cc: stable@dpdk.org

Reported-by: Lei Yao <lei.a.yao@intel.com>
Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
---
 drivers/net/vhost/rte_eth_vhost.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c
index ff5424a92..47fd23eb3 100644
--- a/drivers/net/vhost/rte_eth_vhost.c
+++ b/drivers/net/vhost/rte_eth_vhost.c
@@ -400,7 +400,6 @@ eth_vhost_rx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)
 
 	for (i = 0; likely(i < nb_rx); i++) {
 		bufs[i]->port = r->port;
-		bufs[i]->ol_flags = 0;
 		bufs[i]->vlan_tci = 0;
 
 		if (r->internal->vlan_strip)
-- 
2.11.0

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [PATCH] net/vhost: do not zero ol_flags in eth_vhost_rx()
  2018-05-10  7:04 [dpdk-stable] [PATCH] net/vhost: do not zero ol_flags in eth_vhost_rx() Tiwei Bie
@ 2018-05-16 10:55 ` Maxime Coquelin
  2018-05-16 14:36   ` Maxime Coquelin
  0 siblings, 1 reply; 3+ messages in thread
From: Maxime Coquelin @ 2018-05-16 10:55 UTC (permalink / raw)
  To: Tiwei Bie; +Cc: lei.a.yao, mtetsuyah, 3chas3, dev, Jan Blunck, stable



On 05/10/2018 09:04 AM, Tiwei Bie wrote:
> The ol_flags of mbufs returned by rte_vhost_dequeue_burst()
> contain necessary offload information. It can't be zeroed.
> 
> Fixes: f63d356ee993 ("net/vhost: insert/strip VLAN header in software")
> Cc: Jan Blunck<jblunck@infradead.org>
> Cc:stable@dpdk.org
> 
> Reported-by: Lei Yao<lei.a.yao@intel.com>
> Signed-off-by: Tiwei Bie<tiwei.bie@intel.com>
> ---
>   drivers/net/vhost/rte_eth_vhost.c | 1 -
>   1 file changed, 1 deletion(-)

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [PATCH] net/vhost: do not zero ol_flags in eth_vhost_rx()
  2018-05-16 10:55 ` Maxime Coquelin
@ 2018-05-16 14:36   ` Maxime Coquelin
  0 siblings, 0 replies; 3+ messages in thread
From: Maxime Coquelin @ 2018-05-16 14:36 UTC (permalink / raw)
  To: Tiwei Bie; +Cc: lei.a.yao, mtetsuyah, 3chas3, dev, Jan Blunck, stable



On 05/16/2018 12:55 PM, Maxime Coquelin wrote:
> 
> 
> On 05/10/2018 09:04 AM, Tiwei Bie wrote:
>> The ol_flags of mbufs returned by rte_vhost_dequeue_burst()
>> contain necessary offload information. It can't be zeroed.
>>
>> Fixes: f63d356ee993 ("net/vhost: insert/strip VLAN header in software")
>> Cc: Jan Blunck<jblunck@infradead.org>
>> Cc:stable@dpdk.org
>>
>> Reported-by: Lei Yao<lei.a.yao@intel.com>
>> Signed-off-by: Tiwei Bie<tiwei.bie@intel.com>
>> ---
>>   drivers/net/vhost/rte_eth_vhost.c | 1 -
>>   1 file changed, 1 deletion(-)
> 
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Applied to dpdk-next-virtio/master with commit message reworded to:

net/vhost: do not clear offload flags in Rx

> Thanks,
> Maxime

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-05-16 14:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-10  7:04 [dpdk-stable] [PATCH] net/vhost: do not zero ol_flags in eth_vhost_rx() Tiwei Bie
2018-05-16 10:55 ` Maxime Coquelin
2018-05-16 14:36   ` Maxime Coquelin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).