From: Thomas Monjalon <thomas@monjalon.net>
To: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Cc: stable@dpdk.org, David Marchand <david.marchand@redhat.com>,
dev <dev@dpdk.org>, ruifeng.wang@arm.com, nd <nd@arm.com>,
ferruh.yigit@intel.com
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 1/2] test/rcu: increase the size of num cores variable
Date: Fri, 28 Jun 2019 15:34:32 +0200 [thread overview]
Message-ID: <2800271.zs2T813PYt@xps> (raw)
In-Reply-To: <CAJFAV8xPFkG25tS7dKXAU_1FZhG8Y8Xuic0fQkCDdaGZ2YSBag@mail.gmail.com>
28/06/2019 11:09, David Marchand:
> On Fri, Jun 28, 2019 at 5:44 AM Honnappa Nagarahalli
> > --- a/app/test/test_rcu_qsbr.c
> > +++ b/app/test/test_rcu_qsbr.c
> > @@ -27,7 +27,7 @@
> > #define TEST_RCU_QSBR_CNT_INIT 1
> >
> > uint16_t enabled_core_ids[RTE_MAX_LCORE];
> > -uint8_t num_cores;
> > +uint16_t num_cores;
>
> If we want to be closer to the eal API, those should be unsigned int.
I agree, please use unsigned int where relevant.
next prev parent reply other threads:[~2019-06-28 13:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 3:44 [dpdk-stable] " Honnappa Nagarahalli
2019-06-28 3:44 ` [dpdk-stable] [PATCH 2/2] test/rcu: address test case failure Honnappa Nagarahalli
2019-06-28 9:16 ` David Marchand
2019-06-28 13:53 ` Honnappa Nagarahalli
2019-06-28 14:09 ` David Marchand
2019-06-28 16:36 ` Honnappa Nagarahalli
2019-06-28 16:54 ` David Marchand
2019-06-28 9:09 ` [dpdk-stable] [dpdk-dev] [PATCH 1/2] test/rcu: increase the size of num cores variable David Marchand
2019-06-28 13:34 ` Thomas Monjalon [this message]
2019-06-28 16:38 ` Honnappa Nagarahalli
2019-06-28 16:35 ` [dpdk-stable] [PATCH v2 " Honnappa Nagarahalli
2019-06-28 16:35 ` [dpdk-stable] [PATCH v2 2/2] test/rcu: address test case failure Honnappa Nagarahalli
2019-06-28 17:11 ` [dpdk-stable] [PATCH v2 1/2] test/rcu: increase the size of num cores variable David Marchand
2019-06-28 18:43 ` [dpdk-stable] [PATCH v3 " Honnappa Nagarahalli
2019-06-28 18:43 ` [dpdk-stable] [PATCH v3 2/2] test/rcu: address test case failure Honnappa Nagarahalli
2019-06-28 18:54 ` [dpdk-stable] [PATCH v3 1/2] test/rcu: increase the size of num cores variable David Marchand
2019-06-29 12:25 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2800271.zs2T813PYt@xps \
--to=thomas@monjalon.net \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=nd@arm.com \
--cc=ruifeng.wang@arm.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).