From: Thomas Monjalon <thomas@monjalon.net>
To: Elena Agostini <eagostini@nvidia.com>
Cc: dev@dpdk.org, stable@dpdk.org,
David Marchand <david.marchand@redhat.com>
Subject: Re: [PATCH] gpudev: export header file for external drivers
Date: Sun, 19 Mar 2023 23:43:50 +0100 [thread overview]
Message-ID: <2800348.88bMQJbFj6@thomas> (raw)
In-Reply-To: <2906874.VdNmn5OnKV@thomas>
19/03/2023 23:28, Thomas Monjalon:
> 16/03/2023 10:23, David Marchand:
> > On Thu, Mar 16, 2023 at 9:59 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> > >
> > > In DPDK 21.05, the option driver_sdk_headers was introduced
> > > to export required headers to allow building out-of-tree drivers.
> > >
> > > In DPDK 21.11, the gpudev driver class was introduced,
> > > without this out-of-tree compatibility.
> > >
> > > It is fixed by exporting gpudev_driver.h as part of the driver SDK.
> > >
> > > Fixes: 8b8036a66e3d ("gpudev: introduce GPU device class library")
> > > Cc: stable@dpdk.org
> > >
> > > Reported-by: David Marchand <david.marchand@redhat.com>
> > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> >
> > LGTM, thanks.
>
> Applied
Forgot to send the v2 merged with this addition:
"
As a consequence of exporting this header file,
C++ "extern C" guard must be added.
"
prev parent reply other threads:[~2023-03-19 22:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 8:59 Thomas Monjalon
2023-03-16 9:23 ` David Marchand
2023-03-19 22:28 ` Thomas Monjalon
2023-03-19 22:43 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2800348.88bMQJbFj6@thomas \
--to=thomas@monjalon.net \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=eagostini@nvidia.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).