From: Omer Yamac <omer.yamac@ceng.metu.edu.tr>
To: "Hunt, David" <david.hunt@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [PATCH v2] examples/distributor: update dynamic configuration
Date: Fri, 02 Sep 2022 08:20:10 +0300 [thread overview]
Message-ID: <280448dcd62dc2fc16f3f6907e52d728@ceng.metu.edu.tr> (raw)
In-Reply-To: <a4c6c009-43c0-80ff-6b3d-0dacb81567a5@intel.com>
Hi David,
I applied the changes as new version (v3), Thank you
On 01.09.2022 13:58, Hunt, David wrote:
> Hi Ömer,
>
> On 28/06/2022 20:54, omer.yamac at ceng.metu.edu.tr (Abdullah Ömer
> Yamaç) wrote:
>> In this patch,
>> * It is possible to switch the running mode of the distributor
>> using the command line argument.
>> * With "-c" parameter, you can run RX and Distributor
>> on the same core.
>> * Without "-c" parameter, you can run RX and Distributor
>> on the different core.
>> * Syntax error of the single RX and distributor core is fixed.
>
>
> I believe this particular fix is already merged and back-ported to
> stable. No need to include this line in the commit message.
>
>
>> * Consecutive termination of the lcores fixed.
>> The termination order was wrong, and you couldn't terminate the
>> application while traffic was capturing. The current order is
>> RX -> Distributor -> TX -> Workers
>> * When "-c" parameter is active, the wasted distributor core is
>> also deactivated in the main function.
>>
>> Fixes: 4a7f40c0ff9a ("examples/distributor: add dedicated core")
>> Cc: stable at dpdk.org
>
>
> This is a feature change, not a fix, so I don't believe you need the
> "Fixes" line or the "Cc: stable" line.
>
>
>>
>> Signed-off-by: Abdullah ?mer Yama? <omer.yamac at ceng.metu.edu.tr>
>
>
> I've tested this with the "-c" option, works well. Traffic coming into
> the app is distributed among the core. With -c added to the command
> line parameters, I have an extra worker core, as expected. Looks good
> to me.
>
> With the above suggested changes to the commit message:
>
> Reviewed-by: David Hunt <david.hunt@intel.com>
next prev parent reply other threads:[~2022-09-02 5:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 21:13 [PATCH] " Abdullah Ömer Yamaç
2022-06-28 19:54 ` [PATCH v2] " Abdullah Ömer Yamaç
2022-09-01 10:58 ` Hunt, David
2022-09-02 5:20 ` Omer Yamac [this message]
2022-09-02 8:37 ` Hunt, David
2022-06-28 19:37 Abdullah Ömer Yamaç
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=280448dcd62dc2fc16f3f6907e52d728@ceng.metu.edu.tr \
--to=omer.yamac@ceng.metu.edu.tr \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).