From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 94BC442D4E
for <public@inbox.dpdk.org>; Sun, 25 Jun 2023 21:22:29 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 8747C42D0E;
Sun, 25 Jun 2023 21:22:29 +0200 (CEST)
Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com
[64.147.123.21])
by mails.dpdk.org (Postfix) with ESMTP id 6A51D40ED8;
Sun, 25 Jun 2023 21:22:27 +0200 (CEST)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
by mailout.west.internal (Postfix) with ESMTP id 6CD443200913;
Sun, 25 Jun 2023 15:22:25 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
by compute2.internal (MEProxy); Sun, 25 Jun 2023 15:22:26 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:cc:content-transfer-encoding:content-type:content-type:date
:date:from:from:in-reply-to:in-reply-to:message-id:mime-version
:references:reply-to:sender:subject:subject:to:to; s=fm2; t=
1687720945; x=1687807345; bh=7JPlBnFVp007lEukR7Q5uC0LkHQXg+PyJAj
HIbnk4aI=; b=U+cp7h1xS1bNdS5nr43pbRIWqP9HUNWfILXUUCnodnjfstT2V1y
fQknqL/tnBCDFf91i0WDIaSAqFhu1SpEI5B+b5s+UfPVS/rThdi0Xsrwq+ZOC2k0
LOfGT2DaG0cNqeoE7nl93LDw6Rnn6NUm0nPvwALIo28JVZ+5DVLAEZ0b+gOgwwXy
aql29f2LEqJYx2pKNd6uYgTGgI/aIcXelKDJ3mAYywppdT8L5LJmQrAGLOkHgDjO
Hr5uG771fnxztclptZByKh7MLc5IdF/TbhcSNuqF2RuZz5Kau1QwN7SeoAy0aC3Y
NYvSsrBDxVXIPbiMohuSNu/z44faektGJ8Q==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:cc:content-transfer-encoding
:content-type:content-type:date:date:feedback-id:feedback-id
:from:from:in-reply-to:in-reply-to:message-id:mime-version
:references:reply-to:sender:subject:subject:to:to:x-me-proxy
:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=
1687720945; x=1687807345; bh=7JPlBnFVp007lEukR7Q5uC0LkHQXg+PyJAj
HIbnk4aI=; b=SeGchLl33pr/4aJQrIGAjoixqTKBHMinGaE4ibRfJipfqTMLj2I
/STiHrHJBtBJ9OFSlfKcLocEUgxXhWAcFU6MwEi4DStkA3lZREueTnXOwHTYUdwd
wKPWnCtKlAB+lVsMcrpTjEIavlbUdLidjM8M/pWi8kt7bdgaXdcvmR/wYYyXKU0t
LUB6oD6GW12smYhySm35yW531vu79Lq2vNQrHlm9vC1K9OJTMfjMG+Eqy0ebzLu7
ctSM6MktdbgT098jZxAbDOtDtaTP3M/Lt/i3UslmUOZwLhdjioDldaDVMYJ3XJ3p
zK7DqMRZH2xcI6USLJymXk8Fhqdg/BAZZSw==
X-ME-Sender: <xms:8JOYZAstw7bW7VUjLuSIVy5uWrJ3bH0CT0Z5evcRsj4lYo1eiD9LPA>
<xme:8JOYZNcrrIMAB51qIMz5qP91Hll6VYNNOleFxdw3rYBvQzPSHrVn3o3BXESVFhmsr
FMOM12PRBx5mnfEbA>
X-ME-Received: <xmr:8JOYZLwsRpN9sbLuBtLfGNjFnI2beacRLEwBm7jaKtT7zhZ9pEVvigzVGGFeSEUJPEusq3_cLQJ8bDM0WlqEN1CzwA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgeehtddgudefgecutefuodetggdotefrod
ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho
mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne
cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt
ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh
hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth
X-ME-Proxy: <xmx:8JOYZDNgRUtC_I0MtnetOyy0gSF6TG9kiBmbFtb1CyATNwM2aa-B7g>
<xmx:8JOYZA-MP4Z2urQGo-F8wIW_CHtTQ_r_v0_IU6JF85_ZeTxIIYqCLA>
<xmx:8JOYZLW4nuEYiZr2n-TZHfS49kuuaXkMBl7NCNWkgbqMjM4nF9uzkw>
<xmx:8ZOYZES8Ce5isl_msHIs9MdOEF8l7nIR7Be7oc1IX0-QMlq3ixC50Q>
Feedback-ID: i47234305:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun,
25 Jun 2023 15:22:23 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Kai Ji <kai.ji@intel.com>, Didier Pallard <didier.pallard@6wind.com>,
gakhil@marvell.com
Cc: dev@dpdk.org, stable@dpdk.org,
Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>,
Tomasz Kulasek <tomaszx.kulasek@intel.com>,
Michal Kobylinski <michalx.kobylinski@intel.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>,
Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>
Subject: Re: [PATCH] crypto/openssl: do not build useless workaround
Date: Sun, 25 Jun 2023 21:22:21 +0200
Message-ID: <2809888.Y6S9NjorxK@thomas>
In-Reply-To: <20230418145619.2648068-1-didier.pallard@6wind.com>
References: <20230418145619.2648068-1-didier.pallard@6wind.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
18/04/2023 16:56, Didier Pallard:
> This workaround was needed before version 1.0.1f. Do not build it for
> versions >= 1.1.
>
> Fixes: d61f70b4c918 ("crypto/libcrypto: add driver for OpenSSL library")
> Signed-off-by: Didier Pallard <didier.pallard@6wind.com>
> Cc: stable@dpdk.org
[...]
> +#if OPENSSL_VERSION_NUMBER < 0x10100000L
> /* Workaround open ssl bug in version less then 1.0.1f */
> if (EVP_EncryptUpdate(ctx, empty, &unused, empty, 0) <= 0)
> goto process_auth_encryption_gcm_err;
> +#endif
What happens if we build with OpenSSL 1.1 and run with OpenSSL 1.0?
Can we have a runtime check?
Or is it better doing the workaround always as before?