From: "Mattias Rönnblom" <hofors@lysator.liu.se>
To: David Marchand <david.marchand@redhat.com>, dev@dpdk.org
Cc: bruce.richardson@intel.com, stable@dpdk.org,
"Wathsala Vithanage" <wathsala.vithanage@arm.com>,
"Mattias Rönnblom" <mattias.ronnblom@ericsson.com>,
"Morten Brørup" <mb@smartsharesystems.com>
Subject: Re: [PATCH v5 6/9] eal/arm: fix C++ build for 32-bit memcpy
Date: Sat, 27 Sep 2025 08:33:55 +0200 [thread overview]
Message-ID: <28464878-8221-4bdb-b63a-8e1414c24302@lysator.liu.se> (raw)
In-Reply-To: <20250926124103.750844-7-david.marchand@redhat.com>
On 9/26/25 14:40, David Marchand wrote:
> This was caught while checking ARM arch headers.
>
> In file included from buildtools/chkincs/chkincs-cpp.p/rte_memcpy_32.cpp:1:
> /home/runner/work/dpdk/dpdk/lib/eal/arm/include/rte_memcpy_32.h:302:1:
> error: expected declaration before ‘}’ token
> 302 | }
> | ^
>
Acked-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
> Fixes: 719834a6849e ("use C linkage where appropriate in headers")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> lib/eal/arm/include/rte_memcpy_32.h | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/lib/eal/arm/include/rte_memcpy_32.h b/lib/eal/arm/include/rte_memcpy_32.h
> index 99fd5757ca..861be06f5e 100644
> --- a/lib/eal/arm/include/rte_memcpy_32.h
> +++ b/lib/eal/arm/include/rte_memcpy_32.h
> @@ -19,10 +19,14 @@
> /* ARM NEON Intrinsics are used to copy data */
> #include <arm_neon.h>
>
> +#endif /* RTE_ARCH_ARM_NEON_MEMCPY */
> +
> #ifdef __cplusplus
> extern "C" {
> #endif
>
> +#ifdef RTE_ARCH_ARM_NEON_MEMCPY
> +
> static inline void
> rte_mov16(uint8_t *dst, const uint8_t *src)
> {
> @@ -252,7 +256,7 @@ rte_memcpy_func(void *dst, const void *src, size_t n)
> return ret;
> }
>
> -#else
> +#else /* ! RTE_ARCH_ARM_NEON_MEMCPY */
>
> static inline void
> rte_mov16(uint8_t *dst, const uint8_t *src)
next prev parent reply other threads:[~2025-09-27 6:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20241127112617.1331125-1-david.marchand@redhat.com>
[not found] ` <20250926124103.750844-1-david.marchand@redhat.com>
2025-09-26 12:40 ` David Marchand
2025-09-26 13:01 ` Bruce Richardson
2025-09-26 19:55 ` Morten Brørup
2025-09-27 6:33 ` Mattias Rönnblom [this message]
[not found] ` <20250930065740.1838899-1-david.marchand@redhat.com>
2025-09-30 6:57 ` [PATCH v6 " David Marchand
[not found] ` <20251001064512.2539269-1-david.marchand@redhat.com>
2025-10-01 6:45 ` [PATCH v7 " David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28464878-8221-4bdb-b63a-8e1414c24302@lysator.liu.se \
--to=hofors@lysator.liu.se \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=mattias.ronnblom@ericsson.com \
--cc=mb@smartsharesystems.com \
--cc=stable@dpdk.org \
--cc=wathsala.vithanage@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).