From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <stable-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F153743B8F for <public@inbox.dpdk.org>; Mon, 4 Mar 2024 16:35:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E567F40695; Mon, 4 Mar 2024 16:35:47 +0100 (CET) Received: from fout6-smtp.messagingengine.com (fout6-smtp.messagingengine.com [103.168.172.149]) by mails.dpdk.org (Postfix) with ESMTP id 7279A4027D; Mon, 4 Mar 2024 16:35:46 +0100 (CET) Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailfout.nyi.internal (Postfix) with ESMTP id D67B11380112; Mon, 4 Mar 2024 10:35:45 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Mon, 04 Mar 2024 10:35:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1709566545; x=1709652945; bh=L0nuEKLaR+KiV8H09LzlD7qKsEqlUaO6BZ1yH0gEQE0=; b= GNvBzu3lK6pTSTdiGhy8qyEioSVzPNjRX6VHAwFHSzr5PAhJqDW4l1Nk+2ZHhVlx OserMfB5PSwPLtXU12ALiWXxgew1JO4Ry+TtOWWWF7Vvqu7fIlqPc0r6Pg4PxhEy VyZ+XaZCUR4dLXS7aMBFW/GOTtlnAiTzzQ1aLMzmcvaULWV3WPLrLR+5RBsWdem4 u122bWfnog5MaZJwR9B7s5fxqwF41kAnZZ/gCjPWA9N12Mpbd6i6vFNpkNWXm+0m wee5LSBympVuRhnR6OMDtD4bCQ01MW7kYn3jksfx5Vo8XhJ0+asXRZVKt4XbuGH/ 34CXJdWHIATOm00AEOBEkQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1709566545; x= 1709652945; bh=L0nuEKLaR+KiV8H09LzlD7qKsEqlUaO6BZ1yH0gEQE0=; b=G GVMHgOJCGY4h1JmJ+cSeENSMmdnNud7mDqzxEtghav6Y+QeWI9GwQpZaNb7KOt9+ AsWWrcHPLgwsgz4uVY3uvXs/afQytaSBFIlGd46Xw6+FpGRYmuhJ7QyWtoAIqXWe nYqgXM04INR/VyPPUc1p34nQkGyKy9S3eQHmfdLQITdld8u7CuQO729m/yozHQyg ccoMgAcMMSBWV+6S2Y9XeO1W5euRUVMm7qUrRf4MMN+uZcxEpk0qAWndr9UKRp/l 0HLW++P+c0Os63+emo2W2Mjjsz9SRfQN1I9agg+Xa2fy9OtNRI8N3tN14X0z6fI2 u2jBnYOTzNkGMRgBr9h+w== X-ME-Sender: <xms:UerlZQJA4g7s1DloJxJZ6VWWfRYl0_0giToY90Bpf5koe3Kmjqy64Q> <xme:UerlZQIppaGn8btfm78IL-p8eYBYQti55MDPJIkHgzF6K9c-1ZE3JtI3Zkpi_BjBs QP81HdeourXkrq2mw> X-ME-Received: <xmr:UerlZQuaYrei1sBJmZAv-CH7lkV0GXpuDUYLYCDqHDFXCvY6iaNymW-d6BLf2hxFjxXtsk6bhibyCwEf8eaOAIwxww> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrheejgdejjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: <xmx:UerlZdbkaHw3G1q0CKDe-_Bw1k1yEssz0Vl3Ub2oBAzBH-bY7Xktlg> <xmx:UerlZXZ3zfuLLL08y1itx4l8EYrgiWfdrhQx9hcKN4kIH-C9RSyECg> <xmx:UerlZZB9fsW1SWrurjDa1rA4814r29feT3BMsBjcR3Z4tPzSsGeBxQ> <xmx:UerlZSweaeLXAJMJVkePdkOOncmQOVuLJDmsR6r6KBwRBHQSg8Ycaw> Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 4 Mar 2024 10:35:44 -0500 (EST) From: Thomas Monjalon <thomas@monjalon.net> To: Bruce Richardson <bruce.richardson@intel.com> Cc: dev@dpdk.org, jerinj@marvell.com, mattias.ronnblom@ericsson.com, stable@dpdk.org Subject: Re: [PATCH v4 12/12] eventdev: fix doxygen processing of event vector struct Date: Mon, 04 Mar 2024 16:35:41 +0100 Message-ID: <2866921.yaVYbkx8dN@thomas> In-Reply-To: <20240221103221.933238-13-bruce.richardson@intel.com> References: <20240119174346.108905-1-bruce.richardson@intel.com> <20240221103221.933238-1-bruce.richardson@intel.com> <20240221103221.933238-13-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches <stable.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/stable>, <mailto:stable-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/stable/> List-Post: <mailto:stable@dpdk.org> List-Help: <mailto:stable-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/stable>, <mailto:stable-request@dpdk.org?subject=subscribe> Errors-To: stable-bounces@dpdk.org 21/02/2024 11:32, Bruce Richardson: > The event vector struct was missing comments on two members, and also > was inadvertently creating a local variable called "__rte_aligned" in > the doxygen output. > > Correct the comment markers to fix the former issue, and fix the latter > by putting "#ifdef __DOXYGEN" around the alignment constraint. [..] > +#ifndef __DOXYGEN__ > } __rte_aligned(16); > +#else > +}; > +#endif Would it be possible to make __rte_aligned empty in rte_common.h instead of each call? Does it fix Doxygen bug?