patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] net/e1000: fix filter control return value
       [not found] <20201208081006.35125-1-benhaz1024@gmail.com>
@ 2021-03-17  9:15 ` Xiaozhen Ban
  2021-03-17 11:23   ` Wang, Haiyue
  0 siblings, 1 reply; 6+ messages in thread
From: Xiaozhen Ban @ 2021-03-17  9:15 UTC (permalink / raw)
  To: jia.guo, haiyue.wang; +Cc: dev, stable

If filter_type not supported, eth_igb_filter_ctrl() will return
incorrect value.

Fixes: dd5c2dd7e5e5 ("igb: use generic filter control for ethertype filter")
Cc: stable@dpdk.org
Signed-off-by: Xiaozhen Ban <benhaz1024@gmail.com>
---
 drivers/net/e1000/igb_ethdev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
index 1716d6b90..325461247 100644
--- a/drivers/net/e1000/igb_ethdev.c
+++ b/drivers/net/e1000/igb_ethdev.c
@@ -4599,6 +4599,7 @@ eth_igb_filter_ctrl(struct rte_eth_dev *dev __rte_unused,
 	default:
 		PMD_DRV_LOG(WARNING, "Filter type (%d) not supported",
 							filter_type);
+		ret = -EINVAL;
 		break;
 	}
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-stable] [PATCH] net/e1000: fix filter control return value
  2021-03-17  9:15 ` [dpdk-stable] [PATCH] net/e1000: fix filter control return value Xiaozhen Ban
@ 2021-03-17 11:23   ` Wang, Haiyue
  2021-03-18 11:44     ` Xiaozhen Ban
  0 siblings, 1 reply; 6+ messages in thread
From: Wang, Haiyue @ 2021-03-17 11:23 UTC (permalink / raw)
  To: Xiaozhen Ban, Guo, Jia; +Cc: dev, stable

> -----Original Message-----
> From: Xiaozhen Ban <benhaz1024@gmail.com>
> Sent: Wednesday, March 17, 2021 17:16
> To: Guo, Jia <jia.guo@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: [PATCH] net/e1000: fix filter control return value
> 
> If filter_type not supported, eth_igb_filter_ctrl() will return
> incorrect value.
> 
> Fixes: dd5c2dd7e5e5 ("igb: use generic filter control for ethertype filter")
> Cc: stable@dpdk.org
> Signed-off-by: Xiaozhen Ban <benhaz1024@gmail.com>
> ---
>  drivers/net/e1000/igb_ethdev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
> index 1716d6b90..325461247 100644
> --- a/drivers/net/e1000/igb_ethdev.c
> +++ b/drivers/net/e1000/igb_ethdev.c
> @@ -4599,6 +4599,7 @@ eth_igb_filter_ctrl(struct rte_eth_dev *dev __rte_unused,
>  	default:
>  		PMD_DRV_LOG(WARNING, "Filter type (%d) not supported",
>  							filter_type);
> +		ret = -EINVAL;
>  		break;
>  	}
> 

New design will be applied:

https://patchwork.dpdk.org/project/dpdk/patch/20210312174645.162801-2-thomas@monjalon.net/


> --
> 2.25.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-stable] [PATCH] net/e1000: fix filter control return value
  2021-03-17 11:23   ` Wang, Haiyue
@ 2021-03-18 11:44     ` Xiaozhen Ban
  2021-03-18 15:28       ` Wang, Haiyue
  0 siblings, 1 reply; 6+ messages in thread
From: Xiaozhen Ban @ 2021-03-18 11:44 UTC (permalink / raw)
  To: jia.guo, haiyue.wang; +Cc: dev, stable

OK, but I think this bug affects all stable release about 6 years before today.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-stable] [PATCH] net/e1000: fix filter control return value
  2021-03-18 11:44     ` Xiaozhen Ban
@ 2021-03-18 15:28       ` Wang, Haiyue
  2021-03-19  4:08         ` Xiaozhen Ban
  0 siblings, 1 reply; 6+ messages in thread
From: Wang, Haiyue @ 2021-03-18 15:28 UTC (permalink / raw)
  To: Xiaozhen Ban, Guo, Jia; +Cc: dev, stable

> -----Original Message-----
> From: Xiaozhen Ban <benhaz1024@gmail.com>
> Sent: Thursday, March 18, 2021 19:44
> To: Guo, Jia <jia.guo@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: RE: RE: [PATCH] net/e1000: fix filter control return value
> 
> OK, but I think this bug affects all stable release about 6 years before today.

I don't think so, since it is PMD internal ops, the real API 'rte_flow_ops_get'
always use RTE_ETH_FILTER_GENERIC. ;-)


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-stable] [PATCH] net/e1000: fix filter control return value
  2021-03-18 15:28       ` Wang, Haiyue
@ 2021-03-19  4:08         ` Xiaozhen Ban
  2021-03-25  8:46           ` [dpdk-stable] [dpdk-dev] " Zhang, Qi Z
  0 siblings, 1 reply; 6+ messages in thread
From: Xiaozhen Ban @ 2021-03-19  4:08 UTC (permalink / raw)
  To: jia.guo, haiyue.wang; +Cc: dev, stable

> > -----Original Message-----
> > From: Xiaozhen Ban <benhaz1024 at gmail.com>
> > Sent: Thursday, March 18, 2021 19:44
> > To: Guo, Jia <jia.guo at intel.com>; Wang, Haiyue <haiyue.wang at intel.com>
> > Cc: dev at dpdk.org; stable at dpdk.org
> > Subject: RE: RE: [PATCH] net/e1000: fix filter control return value
> > 
> > OK, but I think this bug affects all stable release about 6 years before today.

> I don't think so, since it is PMD internal ops, the real API 'rte_flow_ops_get'
> always use RTE_ETH_FILTER_GENERIC. ;-)

eth_igb_filter_ctrl() called by rte_eth_dev_filter_ctrl(), if application
developer know how to use the parameter filter_type correctly, it's OK. 
otherwise he will get rte_eth_dev_filter_ctrl() return value is success
but actually is failed.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] net/e1000: fix filter control return value
  2021-03-19  4:08         ` Xiaozhen Ban
@ 2021-03-25  8:46           ` Zhang, Qi Z
  0 siblings, 0 replies; 6+ messages in thread
From: Zhang, Qi Z @ 2021-03-25  8:46 UTC (permalink / raw)
  To: Xiaozhen Ban, Guo, Jia, Wang, Haiyue; +Cc: dev, stable



> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Xiaozhen Ban
> Sent: Friday, March 19, 2021 12:08 PM
> To: Guo, Jia <jia.guo@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/e1000: fix filter control return value
> 
> > > -----Original Message-----
> > > From: Xiaozhen Ban <benhaz1024 at gmail.com>
> > > Sent: Thursday, March 18, 2021 19:44
> > > To: Guo, Jia <jia.guo at intel.com>; Wang, Haiyue <haiyue.wang at
> > > intel.com>
> > > Cc: dev at dpdk.org; stable at dpdk.org
> > > Subject: RE: RE: [PATCH] net/e1000: fix filter control return value
> > >
> > > OK, but I think this bug affects all stable release about 6 years before today.
> 
> > I don't think so, since it is PMD internal ops, the real API 'rte_flow_ops_get'
> > always use RTE_ETH_FILTER_GENERIC. ;-)
> 
> eth_igb_filter_ctrl() called by rte_eth_dev_filter_ctrl(), if application developer
> know how to use the parameter filter_type correctly, it's OK.
> otherwise he will get rte_eth_dev_filter_ctrl() return value is success but
> actually is failed.

After check with Haiyue, we think the patch is still needed for LTS <= 19.11, so

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi




^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-03-25  8:46 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20201208081006.35125-1-benhaz1024@gmail.com>
2021-03-17  9:15 ` [dpdk-stable] [PATCH] net/e1000: fix filter control return value Xiaozhen Ban
2021-03-17 11:23   ` Wang, Haiyue
2021-03-18 11:44     ` Xiaozhen Ban
2021-03-18 15:28       ` Wang, Haiyue
2021-03-19  4:08         ` Xiaozhen Ban
2021-03-25  8:46           ` [dpdk-stable] [dpdk-dev] " Zhang, Qi Z

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git