From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 67628A00C2 for ; Fri, 6 Jan 2023 10:13:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6253940697; Fri, 6 Jan 2023 10:13:10 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 038C0400EF for ; Fri, 6 Jan 2023 10:13:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672996388; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xH90N2LyBGUG+t93Xa8zcK7YeMKqZIpaE+NXP6zEJi0=; b=iIhU/8TFNqgg3frBtVaUO1IIYYR3Gjh0HnoB//WpHgccjhVbxFQryD8rIODQnuEZB81Z2h w3fpy3E2fbnFiy9kRWEOTRemOBUaDy7OeB4m0VKspRquSXzbCFIQ/dxRayhbfAPHuZCNvB 2hc0JXBHO3rzdKJhV6KMIUv50Fqe/no= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-663-X_BPlk-oM9-07YKTA2_C6w-1; Fri, 06 Jan 2023 04:13:04 -0500 X-MC-Unique: X_BPlk-oM9-07YKTA2_C6w-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D099F3811F44; Fri, 6 Jan 2023 09:13:03 +0000 (UTC) Received: from [10.39.208.15] (unknown [10.39.208.15]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 73CFA140EBF5; Fri, 6 Jan 2023 09:13:02 +0000 (UTC) Message-ID: <28a661d2-d037-8497-70f5-7ba9f4216f27@redhat.com> Date: Fri, 6 Jan 2023 10:13:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v2 4/7] baseband/acc: acc100 fix queue mapping to 64 bits From: Maxime Coquelin To: Hernan Vargas , dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com, "stable@dpdk.org" References: <20230106054443.199473-1-hernan.vargas@intel.com> <20230106054443.199473-5-hernan.vargas@intel.com> <3982580c-efa0-441a-1599-1f9243aeaf7a@redhat.com> In-Reply-To: <3982580c-efa0-441a-1599-1f9243aeaf7a@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 1/6/23 10:12, Maxime Coquelin wrote: > > > On 1/6/23 06:44, Hernan Vargas wrote: >> Fix potential overflow for Q mapping extension to 64 bits. >> >> Fixes: 32e8b7ea35d ("baseband/acc100: refactor to segregate common code") >> >> Signed-off-by: Hernan Vargas >> --- >>   drivers/baseband/acc/rte_acc100_pmd.c | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/baseband/acc/rte_acc100_pmd.c >> b/drivers/baseband/acc/rte_acc100_pmd.c >> index 2f65f290b5..1ca95f4440 100644 >> --- a/drivers/baseband/acc/rte_acc100_pmd.c >> +++ b/drivers/baseband/acc/rte_acc100_pmd.c >> @@ -664,7 +664,7 @@ acc100_find_free_queue_idx(struct rte_bbdev *dev, >>       for (aq_idx = 0; aq_idx < qtop->num_aqs_per_groups; aq_idx++) { >>           if (((d->q_assigned_bit_map[group_idx] >> aq_idx) & 0x1) == >> 0) { >>               /* Mark the Queue as assigned */ >> -            d->q_assigned_bit_map[group_idx] |= (1 << aq_idx); >> +            d->q_assigned_bit_map[group_idx] |= (1ULL << aq_idx); >>               /* Report the AQ Index */ >>               return (group_idx << ACC100_GRP_ID_SHIFT) + aq_idx; >>           } > > Reviewed-by: Maxime Coquelin Also cc'ing stable since it is in v22.11 at least. > Thanks, > Maxime