From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F1D0EA0613 for ; Tue, 24 Sep 2019 20:17:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D97B92C23; Tue, 24 Sep 2019 20:17:21 +0200 (CEST) Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by dpdk.org (Postfix) with ESMTP id AEE1B2C23 for ; Tue, 24 Sep 2019 20:17:20 +0200 (CEST) Received: by mail-wm1-f65.google.com with SMTP id v17so1086504wml.4 for ; Tue, 24 Sep 2019 11:17:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=TMUfuUYQD0iec7jTsg1y3M4ByVuJ3enR+9jstAyEp88=; b=VLVJ1E+PvJZNkkHDrU+kkzu4zUWMjBzIzz0umgm0Goy9DcrZO8FZCp717AozyGrjHw v+vghxDv7vB0qOT7Mi9gDwYcbW1o7eBFeKdK7TeGnvp0K8EMsPykZnhDjnr3ADtYNn5/ HRAYqjOrpJjH2E7PH9lKaxNEYEfOpl99vIVb0Gwg4RZCHM4AGCY3gq8Kz+Zcyah/w41+ yfinxYu8Lx2j7UhzFzy/XFvCLiaWwXecmM5rptGmv7318f3jAxZabJhv0KU4IFNNHuAM OuSCjRGChX5TJ16R37NRroccUczRBc4j/txA4/7CdEQzlVBqmHiuNpZT3pq0kM1lL9ZP BJ1w== X-Gm-Message-State: APjAAAVIFoAwwHbRVtOIEjwR3sBixVJ15rQjKo0x6jZsESCIoP7ofzbs qNZipNvkZa0FZrwizpQ0S2U= X-Google-Smtp-Source: APXvYqyZ/x+vGbqI1CByNby8+CTyS3/6VEf69wyqPYp3t/bHyCRavZCNEw0bfwKQOUtDxlFA+DDWlA== X-Received: by 2002:a1c:3904:: with SMTP id g4mr1633228wma.116.1569349040238; Tue, 24 Sep 2019 11:17:20 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:7a8e:ed70:5c52:ea3]) by smtp.gmail.com with ESMTPSA id v7sm3147985wru.87.2019.09.24.11.17.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Sep 2019 11:17:19 -0700 (PDT) Message-ID: <28bdfe106d4aba2f6b3c9d070dfbc727c4484471.camel@debian.org> From: Luca Boccassi To: Bruce Richardson , stable@dpdk.org Cc: xuemingx.zhang@intel.com Date: Tue, 24 Sep 2019 19:17:18 +0100 In-Reply-To: <20190902144239.11292-1-bruce.richardson@intel.com> References: <20190902144239.11292-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH 17.11] mk: disable warnings for packed mem config data structure X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Mon, 2019-09-02 at 15:42 +0100, Bruce Richardson wrote: > The rte_mem_config data structure is marked as packed, but we access > members of that structure via pointers in the code. This leads to > warnings > with later gcc compilers e.g. gcc9, so disable those warnings to > allow > clean builds. >=20 > For older GCC versions, which may not have the flag, there is no need > to > filter it out as adding unrecognised warning disable flags to GCC is > always > safe [Ref:=20 > https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html > ] >=20 > Signed-off-by: Bruce Richardson < > bruce.richardson@intel.com > > > --- > mk/toolchain/gcc/rte.vars.mk | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/mk/toolchain/gcc/rte.vars.mk > b/mk/toolchain/gcc/rte.vars.mk > index e7008c052..ec082db99 100644 > --- a/mk/toolchain/gcc/rte.vars.mk > +++ b/mk/toolchain/gcc/rte.vars.mk > @@ -81,6 +81,8 @@ ifeq ($(RTE_DEVEL_BUILD),y) > WERROR_FLAGS +=3D -Werror > endif > =20 > +WERROR_FLAGS +=3D -Wno-address-of-packed-member > + > # There are many issues reported for strict alignment architectures > # which are not necessarily fatal. Report as warnings. > ifeq ($(CONFIG_RTE_ARCH_STRICT_ALIGN),y) Acked-by: Luca Boccassi Thanks Bruce, applied and pushed. --=20 Kind regards, Luca Boccassi