[dpdk-stable] [DPDK] examples/ipsec-secgw: fix unchecked return value

[dpdk-stable] [DPDK] examples/ipsec-secgw: fix unchecked return value

[Bernard Iremonger]

Check the return value of the rte_eth_dev_rss_hash_conf_get function.

Coverity issue: 344970
Fixes: 3a690d5a65e2 ("examples/ipsec-secgw: fix first packet with inline crypto")
Cc: stable@dpdk.org

Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
---
 examples/ipsec-secgw/ipsec.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/examples/ipsec-secgw/ipsec.c b/examples/ipsec-secgw/ipsec.c
index dc85adf..5f9d560 100644
--- a/examples/ipsec-secgw/ipsec.c
+++ b/examples/ipsec-secgw/ipsec.c
@@ -248,7 +248,14 @@ create_inline_session(struct socket_ctx *skt_ctx, struct ipsec_sa *sa)
 			/* Try RSS. */
 			sa->action[1].type = RTE_FLOW_ACTION_TYPE_RSS;
 			sa->action[1].conf = &action_rss;
-			rte_eth_dev_rss_hash_conf_get(sa->portid, &rss_conf);
+			ret = rte_eth_dev_rss_hash_conf_get(sa->portid,
+					&rss_conf);
+			if (ret != 0) {
+				RTE_LOG(ERR, IPSEC,
+					"rte_eth_dev_rss_hash_conf_get:ret=%d\n",
+					ret);
+				return -1;
+			}
 			for (i = 0, j = 0; i < dev_info.nb_rx_queues; ++i)
 				queue[j++] = i;
 
-- 
2.7.4

Re: [dpdk-stable] [DPDK] examples/ipsec-secgw: fix unchecked return value

[Thomas Monjalon]

07/08/2019 13:27, Bernard Iremonger:
> Check the return value of the rte_eth_dev_rss_hash_conf_get function.
> 
> Coverity issue: 344970
> Fixes: 3a690d5a65e2 ("examples/ipsec-secgw: fix first packet with inline crypto")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>

Please don't Cc stable@dpdk.org for internal testing.

Re: [dpdk-stable] [DPDK] examples/ipsec-secgw: fix unchecked return value

[Iremonger, Bernard]

Hi Thomas,

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Thursday, August 8, 2019 8:19 AM
> To: Iremonger, Bernard <bernard.iremonger@intel.com>
> Cc: stable@dpdk.org; qabuild <qabuild@intel.com>
> Subject: Re: [dpdk-stable] [DPDK] examples/ipsec-secgw: fix unchecked
> return value
> 
> 07/08/2019 13:27, Bernard Iremonger:
> > Check the return value of the rte_eth_dev_rss_hash_conf_get function.
> >
> > Coverity issue: 344970
> > Fixes: 3a690d5a65e2 ("examples/ipsec-secgw: fix first packet with inline
> crypto")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> 
> Please don't Cc stable@dpdk.org for internal testing.

Apologies, forgot that this was causing problems.

Regards,

Bernard.