From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org, John Baldwin <jhb@freebsd.org>,
Tyler Retzlaff <roretzla@linux.microsoft.com>
Subject: Re: [PATCH] freebsd/contigmem: fix function parameter list
Date: Wed, 24 May 2023 18:03:22 +0200 [thread overview]
Message-ID: <2907661.o0KrE1Onz3@thomas> (raw)
In-Reply-To: <20230522160203.GA24885@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
22/05/2023 18:02, Tyler Retzlaff:
> On Mon, May 22, 2023 at 10:22:41AM +0100, Bruce Richardson wrote:
> > Functions which take no parameters should explicitly have "(void)" as
> > the parameter list, rather than "()".
> >
> > Reported upstream on FreeBSD ports collection [1].
> >
> > [1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=271524
> >
> > Fixes: 764bf26873b9 ("add FreeBSD support")
> > Cc: stable@dpdk.org
> >
> > Reported-by: John Baldwin <jhb@FreeBSD.org>
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
Applied, thanks.
prev parent reply other threads:[~2023-05-24 16:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 9:22 Bruce Richardson
2023-05-22 16:02 ` Tyler Retzlaff
2023-05-24 16:03 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2907661.o0KrE1Onz3@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jhb@freebsd.org \
--cc=roretzla@linux.microsoft.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).