From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] mk: fix shell errors when building with clang
Date: Thu, 06 Apr 2017 16:33:31 +0200 [thread overview]
Message-ID: <2919831.1aLGMpDVn7@xps13> (raw)
In-Reply-To: <20170406141241.14061-1-olivier.matz@6wind.com>
2017-04-06 16:12, Olivier Matz:
> On my system, the version of the compiler is not properly retrieved,
> resulting in strange logs when building the dpdk:
> /bin/sh: line 0: test: too many arguments
>
> This happens when mk/toolchain/clang/rte.toolchain-compat.mk is included
> from a directory that use gcc to build (ex: kernel modules). In that
> case, the CLANG_VERSION variable contains spaces that breaks some shell
> calls to the test program.
>
> The error is because the output of "gcc -v" on my system contains 2 lines
> that matches the "version" string:
>
> Configured with: ../src/configure -v \
> --with-pkgversion='Debian 6.3.0-6' [...]
> gcc version 6.3.0 20170205 (Debian 6.3.0-6)
>
> This may be specific to Debian. Fix it by specializing the grep.
>
> Fixes: 2ef6eea891e5 ("mk: add clang toolchain")
>
> Cc: stable@dpdk.org
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
Applied, thanks
prev parent reply other threads:[~2017-04-06 14:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-06 14:12 Olivier Matz
2017-04-06 14:33 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2919831.1aLGMpDVn7@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).