From: Thomas Monjalon <thomas@monjalon.net>
To: Rakesh Kudurumalla <rkudurumalla@marvell.com>
Cc: stable@dpdk.org, dev@dpdk.org, david.marchand@redhat.com,
ferruh.yigit@intel.com, andrew.rybchenko@oktetlabs.ru,
ajit.khaparde@broadcom.com, jerinj@marvell.com
Subject: Re: [dpdk-stable] [PATCH v2] test: avoid hang if queues are full and Tx fails
Date: Fri, 12 Nov 2021 12:32:00 +0100 [thread overview]
Message-ID: <2935187.TuyvbHr83s@thomas> (raw)
In-Reply-To: <20210720165052.606038-1-rkudurumalla@marvell.com>
20/07/2021 18:50, Rakesh Kudurumalla:
> Current pmd_perf_autotest() in continuous mode tries
> to enqueue MAX_TRAFFIC_BURST completely before starting
> the test. Some drivers cannot accept complete
> MAX_TRAFFIC_BURST even though rx+tx desc count can fit it.
Which driver is failing to do so?
Why it cannot enqueue 32 packets?
> This patch changes behaviour to stop enqueuing after few
> retries.
If there is a real limitation, there will be issues in more places
than this test program.
I feel it should be addressed either in the driver or at ethdev level.
[...]
> @@ -480,10 +483,19 @@ main_loop(__rte_unused void *args)
> nb_tx = RTE_MIN(MAX_PKT_BURST, num);
> nb_tx = rte_eth_tx_burst(portid, 0,
> &tx_burst[idx], nb_tx);
> + if (nb_tx == 0)
> + retry_cnt++;
> num -= nb_tx;
> idx += nb_tx;
> + if (retry_cnt == MAX_RETRY_COUNT) {
> + retry_cnt = 0;
> + break;
> + }
next prev parent reply other threads:[~2021-11-12 11:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 12:47 [dpdk-stable] [PATCH] " Rakesh Kudurumalla
2021-07-20 16:50 ` [dpdk-stable] [PATCH v2] " Rakesh Kudurumalla
2021-10-19 10:19 ` Rakesh Kudurumalla
2021-10-29 7:18 ` Rakesh Kudurumalla
2021-11-12 11:32 ` Thomas Monjalon [this message]
2021-11-22 7:59 ` [EXT] " Rakesh Kudurumalla
2021-11-22 8:58 ` Thomas Monjalon
2021-11-29 8:52 ` Rakesh Kudurumalla
2021-11-29 9:13 ` Thomas Monjalon
2021-12-13 6:40 ` Rakesh Kudurumalla
2022-01-10 9:04 ` Rakesh Kudurumalla
2022-02-01 6:30 ` Rakesh Kudurumalla
2022-02-01 7:44 ` Thomas Monjalon
2022-02-14 4:56 ` Rakesh Kudurumalla
2022-05-09 10:01 ` Rakesh Kudurumalla
2022-05-24 5:39 ` Rakesh Kudurumalla
2022-05-25 8:02 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2935187.TuyvbHr83s@thomas \
--to=thomas@monjalon.net \
--cc=ajit.khaparde@broadcom.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinj@marvell.com \
--cc=rkudurumalla@marvell.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).