From: Thomas Monjalon <thomas@monjalon.net>
To: Mingjin Ye <mingjinx.ye@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org,
Anatoly Burakov <anatoly.burakov@intel.com>,
david.marchand@redhat.com, stephen@networkplumber.org,
bruce.richardson@intel.com
Subject: Re: [PATCH 1/3] bus/vdev: revert fix devargs in secondary process
Date: Wed, 19 Jun 2024 22:12:12 +0200 [thread overview]
Message-ID: <2935664.e6Ti0vRb3T@thomas> (raw)
In-Reply-To: <20240314093630.1066948-2-mingjinx.ye@intel.com>
14/03/2024 10:36, Mingjin Ye:
> The asan tool detected a memory leak in the vdev driver
> alloc_devargs. The previous commit was that when inserting
> a vdev device, the primary process alloc devargs and the
> secondary process looks for devargs. This causes the
> device to not be created if the secondary process does
> not initialise the vdev device. And, this is not the
> root cause.
>
> Therefore the following commit was reverted accordingly.
>
> Fixes: 6666628362c9 ("bus/vdev: fix devargs in secondary process")
>
> After restoring this commit, the memory leak still exists.
> A new patch has since fixed this issue.
>
> Fixes: 6666628362c9 ("bus/vdev: fix devargs in secondary process")
> Cc: stable@dpdk.org
>
> Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
Applied
The rest of the series is not cleared enough to be applied.
We need more precise explanation of the problem to solve,
and some good reviews please.
At this stage I'm confident enough only for this revert.
next prev parent reply other threads:[~2024-06-19 20:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240314093630.1066948-1-mingjinx.ye@intel.com>
2024-03-14 9:36 ` Mingjin Ye
2024-06-19 20:12 ` Thomas Monjalon [this message]
2024-03-14 9:36 ` [PATCH 2/3] bus/vdev: revert fix devargs after multi-process bus scan Mingjin Ye
2024-06-19 20:15 ` Thomas Monjalon
2024-06-20 6:10 ` Ye, MingjinX
2024-07-11 15:56 ` Burakov, Anatoly
2024-03-14 9:36 ` [PATCH 3/3] net/vdev: fix insert vdev core dump Mingjin Ye
2024-03-15 5:51 ` Jiang, YuX
2024-06-19 20:16 ` Thomas Monjalon
2024-06-20 6:41 ` Ye, MingjinX
2024-07-11 16:10 ` Burakov, Anatoly
2024-07-12 2:18 ` Ye, MingjinX
2024-07-12 8:38 ` Burakov, Anatoly
2024-07-16 9:53 ` [PATCH v2] " Mingjin Ye
2024-07-22 12:39 ` Burakov, Anatoly
2024-07-23 15:25 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2935664.e6Ti0vRb3T@thomas \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=mingjinx.ye@intel.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).