From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 02A67A00C4 for ; Thu, 12 May 2022 21:16:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ED8B941145; Thu, 12 May 2022 21:16:04 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id 2711740E64; Thu, 12 May 2022 21:16:02 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 356DF320091B; Thu, 12 May 2022 15:15:58 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 12 May 2022 15:15:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1652382957; x= 1652469357; bh=Rf7XB8lbsKmBCtZ9xe+3KOv14t3D451HeOBsTL2TtGc=; b=X 1lY5kmVcCdv2unZq9nrxQX3WkfCNHvoiBZuvVUD3KJiWncr8IJxoy3/Zi/LjNQg/ YqKWIziGBYZiM67aoxcIUbhfEQhIjWRu6ppwT6EXn4d3IqDrDKXTCCsWxZvgzCCi 4Mw2Wy80wjyMqEVEfe8+GzDuMwRbuCRznTd6CTUkfzsozOoKv9gPDBLX4f0oXoRV 3vahnsgUg5n2JrGa+V2Y72hLs87MrqueR0JwSIzasq6CxACIyC8sChZqYyJXCwe1 +895qrhc2YgfApgc2IstvJ67RKjlkWxjd0cWLzLJEJnNUTBGL7bU3ZLT6X+1NLab TQvrvJIWXzo6vbwpAVwqQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1652382957; x=1652469357; bh=Rf7XB8lbsKmBC tZ9xe+3KOv14t3D451HeOBsTL2TtGc=; b=ve1XgCva1aiU8QACbAEaX23KpQ/lz FONPal1XHZGHdB/CMxX8q3gnE5EkFLS0FRZ6uz8u7Ci0t/SqEwoHs51TOaP0CgCL ToSIvrMfCXZR3tmnCSnXmSXbsonpcDRYdijxLbxVjUN8CovnELzudoQeLkPjyXOK 4BJnmZyRfDtxXpRmQODdnwj6C2dbV1DJGhHD3jFlmKZvZ3/BsTdbTnop7O7Kl73l zL534v4yTU4F7vHvB5JZ3xcateEypxe/uDm3Mtjvv9ySq5tyGwRpJWCPacXlgI9Z ZUG4NaMyv6gTOpuc7OMkd8PQaYhzRBgc/+0QpZXtofmg38LcAzORBXYZA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrgeejgddufeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 12 May 2022 15:15:56 -0400 (EDT) From: Thomas Monjalon To: Jeff Daly Cc: "Zhang, Qi Z" , "Yang, Qiming" , "Wu, Wenjun1" , "Zhao1, Wei" , Xiao Zhang , Xiaolong Ye , Lunyuan Cui , "dev@dpdk.org" , "stable@dpdk.org" Subject: Re: [PATCH] net/ixgbe: Limit SDP3 check of TX_DISABLE to appropriate devices Date: Thu, 12 May 2022 21:15:54 +0200 Message-ID: <2941580.687JKscXgg@thomas> In-Reply-To: References: <20220510185725.27001-1-jeffd@silicom-usa.com> <10661272.5MRjnR8RnV@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org 12/05/2022 19:01, Jeff Daly: > From: Thomas Monjalon > > 11/05/2022 13:43, Zhang, Qi Z: > > > From: Jeff Daly > > > > > > > > 1ca05831b9b added a check that SDP3 (used as a TX_DISABLE output to > > > > the SFP cage on these cards) is not asserted to avoid incorrectly > > > > reporting link up when the SFP's laser is turned off. > > > > > > > > ff8162cb957 limited this workaround to fiber ports > > > > > > > > This patch: > > > > * Adds devarg 'fiber_sdp3_no_tx_disable' not all fiber ixgbe devs use > > > > SDP3 as TX_DISABLE > > > > > > > > Fixes: 1ca05831b9b ("net/ixgbe: fix link status") > > > > Fixes: ff8162cb957 ("net/ixgbe: fix link status") > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: Jeff Daly > > > > > > Acked-by: Qi Zhang > > > > > > Applied to dpdk-next-net-intel. > > > > There is a lack of context in this description. > > I don't know what SDP3 and TX_DISABLE refers to. > > Please make more complete sentences, thanks. > > > > I don't want to sound obtuse here, but this is a fix to a specific Intel NIC driver. Any symbols or abbreviations or definitions used in a device driver are almost always in the manual. While SDP3 means something specific to the Intel 82599 and X550 (and probably others), it probably doesn't appear in a driver from Marvell for example. So, in this case [S]oftware [D]efined [P]ins [3] (out of 0-3) is specifically talking about the Intel X550. I'm familiar enough with the hardware to recognize that, but if I was to look at a Marvell driver and saw something I didn't recognize like that, I'd be checking the Marvell manual. Of course we can spend hours checking code and manuals. But if we need to look to a lot of commits, it is a lot more convenient to have a summary of this information in the commit log. > What I'm describing here is the fact that the TX_DISABLE signal (a signal defined in the SFP spec) from the NIC as implemented by the Software Defined Pin (3) by many (most?) implementations that are using this Intel driver, is not specifically the *only* use of SDP3. A later patch limited the check (correctly) to fiber implementations (which is the only thing that makes sense), and *this* patch adds a module switch for platforms to disable this check in the event that they (as they are perfectly allowed to) don't use SDP3 as TX_DISABLE. Thank you for the explanation.