From: Thomas Monjalon <thomas@monjalon.net>
To: Matan Azrad <matan@mellanox.com>
Cc: stable@dpdk.org, "Iremonger,
Bernard" <bernard.iremonger@intel.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Doherty, Declan" <declan.doherty@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] app/testpmd: fix slave port detection
Date: Mon, 14 May 2018 04:00:56 +0200 [thread overview]
Message-ID: <2951805.7A76KTY0QU@xps> (raw)
In-Reply-To: <8CEF83825BEC744B83065625E567D7C24E0CA4F4@IRSMSX108.ger.corp.intel.com>
> > > Testpmd allows to create and control bonding devices by run time
> > > command lines using the bonding PMD API.
> > >
> > > Some bonding device slaves operations(close, stop, etc) should not be
> > > used by the application and must be managed by the bonding PMD.
> > >
> > > Thus, Testpmd manages slave flags to prevent the special operations
> > > calls and when a slave is added to bonding device by a run time
> > > command line, the flag is set.
> > >
> > > There is one more way to define the slaves for a bonding device using
> > > EAL command line and Testpmd doesn't set the slave flag in this case
> > > what causes to the special operations to be called by Testpmd.
> > >
> > > Add one more check to detect bonding slave device.
> > >
> > > Fixes: 41b05095c4d1 ("app/testpmd: fix bonding start")
> > > Fixes: 0e545d3047fe ("app/testpmd: check stopping port is not in
> > > bonding")
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Matan Azrad <matan@mellanox.com>
>
> Acked-by: Bernard Iremonger <Bernard.iremonger@intel.com>
Applied, thanks
prev parent reply other threads:[~2018-05-14 2:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-28 11:17 [dpdk-stable] " Matan Azrad
2018-04-22 22:58 ` Thomas Monjalon
2018-05-11 16:09 ` [dpdk-stable] [dpdk-dev] " Iremonger, Bernard
2018-05-14 2:00 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2951805.7A76KTY0QU@xps \
--to=thomas@monjalon.net \
--cc=bernard.iremonger@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=matan@mellanox.com \
--cc=stable@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).