From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57E3BA0562 for ; Sun, 29 Mar 2020 11:06:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1DED0F12; Sun, 29 Mar 2020 11:06:19 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 92581F12; Sun, 29 Mar 2020 11:06:16 +0200 (CEST) IronPort-SDR: um9ElvC3dF26La0eI8olEG3azBO9vm/DXOmzKFUZ28Dz1DAAOC+L31BJ//pQQVMOXNUTLUKhTN BfDGBTzC/vVQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2020 02:06:14 -0700 IronPort-SDR: sm48A/ZfXBnOSJa8aTz4dKlpEl0TfAIVmcg6Xq7VCBzFm8oK8UiScFwFyXXHHF1HsMnUApihv2 YzRwOo54GccQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,319,1580803200"; d="scan'208";a="283298260" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga002.fm.intel.com with ESMTP; 29 Mar 2020 02:06:14 -0700 Received: from shsmsx605.ccr.corp.intel.com (10.109.6.215) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 29 Mar 2020 02:06:14 -0700 Received: from shsmsx602.ccr.corp.intel.com (10.109.6.142) by SHSMSX605.ccr.corp.intel.com (10.109.6.215) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 29 Mar 2020 17:06:11 +0800 Received: from shsmsx602.ccr.corp.intel.com ([10.109.6.142]) by SHSMSX602.ccr.corp.intel.com ([10.109.6.142]) with mapi id 15.01.1713.004; Sun, 29 Mar 2020 17:06:11 +0800 From: "Zhang, Xiao" To: Ori Kam , "dev@dpdk.org" CC: "Wang, Ying A" , "Zhang, Qi Z" , "Zhao1, Wei" , "stable@dpdk.org" Thread-Topic: app/testpmd: fix PPPOES flow API Thread-Index: AQHWBBGlpU3Uumzm102lBgy06K+oaKhemB+AgACm4VA= Date: Sun, 29 Mar 2020 09:06:11 +0000 Message-ID: <2966f158164c411e897b3ab741787eea@intel.com> References: <20200327081926.6154-1-xiao.zhang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-reaction: no-action dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] app/testpmd: fix PPPOES flow API X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi Ori, > -----Original Message----- > From: Ori Kam > Sent: Sunday, March 29, 2020 2:28 PM > To: Zhang, Xiao ; dev@dpdk.org > Cc: Wang, Ying A ; Zhang, Qi Z > ; Zhao1, Wei ; stable@dpdk.org > Subject: RE: app/testpmd: fix PPPOES flow API >=20 > Hi Xiao, >=20 > Is the proto_id part of the basic header or not? Proto_id is part of PPPOE session header, >=20 > From the spec it looks like a different header. >=20 > If it is part of the original header then all documentations and rte_stru= cts should > be changed, to reflect this. >=20 > It will be very helpful if the patch message would explain the bug and wh= y it was > changed. Okay, will add more message. The next value of the ITEM_PPPOE_PROTO_ID shou= ld be unsigned value but not item list. >=20 > Also please see inline other comment. >=20 > Best, > Ori >=20 > > -----Original Message----- > > From: Xiao Zhang > > Sent: Friday, March 27, 2020 11:19 AM > > To: dev@dpdk.org > > Cc: Ori Kam ; ying.a.wang@intel.com; > > qi.z.zhang@intel.com; wei.zhao1@intel.com; Xiao Zhang > > ; stable@dpdk.org > > Subject: app/testpmd: fix PPPOES flow API > > > > The command line to create RTE flow for specific proto_id of PPPOES is > > not correct. This patch is to fix this issue. > > > > Fixes: 226c6e60c35b ("ethdev: add PPPoE to flow API") > > Cc: stable@dpdk.org > > > > Signed-off-by: Xiao Zhang > > --- > > app/test-pmd/cmdline_flow.c | 13 +++---------- > > 1 file changed, 3 insertions(+), 10 deletions(-) > > > > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > > index a78154502..c25a2598d 100644 > > --- a/app/test-pmd/cmdline_flow.c > > +++ b/app/test-pmd/cmdline_flow.c > > @@ -768,7 +768,6 @@ static const enum index next_item[] =3D { > > ITEM_GTP_PSC, > > ITEM_PPPOES, > > ITEM_PPPOED, > > - ITEM_PPPOE_PROTO_ID, > > ITEM_HIGIG2, > > ITEM_TAG, > > ITEM_L2TPV3OIP, > > @@ -1030,11 +1029,6 @@ static const enum index item_pppoed[] =3D { > > > > static const enum index item_pppoes[] =3D { > > ITEM_PPPOE_SEID, > > - ITEM_NEXT, > > - ZERO, > > -}; > > - > > -static const enum index item_pppoe_proto_id[] =3D { > > ITEM_PPPOE_PROTO_ID, > > ITEM_NEXT, > > ZERO, > > @@ -2643,10 +2637,9 @@ static const struct token token_list[] =3D { > > [ITEM_PPPOE_PROTO_ID] =3D { > > .name =3D "proto_id", > > .help =3D "match PPPoE session protocol identifier", > > - .priv =3D PRIV_ITEM(PPPOE_PROTO_ID, > > - sizeof(struct rte_flow_item_pppoe_proto_id)), > > - .next =3D NEXT(item_pppoe_proto_id), > > - .call =3D parse_vc, > > + .next =3D NEXT(item_pppoes, NEXT_ENTRY(UNSIGNED), > > item_param), > > + .args =3D ARGS(ARGS_ENTRY_HTON > > + (struct rte_flow_item_pppoe_proto_id, proto_id)), >=20 > Where is the memory for this proto_id is defined? Do you mean this? lib/librte_ethdev/rte_flow.h 1360 struct rte_flow_item_pppoe_proto_id { 1361 rte_be16_t proto_id; /**< PPP protocol identifier. */ 1362 }; >=20 > > }, > > [ITEM_HIGIG2] =3D { > > .name =3D "higig2", > > -- > > 2.17.1