From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8AC85423CB for ; Thu, 26 Jan 2023 10:14:20 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5D09940697; Thu, 26 Jan 2023 10:14:20 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) by mails.dpdk.org (Postfix) with ESMTP id A0C73400D7; Thu, 26 Jan 2023 10:14:19 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MUj7dv+4JYNeqQhjlMJfVC8SkyFghcm1Onaiuvp82Mix/bso40pVMgo2oDf5C99CkM5EpAd3c92mZPCE70VJ510DSpzXSLMcHwvjy3d4IZE7A9QOy4Kr9Lsiqt2EhnCpWwF0Wt2ApvZdDlqVLzD5La4EgDjc7jdA8JRpMwXWuMZV0GKaMsTCcJMc2Ph9XX3gX/XEYWYIkjFyYRxV/ZrHp6+k0eoeOc0jVvF9ABX43T+qp3nhvJQQA8ANTszXFJVIxIJKOjsaUKd2I8T4LtdjOtGthLM5GSPso431L1oHmy5keyPhhhPIafnKsnrnR+AnLs58Lct80jcwhMg90RUmRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y+D/hPWAZzIxzyec0tGVZlTmvETinG58s3ZELB2LGZ8=; b=lCYeqGgHJqdS8rVWE4zbK27JFOzjsiX3gRUHmazhDXA30rH+TO4q66wMYV9HXgrQ6Jb4O9auo3IxiYAfwXkGxx5ub8/3UJO9L47tB4JTfRLfnttuu1oU0sqGhWbmxBADchnc5ka6QiVE+ohrRIDsKhZBjZ2l+n/I29Crr2sdQR/u4ENVGYIPuUDIf51gf/VHAP7WzzmY2vFpXe1SWxWj2Xb2lWEICHPkgQtDQ5TNCmzMGX/r2FSJz3X7mjFQc4P5m8OHoqg55TbSC7dcAmC5SIlCC+7+FomKCmzs+G253BPcPT6YhxzWLTYhYLzmvGPQDYLlHd5MaSnts0uSP7QHPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y+D/hPWAZzIxzyec0tGVZlTmvETinG58s3ZELB2LGZ8=; b=ogWpMuwPKqeCI0tYOkeJjKiQueZx250AnB1Vxik4Yu8sLP8zPbxGdD3t2Jyv6dKh8a4sbGC7Kpy2YIbIxgSwF2F31fT7/tn2kyYtYal0gHUkd4CL0yDsKiI/VlG8cSSKsWJNfU5MnWz7DvBFn/0ZTcUdZFNtqNlrlklL5WjV9C4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH8PR12MB8432.namprd12.prod.outlook.com (2603:10b6:510:25b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.22; Thu, 26 Jan 2023 09:14:17 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a%8]) with mapi id 15.20.6043.022; Thu, 26 Jan 2023 09:14:11 +0000 Message-ID: <2985c90e-3d71-cd99-e1d6-2353ba97574a@amd.com> Date: Thu, 26 Jan 2023 09:14:06 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] net/nfp: fix teardown of flows sharing a mask ID Content-Language: en-US To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, stable@dpdk.org References: <20230124071631.38272-1-chaoyong.he@corigine.com> From: Ferruh Yigit In-Reply-To: <20230124071631.38272-1-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0403.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:f::31) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH8PR12MB8432:EE_ X-MS-Office365-Filtering-Correlation-Id: 33cffa24-e6d3-44ef-0ced-08daff7daf91 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6XkIAcwpOJnueZOf8SeJl/cVz6nvLK++MR++qQfz27M8mCdLpivj0cneYasHFJeV/z7aF7WolEpgA08VF4immF0dWL/ADRZGS1e7iWZrgpTe4TyJeX/mUmGVMtxYrKIrWRxxx11V4bZ19HoDnJQNeUe+OMTz5MM/C74WJIJVGA6MaoYf6cCyAAhPJ7OSzAkJnHDRd1oxWebnn3Ictt2NuaY7mpyD18557cefFTJzZPMovg1sVrcuZa41O9F1+q6j1kJ5gCxLi/bO9zndPaeUfY+l0lYUQ/yfUN9gkpnnIuStyXvIEBcf9F65Nmnkrfh23aNTjd5SJX2PWHgDHMDxJUfmmok9SLSK/tSPmFh+1sq/UvkhRVJsl8qHePEPPbfAWde7yl/0ji2YICiswpheH43/z0Dj0VRJPpZMHTNUjbXP1br6wAqeAyCsTDT9D4Lm27YQneKFIIRbR0GYOnAmpcIENB9DfqWAkhQK4k5yIu7heN4QII0kDUePQ6K3Aq5QTJF+VHojUHy3CgBnB+PHucnbDTMaBta90dqJtGLF+lu3ogpqrZwtHf5EFESLyMUYtTzcJUhDMvLCfL7ZGz9edk1vdMNZ2kDYdvv+WYQbdCqCSZZFrLRVdeY+xV0mHJyIaoIwjIaUg88ChgenFqgckIP6MB4/VJaq2CS7yD2nbrhp8BUZ/3EiRLLRgWrMsbgcN/XPZZdR+xt83JdgnRVbpGR+4CfO5DBW0a5FDx9MPjI= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(376002)(366004)(346002)(39860400002)(136003)(396003)(451199018)(316002)(38100700002)(41300700001)(8676002)(66476007)(66556008)(4326008)(66946007)(31696002)(44832011)(5660300002)(86362001)(8936002)(36756003)(2906002)(53546011)(6506007)(26005)(6512007)(186003)(31686004)(66899018)(478600001)(6486002)(83380400001)(66574015)(6666004)(2616005)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UzlIY0hQaFNvRk4wd0x3cFlLV3ZYdWdYQkVGMFFIZEF0T21NcGV2TkYwalVz?= =?utf-8?B?SjB5UVRCZzIrRnIzZGxISEdpcTZwRnNLMk8zT0dyN2tWanVhZHhFZ2FsK2lM?= =?utf-8?B?Y1llVnNEc2tHRE1iSktOTXFKL0g5amUyVVR1NjBnUWxXT1NBdlg2UEhYMFlU?= =?utf-8?B?NFlJdCtZMkg4UlBKd0V2cDVyalkyNEdwM2FJTHVraTY0dm85NnFJbFlqSWFv?= =?utf-8?B?Z3lINWFnM2l1U2k5S0tRdnlOSWJvOE5uL2syQU1BNnh1bmdzSU0vVzVHb0lP?= =?utf-8?B?SXROLzc0SlRXVSsvZEV4Z0xxKy9MOHZnODF1SmNrRTFnYktwQXFlZm42K2Nk?= =?utf-8?B?bFNEcTJld1RaUDQ1MTJvcHB5NVlUZGZZZFJjQnN5RS9pRDFJWlNnMmpzRzMx?= =?utf-8?B?enhZTk81a3hsUm9rZFF2Z0czL3ZEVzVrVTNidHl2aTdiNHJSTURacWRaWG9C?= =?utf-8?B?NjZnQmNkODZDZDBiejlLYVRyanBCRURZUmNrek5FSkdBNVFOazJxUnd2STd2?= =?utf-8?B?RHdmTnVROTVuRnpLVFFRMmlSR2dtWWowM1VEemtrZnlHZkRPeWgwc0pvc201?= =?utf-8?B?bm1mZDFkUTk1eENHR25KR3VoT2VXR2ZIUXJ3ZHhobldqaVZmT1ovek1jMzQ3?= =?utf-8?B?RnpvZWU1YUVFMFhYOCtHQmlWR3l3V3ZHcWdXVzI4ZXY5aXo3SG1NYno5cHBZ?= =?utf-8?B?bkZjNTE4R2lmSktxYWY2dHJGdVRKdVQxYStGYWJYeVBMamdYanphbVFYbWRR?= =?utf-8?B?eVF5R1pTT2dLU0paRWRuRTI4VkxobG04dkI3dWdOSkNrc20yajJmZVJiY1JO?= =?utf-8?B?c2Jwd2N0REU4WUJYMVIrcm5uSWpZbS82SFErcCt4Q2dWN0Q4Qk5pN09wbnBG?= =?utf-8?B?a2ZKbjVaRGg5QVZZMlNPU0p1eW1iK0ZOMTQvaTRLQkt2emI2TFNIcmRQV1V0?= =?utf-8?B?UHFJUVprMU44MFJHQTFtSlZobFpKaFRGMnJqK3ZGakF2MWpaSEQxTThNK0Zz?= =?utf-8?B?b093dWJyM1VmTWY0cVRoMG1iam9MVlYwQ05mbHp1ZlVwTGoxMEJNQnlxeXlY?= =?utf-8?B?eno5UGVCVmNEU1pvbGR0MUV0MXdDaGZFR0k4K0NjRCtlZXgrdXhtUTlEaDVO?= =?utf-8?B?c0dtaDN2Z1BER2d0ZytQYmtoZmhWVmpHcGRScUJJMzRLd0pmZ3c2bmRGNGlS?= =?utf-8?B?aG81WVpDOWtjVHYzcW53TlFrZnpEd21BdEEwcUFTNTA0NXdTTmpLVHVXeU0z?= =?utf-8?B?bm9VSXBoeVZVRzYvSUtjenVrOTJXeGc2Ukk1T2Q2QUlDYTdVUDdiVUZJWE1P?= =?utf-8?B?dTV2RWFoUG5FWkUvSHR2VFhIcGlJY09abHhxTUlleHkvNytraXgrS2o0VXdW?= =?utf-8?B?NU1GQjlSTU5oUHJZN1ZidTg5RmFQaitPK3dVOG1vUjFtN2lJRitWR1dadXZD?= =?utf-8?B?bG9SYjRSMjZielptbFJNNkM3cmRjdUN6S3JwZllLRlFRMWVEOWZlb25oaUl0?= =?utf-8?B?ZFh3U2dhejRFRVBWTkJtRm13ekRkaTdZbjNyNGZoNnZFZ2wyWFA0YlBVbUVV?= =?utf-8?B?WVhyaHBQeklhSm9aeXpGZ3YyNUZZRzdKdVdLWnFCeVBDaGhKVi9HNFVOc20v?= =?utf-8?B?MldyUUVZU1FVbWU5YTUvQ3p6MFR6bExuOWIwOWxrZVhocHNGTVF0Q1U4clo0?= =?utf-8?B?R0l1VGRIeGJNQWwzNGRNallEaVhUYThQQ1E2WVpZbXQ4VEhyZlRTWWk2UDZ1?= =?utf-8?B?KzJ1RXBvaG0xQjhxd2plUTZZQ2xPc0pyYWhTbnJ5NHo0WjQ3Zk5pc1NkbkJN?= =?utf-8?B?ZFh6cFJJNENUR2FUSFpYc1FBeE8raFoxNVNVTzRqcWllcC9XZXhsTHRMZ0dK?= =?utf-8?B?RDZ6YitIUllBb0pLQTZFRGxPS0VGUnEyRXRZYkRHZ0ZPWC9vUEtHeWIzbGdz?= =?utf-8?B?cjg3RW1WY0M1bVN4d2lCOG5DZkpJbkN2OG1XdGttbGdTUEY3eFMvdkFrOW5C?= =?utf-8?B?VVNCUmpWTXNjYXlXcmNSZGhEZkxrMXJERzhxbFNwTCs1MWtWZEhNN0RxR1F5?= =?utf-8?B?dDFZVWZMMG1sSGxhanQ1Z0RYZFpOYnNSTThiV3RJdTk3UE92NlUwOUxxbzVx?= =?utf-8?Q?mZBgmOW0S7OFITqlwxQvuYmrx?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 33cffa24-e6d3-44ef-0ced-08daff7daf91 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2023 09:14:11.0203 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UXV9CE5a0jerFoQVQLtOsv0jYzdFg07QrOJb+9v/IGSX9Fn+xoysw9475CIjTQpZ X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB8432 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 1/24/2023 7:16 AM, Chaoyong He wrote: > The same data in mask section of different flow add/delete control > messages will share the same mask ID of mask table. The first flow > add control message and the last flow delete control message for a > specific mask ID should have the NFP_FL_META_FLAG_MANAGE_MASK flag set, > this will indicate to the flower firmware to allocate/deallocate the > mask table entry. > > The original logic wrongly process the flow delete control message, > and caused the first flow delete control message to have the > NFP_FL_META_FLAG_MANAGE_MASK flagset, thus the flower firmware > deallocate the mask table entry on the first delete. This in turn > prevented all the other flows sharing the same mask ID from offloading. > > Fixes: ac09376096d8 ("net/nfp: add structures and functions for flow offload") > Cc: stable@dpdk.org > > Signed-off-by: Chaoyong He > Reviewed-by: Niklas Söderlund Applied to dpdk-next-net/main, thanks.