* [dpdk-stable] [PATCH] lib/librte_net: fix bug for ipv4 checksum calculating
@ 2020-05-26 10:08 guohongzhi
2020-06-24 11:53 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: guohongzhi @ 2020-05-26 10:08 UTC (permalink / raw)
To: dev
Cc: stable, olivier.matz, mb, konstantin.ananyev, jiayu.hu,
ferruh.yigit, nicolas.chautru, cristian.dumitrescu, zhoujingbin,
chenchanghu, jerry.lilijun, haifeng.lin, guohongzhi1
From: Hongzhi Guo <guohongzhi1@huawei.com>
0xffff is invalid for IPv4 checksum(RFC1624)
Fixes: 6006818cfb26 ("net: new checksum functions")
Cc: stable@dpdk.org
Reviewed-By: Morten Brørup <mb@smartsharesystems.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
Signed-off-by: Hongzhi Guo <guohongzhi1@huawei.com>
---
lib/librte_net/rte_ip.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_net/rte_ip.h b/lib/librte_net/rte_ip.h
index 1ceb7b7..ece2e43 100644
--- a/lib/librte_net/rte_ip.h
+++ b/lib/librte_net/rte_ip.h
@@ -267,7 +267,7 @@ rte_ipv4_cksum(const struct rte_ipv4_hdr *ipv4_hdr)
{
uint16_t cksum;
cksum = rte_raw_cksum(ipv4_hdr, sizeof(struct rte_ipv4_hdr));
- return (cksum == 0xffff) ? cksum : (uint16_t)~cksum;
+ return (uint16_t)~cksum;
}
/**
--
2.21.0.windows.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH] lib/librte_net: fix bug for ipv4 checksum calculating
2020-05-26 10:08 [dpdk-stable] [PATCH] lib/librte_net: fix bug for ipv4 checksum calculating guohongzhi
@ 2020-06-24 11:53 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2020-06-24 11:53 UTC (permalink / raw)
To: guohongzhi1
Cc: dev, stable, olivier.matz, mb, konstantin.ananyev, jiayu.hu,
ferruh.yigit, nicolas.chautru, cristian.dumitrescu, zhoujingbin,
chenchanghu, jerry.lilijun, haifeng.lin
26/05/2020 12:08, guohongzhi:
> From: Hongzhi Guo <guohongzhi1@huawei.com>
>
> 0xffff is invalid for IPv4 checksum(RFC1624)
>
> Fixes: 6006818cfb26 ("net: new checksum functions")
> Cc: stable@dpdk.org
>
> Reviewed-By: Morten Brørup <mb@smartsharesystems.com>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
>
> Signed-off-by: Hongzhi Guo <guohongzhi1@huawei.com>
The Signed-off should be in chronological order, before reviews.
As suggested in previous patch, the title should be
net: fix IPv4 checksum
I am doing above modifications while merging.
More advices about submitting patches:
- use -v2, -v3, etc when sending new versions
- add a changelog below the line ---
- use --in-reply-to to keep all versions threaded
> @@ -267,7 +267,7 @@ rte_ipv4_cksum(const struct rte_ipv4_hdr *ipv4_hdr)
> {
> uint16_t cksum;
> cksum = rte_raw_cksum(ipv4_hdr, sizeof(struct rte_ipv4_hdr));
> - return (cksum == 0xffff) ? cksum : (uint16_t)~cksum;
> + return (uint16_t)~cksum;
> }
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-24 11:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-26 10:08 [dpdk-stable] [PATCH] lib/librte_net: fix bug for ipv4 checksum calculating guohongzhi
2020-06-24 11:53 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).